Commit graph

3093 commits

Author SHA1 Message Date
rhymes
0c6f34bb2a Add more specs for events (#4444) [ci skip] 2019-10-18 10:30:07 -04:00
Jacob Herrington
4f0c1bd4b4 Remove unused import (#4484) [ci skip] 2019-10-17 19:02:36 -04:00
Mac Siri
d976eb7ab6 Create InternalPolicy (#4380)
* Ensure verify_authorized in internal

* Create internal_policy

* Replace ArticlePolicy usage with InternalPolicy

* Replace BufferUpdate&CommentPolicy with InternalPolicy

* Remove verbose authorize_admin

* Forgot to remove coresponding specs

* Create specs for InternalPolicy

* Expand policy access on internal's broadcast

* Refactor

* Create shared spec

* Create request specs

* Add additional test cases
2019-10-17 14:21:43 -04:00
rhymes
232bc48e3e Fix eager loadings (#4365) 2019-10-17 14:08:31 -04:00
RajaSK05
6b83cd0981 Refactor to component model (#4478) 2019-10-17 12:56:33 -04:00
Anna Buianova
41ba46623c Increase redirects limit when fetching podcasts (#4479) 2019-10-17 11:24:29 -04:00
Ryan Palo
6cbad11b8f [DOC] Update "Installing on Linux" docs with more error messages (#4468) [ci skip] 2019-10-17 11:24:13 -04:00
rhymes
baa279b963 [DOC] Add PostgreSQL to the stack list (#4473) [ci skip] 2019-10-17 10:56:00 -04:00
Abenet Tamiru
4c873c1a88 Specify postgres version in docker-compose.yml (#4477) [ci skip] 2019-10-17 10:55:06 -04:00
rhymes
89476fae08 Upgrade Ruby to 2.6.5 (#4451) 2019-10-17 09:34:31 -04:00
Eddie Hale
f7eba319b5 Fixing eslint errors and warnings under /app/javascript/packs (#4465)
Changes:
 - Refactored articleForm.jsx by moving loadForm() before document.ready.then()
 - Removed 'function' in .then() and modified to .then(() => {
 - Removed unused function 'isUserSignedIn' in Onboarding.jsx

See: #2470
2019-10-17 09:29:40 -04:00
Jacob Herrington
d339bebca0 Remove unused function (#4467) 2019-10-17 08:07:49 -04:00
Vidhi Bagadia
f5fa1fb01c Persist Canvas State on Resizing (#4476) 2019-10-17 08:07:18 -04:00
José Chaves Neto
67089f50ff Refactor initializeTimeFixer.js (#4416)
* refactor initializeTimeFixer.js

* apply feedback

* apply review

* fix bugs
2019-10-17 08:05:45 -04:00
Kushal Niroula
ae9a10fb4d Fix post title going out of the box (#4392) 2019-10-16 16:35:09 -04:00
Reece Dunham
3bd1b8ac27 Fix some strange wordings on the pro dashboard (#4461) [ci skip] 2019-10-16 16:22:47 -04:00
rhymes
83291b16c6 Update API docs to add error info and other small fixes (#4459) [ci skip] 2019-10-16 15:08:49 -04:00
Mac Siri
52401109c5
Update CODEOWNERS [ci skip] 2019-10-16 15:02:33 -04:00
RakChamp25
00f6f45334 Refactor readingList.jsx (#4388) [ci skip] 2019-10-16 10:40:01 -04:00
Araslanov Evgeny
02a75b6efa Remove unused methods _without_delay (#4366) [ci skip] 2019-10-16 10:35:49 -04:00
Phong Truong
89af535146 Make follow button vertically-centered (#4403) [ci skip] 2019-10-16 10:33:22 -04:00
Yash Dave
d307ce7469 Fix JavaScript Console errors in /Comments sub-page of any article (#4446)
* Fix JavaScript Console errors in /Comments sub-page of any article

- Make use of `document.body.contains()` to check if the element is present before trying to Add or Remove Event listeners or assign attribute values to the same.

* Implement recommendations for changes

- Switch String.match() to Regex.test() in order to have consistent Boolean return.
- Switch if(document.body.contains(element)) to if(element) as no need to check if the element is in visible context, only whether present or not.

* Implement recommendations for changes

- Switch String.match() to Regex.test() in order to have consistent Boolean return for isIOSDevice().
- Switch if(document.body.contains(element)) to if(element) as no need to check if the element is in visible context, only whether present or not.
2019-10-16 09:06:28 -04:00
Anna Anks Nowak
c4b5530e2e Add info about bumping API version to docs.dev (#4454)
* Add views count for authenticated users articles [#4250]

* Bump API version to 0.5.6 [#4250]

* Add info about bumping API docs version requirement

* Fix Create pull request link by linking to the docs
2019-10-16 09:04:36 -04:00
rhymes
9c76663e1a Fix broken error interface in Article creation API (#4458) 2019-10-16 09:02:26 -04:00
Anna Anks Nowak
ee8ae66e47 Add views count for authenticated users articles [#4250] (#4393)
* Add views count for authenticated users articles [#4250]

* Bump API version to 0.5.6 [#4250]
2019-10-15 21:39:17 -04:00
Akshay Arora
9b5f57db0e Fixed Leave organization not working (#4387) (#4420)
* Fixed Leave organization not working

* Added named route for users_leave_org
2019-10-15 18:04:16 -04:00
Gabe Dunn
1c1a2e44fb update muteUnmute to use ternaries instead of if/else to avoid duplicated code (#4442) 2019-10-15 17:12:27 -04:00
Bolarinwa Balogun
a6b51888c5 Improve error message in Api::V0:ArticlesController#create (#4417) 2019-10-15 16:49:26 -04:00
Karin Hendrikse
0ff237cf20 Add specs for errors, mainimage, and notice (#4453) [ci skip] 2019-10-15 16:46:25 -04:00
Enrico Grillo
c9c86a44ea [DOC] Update technical-overview.md (#4439) [ci skip] 2019-10-15 16:34:25 -04:00
Araslanov Evgeny
7de692156c Add ChatChannels::IndexingJob (#4317) [ci skip] 2019-10-15 16:13:10 -04:00
Emilia Muresan
daff71321f Fix lints in app/javascript/src/components/ (#4261) [ci skip] 2019-10-15 16:11:18 -04:00
dependabot-preview[bot]
6c579de6a1 Bump puma from 4.2.0 to 4.2.1 (#4426)
Bumps [puma](https://github.com/puma/puma) from 4.2.0 to 4.2.1.
- [Release notes](https://github.com/puma/puma/releases)
- [Changelog](https://github.com/puma/puma/blob/master/History.md)
- [Commits](https://github.com/puma/puma/compare/v4.2.0...v4.2.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-10-15 15:59:39 -04:00
dependabot-preview[bot]
f593787c04 Bump faker from 2.5.0 to 2.6.0 (#4422) [ci skip]
Bumps [faker](https://github.com/faker-ruby/faker) from 2.5.0 to 2.6.0.
- [Release notes](https://github.com/faker-ruby/faker/releases)
- [Changelog](https://github.com/faker-ruby/faker/blob/master/CHANGELOG.md)
- [Commits](https://github.com/faker-ruby/faker/compare/v2.5.0...v2.6.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-10-15 15:59:09 -04:00
dependabot-preview[bot]
005ce8f740 Bump jsdom from 15.1.1 to 15.2.0 (#4432) [ci skip]
Bumps [jsdom](https://github.com/jsdom/jsdom) from 15.1.1 to 15.2.0.
- [Release notes](https://github.com/jsdom/jsdom/releases)
- [Changelog](https://github.com/jsdom/jsdom/blob/master/Changelog.md)
- [Commits](https://github.com/jsdom/jsdom/compare/15.1.1...15.2.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-10-15 15:50:44 -04:00
dependabot-preview[bot]
7d5d8a1e72 Bump @github/clipboard-copy-element from 1.0.6 to 1.0.7 (#4429) [ci skip]
Bumps [@github/clipboard-copy-element](https://github.com/github/clipboard-copy-element) from 1.0.6 to 1.0.7.
- [Release notes](https://github.com/github/clipboard-copy-element/releases)
- [Commits](https://github.com/github/clipboard-copy-element/compare/v1.0.6...v1.0.7)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-10-15 15:46:11 -04:00
dependabot-preview[bot]
779f3fc486 Bump airbrake from 9.4.4 to 9.4.5 (#4425) [ci skip]
Bumps [airbrake](https://github.com/airbrake/airbrake) from 9.4.4 to 9.4.5.
- [Release notes](https://github.com/airbrake/airbrake/releases)
- [Changelog](https://github.com/airbrake/airbrake/blob/master/CHANGELOG.md)
- [Commits](https://github.com/airbrake/airbrake/compare/v9.4.4...v9.4.5)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-10-15 15:42:17 -04:00
dependabot-preview[bot]
efac5e1953 Bump recaptcha from 5.1.1 to 5.2.1 (#4424) [ci skip]
Bumps [recaptcha](https://github.com/ambethia/recaptcha) from 5.1.1 to 5.2.1.
- [Release notes](https://github.com/ambethia/recaptcha/releases)
- [Changelog](https://github.com/ambethia/recaptcha/blob/master/CHANGELOG.md)
- [Commits](https://github.com/ambethia/recaptcha/compare/v5.1.1...v5.2.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-10-15 15:01:44 -04:00
dependabot-preview[bot]
315e2ca4ec Bump rubocop-rspec from 1.35.0 to 1.36.0 (#4428) [ci skip]
Bumps [rubocop-rspec](https://github.com/rubocop-hq/rubocop-rspec) from 1.35.0 to 1.36.0.
- [Release notes](https://github.com/rubocop-hq/rubocop-rspec/releases)
- [Changelog](https://github.com/rubocop-hq/rubocop-rspec/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop-hq/rubocop-rspec/compare/v1.35.0...v1.36.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-10-15 14:59:34 -04:00
dependabot-preview[bot]
c8cea69298 Bump rspec-rails from 3.8.2 to 3.9.0 (#4423) [ci skip]
Bumps [rspec-rails](https://github.com/rspec/rspec-rails) from 3.8.2 to 3.9.0.
- [Release notes](https://github.com/rspec/rspec-rails/releases)
- [Changelog](https://github.com/rspec/rspec-rails/blob/master/Changelog.md)
- [Commits](https://github.com/rspec/rspec-rails/compare/v3.8.2...v3.9.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-10-15 14:29:46 -04:00
rhymes
360d5be17d Change branching naming scheme for PRs (#4447) [ci skip] 2019-10-15 14:29:04 -04:00
Jacob Herrington
7152f07867 Remove unused import and unused props (#4452) 2019-10-15 14:12:40 -04:00
dependabot-preview[bot]
f247bd7711 Bump derailed_benchmarks from 1.4.0 to 1.4.1 (#4427)
Bumps [derailed_benchmarks](https://github.com/schneems/derailed_benchmarks) from 1.4.0 to 1.4.1.
- [Release notes](https://github.com/schneems/derailed_benchmarks/releases)
- [Changelog](https://github.com/schneems/derailed_benchmarks/blob/master/CHANGELOG.md)
- [Commits](https://github.com/schneems/derailed_benchmarks/compare/v1.4.0...v1.4.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-10-15 11:31:58 -04:00
Dmitrii Pashutskii
ea4d1fee63 remove a space and refactor conditions (#4437)
* remove a space and refactor conditions

* fix the condition to present check
2019-10-15 11:24:19 -04:00
dependabot-preview[bot]
436499135a Bump lint-staged from 9.4.1 to 9.4.2 (#4431)
Bumps [lint-staged](https://github.com/okonet/lint-staged) from 9.4.1 to 9.4.2.
- [Release notes](https://github.com/okonet/lint-staged/releases)
- [Commits](https://github.com/okonet/lint-staged/compare/v9.4.1...v9.4.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-10-15 11:13:37 -04:00
dependabot-preview[bot]
7b58bb5734 Bump husky from 3.0.8 to 3.0.9 (#4435)
Bumps [husky](https://github.com/typicode/husky) from 3.0.8 to 3.0.9.
- [Release notes](https://github.com/typicode/husky/releases)
- [Changelog](https://github.com/typicode/husky/blob/master/CHANGELOG.md)
- [Commits](https://github.com/typicode/husky/compare/v3.0.8...v3.0.9)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-10-15 11:03:09 -04:00
Karin Hendrikse
0575648407 Fix lints for sidebarwidget and sidebaruser (#4418) [ci skip] 2019-10-14 14:43:26 -04:00
Hoang Vo
293ba5231b Fix eslint issues in app/javascript/listings (#4253)
* Fix some eslint and a11y issues

* Add a11y fixed to snapshot

* Fix missing whitespace that cause test fail

* Fix code duplicate

* Config eslint to allows the label as a sibling

* Use 'error' instead of 2 in eslintrc

* Correct propTypes in SingleListing

* Add missing id prop for select

* Add space between two functions

* onKeyPress only register Enter

* Allow space key also to activate action

* Use a common function for three event handlers
2019-10-14 14:23:20 -04:00
Dmitrii Pashutskii
ab17afc247 Fix display style and extra spaces in internal's articles (#4364) [ci skip]
Change display to flex and adjust code to remove the extra characters
2019-10-14 13:55:32 -04:00
José Chaves Neto
3161ab3214 Fix 'use strict' lints (#4414) [ci skip] 2019-10-14 13:46:15 -04:00