Daniel Uber
0969e8edb4
Remove assert order not called instead of expecting id order ( #13544 )
...
We can't rely on the database returning published articles in ID
order, since there are indexes on published_at and on published which
could very well be in any order (btree), and no explicit `ORDER BY id
ASC` was in the query.
I checked the query that's run in the test against blazer, and confirmed that under
real conditions the results are pretty far from ordered:
```
SELECT articles.id FROM articles WHERE (published_at <= '2021-04-27') AND articles.published = true LIMIT 10 OFFSET 0;
----
id
166916
637099
132444
431420
501939
141182
565391
515964
146231
677241
```
Change the expectation to assert Article does not receive :order, and
remove the expectation that the ids are returned in the order created.
2021-04-27 13:15:56 -05:00
dependabot[bot]
6813afd610
Bump @storybook/preact from 6.2.8 to 6.2.9 ( #13539 )
...
Bumps [@storybook/preact](https://github.com/storybookjs/storybook/tree/HEAD/app/preact ) from 6.2.8 to 6.2.9.
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v6.2.9/app/preact )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-04-27 11:35:27 -06:00
Alex
315dca98c9
[Search 2.0] Podcasts on search page ( #13475 )
...
* Working MVP
* Add specs
* Add partial index on podcasts.published
* Add tsvector indexes to podcast_episodes
* Filter for reachable PodcastEpisodes
* Fix indentation/formatting
* Add podcast attribute to serializer
2021-04-27 13:29:22 -04:00
rhymes
2ff317687e
[Search 2.0] Articles ( #13540 )
...
* Rename the search scope to reflect its generic usage
* Add and use Search::Postgres::Article
2021-04-27 18:59:01 +02:00
dependabot[bot]
62e150f5af
Bump eslint-config-preact from 1.1.3 to 1.1.4 ( #13516 )
...
* Bump eslint-config-preact from 1.1.3 to 1.1.4
Bumps [eslint-config-preact](https://github.com/preactjs/eslint-config-preact ) from 1.1.3 to 1.1.4.
- [Release notes](https://github.com/preactjs/eslint-config-preact/releases )
- [Commits](https://github.com/preactjs/eslint-config-preact/compare/v1.1.3...v1.1.4 )
Signed-off-by: dependabot[bot] <support@github.com>
* Add missing key prop for elements in iterators where necessary
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>
2021-04-27 18:54:43 +02:00
dependabot[bot]
5881f36a04
Bump @testing-library/dom from 7.30.3 to 7.30.4 ( #13538 )
...
Bumps [@testing-library/dom](https://github.com/testing-library/dom-testing-library ) from 7.30.3 to 7.30.4.
- [Release notes](https://github.com/testing-library/dom-testing-library/releases )
- [Changelog](https://github.com/testing-library/dom-testing-library/blob/master/CHANGELOG.md )
- [Commits](https://github.com/testing-library/dom-testing-library/compare/v7.30.3...v7.30.4 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-04-27 18:53:59 +02:00
Jamie Gaskins
b167fb7fb1
Optimize GetUserStickies ( #13541 )
2021-04-27 12:47:49 -04:00
dependabot[bot]
a79b211d4f
Bump sidekiq-unique-jobs from 7.0.8 to 7.0.9 ( #13531 )
...
Bumps [sidekiq-unique-jobs](https://github.com/mhenrixon/sidekiq-unique-jobs ) from 7.0.8 to 7.0.9.
- [Release notes](https://github.com/mhenrixon/sidekiq-unique-jobs/releases )
- [Changelog](https://github.com/mhenrixon/sidekiq-unique-jobs/blob/master/CHANGELOG.md )
- [Commits](https://github.com/mhenrixon/sidekiq-unique-jobs/compare/v7.0.8...v7.0.9 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-04-27 10:55:08 -05:00
dependabot[bot]
7192477d11
Bump @testing-library/jest-dom from 5.11.10 to 5.12.0 ( #13534 )
...
Bumps [@testing-library/jest-dom](https://github.com/testing-library/jest-dom ) from 5.11.10 to 5.12.0.
- [Release notes](https://github.com/testing-library/jest-dom/releases )
- [Changelog](https://github.com/testing-library/jest-dom/blob/main/CHANGELOG.md )
- [Commits](https://github.com/testing-library/jest-dom/compare/v5.11.10...v5.12.0 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-04-27 09:39:41 -05:00
rhymes
4ca995e1a1
Serialize tag flares correctly in Homepage::ArticleSerializer ( #13537 )
2021-04-27 16:07:05 +02:00
dependabot[bot]
2fa501d171
Bump @storybook/addon-links from 6.2.8 to 6.2.9 ( #13533 )
...
Bumps [@storybook/addon-links](https://github.com/storybookjs/storybook/tree/HEAD/addons/links ) from 6.2.8 to 6.2.9.
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v6.2.9/addons/links )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-04-27 10:05:39 -04:00
dependabot[bot]
34152bf804
Bump octokit from 4.20.0 to 4.21.0 ( #13532 )
...
Bumps [octokit](https://github.com/octokit/octokit.rb ) from 4.20.0 to 4.21.0.
- [Release notes](https://github.com/octokit/octokit.rb/releases )
- [Changelog](https://github.com/octokit/octokit.rb/blob/4-stable/RELEASE.md )
- [Commits](https://github.com/octokit/octokit.rb/compare/v4.20.0...v4.21.0 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-04-27 07:58:41 -06:00
Andy Zhao
dc30eadad8
Remove unused attributes from markdown parser ( #13484 )
...
* Remove definitely unused attributes
* Refactor and remove unused attributes
* Add parentheses
* Prevent alt tag from having Liquid tags inside
* Add test
* Remove more unused attributes
* Scrub any valid attributes
* Remove unused tags and add more tests
* Remove <i> tag; <em> is used by parser
* Remove <center> b/c it's deprecated though still valid
* <cite> is a safe tag and used by some
* Eh I changed my mind about center lol
* Add underline <u> back in
* Don't allow width changes
* Use frozen constant for regex
* Use #remove over #gsub
2021-04-27 09:33:01 -04:00
Daniel Uber
2478bf7ec7
Enable redis cache store in development ( #13526 )
...
* Always setup redis cache store in development
We need this for argument passing for the podcast episode create
worker after 9973b7361e8936ecd95c938746093524ad56ff63
Do still disable action controller caching by default, but permit
Rails.cache.write and Rails.cache.read to do the expected things
between sidekiq processes.
2021-04-27 08:30:50 -05:00
Suzanne Aitchison
7c7a0992b7
Reintroduce autocomplete Cypress test, refactor tests in same suite ( #13506 )
...
* reintroduce test, refactor tests
* make sure we always wait for comment box substitution before continuing
2021-04-27 12:01:51 +01:00
Suzanne Aitchison
6f4382719e
add skip link to connect and manage post ( #13503 )
2021-04-27 10:01:24 +01:00
dependabot[bot]
ecc664814e
Bump @storybook/addon-knobs from 6.2.8 to 6.2.9 ( #13523 )
...
Bumps [@storybook/addon-knobs](https://github.com/storybookjs/storybook/tree/HEAD/addons/knobs ) from 6.2.8 to 6.2.9.
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v6.2.9/addons/knobs )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-04-27 08:57:35 +02:00
dependabot[bot]
8f8c870747
Bump eslint-config-prettier from 8.2.0 to 8.3.0 ( #13527 )
...
Bumps [eslint-config-prettier](https://github.com/prettier/eslint-config-prettier ) from 8.2.0 to 8.3.0.
- [Release notes](https://github.com/prettier/eslint-config-prettier/releases )
- [Changelog](https://github.com/prettier/eslint-config-prettier/blob/main/CHANGELOG.md )
- [Commits](https://github.com/prettier/eslint-config-prettier/compare/v8.2.0...v8.3.0 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-04-27 08:55:59 +02:00
rhymes
8a55c3e888
[Search 2.0] Add query filters for profile, organization and tag index pages ( #13510 )
...
* Re-order test cases to increase tests readability
* Add user_id filter for articles query
* Add organization_id and tags filters
* Add new params to SearchController#feed_content
* Add current_user param so that it can be tested for a small pool of users
2021-04-27 08:49:47 +02:00
dependabot[bot]
333c41a962
Bump css-loader from 5.2.2 to 5.2.4 ( #13529 )
...
Bumps [css-loader](https://github.com/webpack-contrib/css-loader ) from 5.2.2 to 5.2.4.
- [Release notes](https://github.com/webpack-contrib/css-loader/releases )
- [Changelog](https://github.com/webpack-contrib/css-loader/blob/master/CHANGELOG.md )
- [Commits](https://github.com/webpack-contrib/css-loader/compare/v5.2.2...v5.2.4 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-04-26 21:00:52 -05:00
dependabot[bot]
8b2db7def3
Bump @storybook/addon-docs from 6.2.8 to 6.2.9 ( #13524 )
...
Bumps [@storybook/addon-docs](https://github.com/storybookjs/storybook/tree/HEAD/addons/docs ) from 6.2.8 to 6.2.9.
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v6.2.9/addons/docs )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-04-26 15:53:29 -06:00
dependabot[bot]
a288ed096a
Bump chart.js from 3.1.1 to 3.2.0 ( #13525 )
...
Bumps [chart.js](https://github.com/chartjs/Chart.js ) from 3.1.1 to 3.2.0.
- [Release notes](https://github.com/chartjs/Chart.js/releases )
- [Commits](https://github.com/chartjs/Chart.js/compare/v3.1.1...v3.2.0 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-04-26 15:36:37 -06:00
dependabot[bot]
e0b863afe0
Bump sass from 1.32.10 to 1.32.11 ( #13520 )
...
Bumps [sass](https://github.com/sass/dart-sass ) from 1.32.10 to 1.32.11.
- [Release notes](https://github.com/sass/dart-sass/releases )
- [Changelog](https://github.com/sass/dart-sass/blob/master/CHANGELOG.md )
- [Commits](https://github.com/sass/dart-sass/compare/1.32.10...1.32.11 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-04-26 14:50:46 -06:00
dependabot[bot]
f35b4592de
Bump jest-watch-typeahead from 0.6.2 to 0.6.3 ( #13521 )
...
Bumps [jest-watch-typeahead](https://github.com/jest-community/jest-watch-typeahead ) from 0.6.2 to 0.6.3.
- [Release notes](https://github.com/jest-community/jest-watch-typeahead/releases )
- [Changelog](https://github.com/jest-community/jest-watch-typeahead/blob/master/CHANGELOG.md )
- [Commits](https://github.com/jest-community/jest-watch-typeahead/compare/v0.6.2...v0.6.3 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-04-26 14:31:29 -06:00
dependabot[bot]
3d30950916
Bump focus-trap from 6.3.0 to 6.4.0 ( #13517 )
...
Bumps [focus-trap](https://github.com/focus-trap/focus-trap ) from 6.3.0 to 6.4.0.
- [Release notes](https://github.com/focus-trap/focus-trap/releases )
- [Changelog](https://github.com/focus-trap/focus-trap/blob/master/CHANGELOG.md )
- [Commits](https://github.com/focus-trap/focus-trap/compare/v6.3.0...v6.4.0 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-04-26 13:58:28 -06:00
dependabot[bot]
4a1d4f71d9
Bump eslint from 7.24.0 to 7.25.0 ( #13512 )
...
Bumps [eslint](https://github.com/eslint/eslint ) from 7.24.0 to 7.25.0.
- [Release notes](https://github.com/eslint/eslint/releases )
- [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md )
- [Commits](https://github.com/eslint/eslint/compare/v7.24.0...v7.25.0 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-04-26 20:00:14 +02:00
dependabot[bot]
c1ded1f720
Bump @storybook/addon-actions from 6.2.8 to 6.2.9 ( #13518 )
...
Bumps [@storybook/addon-actions](https://github.com/storybookjs/storybook/tree/HEAD/addons/actions ) from 6.2.8 to 6.2.9.
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v6.2.9/addons/actions )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-04-26 19:59:11 +02:00
Ridhwana
9db98d3031
chore: change aria:true to aria: hidden ( #13515 )
2021-04-26 19:30:04 +02:00
Nick Taylor
d5f3894901
Set husky explicilty to version 4.x. ( #13514 )
2021-04-26 13:26:12 -04:00
dependabot[bot]
cb3b131a16
Bump @storybook/addon-storysource from 6.2.8 to 6.2.9 ( #13511 )
...
Bumps [@storybook/addon-storysource](https://github.com/storybookjs/storybook/tree/HEAD/addons/storysource ) from 6.2.8 to 6.2.9.
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v6.2.9/addons/storysource )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-04-26 18:48:14 +02:00
dependabot[bot]
f639dbf6bf
Bump core-js from 3.10.1 to 3.11.0 ( #13497 )
...
Bumps [core-js](https://github.com/zloirock/core-js/tree/HEAD/packages/core-js ) from 3.10.1 to 3.11.0.
- [Release notes](https://github.com/zloirock/core-js/releases )
- [Changelog](https://github.com/zloirock/core-js/blob/master/CHANGELOG.md )
- [Commits](https://github.com/zloirock/core-js/commits/v3.11.0/packages/core-js )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-04-26 18:47:49 +02:00
rhymes
23c661bb0a
Cleanup markup of editor guide ( #13491 )
...
* Improve HTML markup
* Implement some a11y changes
* Update app/views/pages/_v1_editor_guide_preamble.html.erb
Co-authored-by: Nick Taylor <nick@forem.com>
Co-authored-by: Nick Taylor <nick@forem.com>
2021-04-26 18:44:18 +02:00
Christian D
842a1cb9de
13230 Fix textarea out of bounds on resize ( #13508 )
2021-04-26 18:39:56 +02:00
rhymes
0ec03063fd
Fix search with quotes in users's names ( #13493 )
2021-04-26 17:57:00 +02:00
Ridhwana
c5bcb4c021
RFC 50: fix some more hardcoded paths ( #13473 )
...
* fix: remove hardcoded paths
* fix: use path helpers
* swap href for link_to
* feat: use path helpers
* feat: use a data path to send through the path that we will be calling
* feat: pass route through to js
* dus index path
* chore: change to use path_helpers
* feat: update DUS controller
* chore: oops remove these paths
2021-04-26 17:49:54 +02:00
dependabot[bot]
8a7179167c
Bump ibm-openapi-validator from 0.42.0 to 0.43.0 ( #13502 )
...
Bumps [ibm-openapi-validator](https://github.com/IBM/openapi-validator ) from 0.42.0 to 0.43.0.
- [Release notes](https://github.com/IBM/openapi-validator/releases )
- [Changelog](https://github.com/IBM/openapi-validator/blob/main/CHANGELOG.md )
- [Commits](https://github.com/IBM/openapi-validator/compare/v0.42.0...v0.43.0 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-04-26 17:27:26 +02:00
dependabot[bot]
9d68ff308e
Bump postcss from 8.2.10 to 8.2.13 ( #13504 )
2021-04-26 11:25:56 -04:00
dependabot[bot]
53aa897331
Bump katex from 0.6.1 to 0.8.0 ( #13500 )
...
Bumps [katex](https://github.com/glebm/katex-ruby ) from 0.6.1 to 0.8.0.
- [Release notes](https://github.com/glebm/katex-ruby/releases )
- [Changelog](https://github.com/glebm/katex-ruby/blob/master/CHANGES.md )
- [Commits](https://github.com/glebm/katex-ruby/compare/v0.6.1...v0.8.0 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-04-26 09:06:12 -06:00
dependabot[bot]
3c9454db1a
Bump rolify from 5.3.0 to 6.0.0 ( #13499 )
...
Bumps [rolify](https://github.com/RolifyCommunity/rolify ) from 5.3.0 to 6.0.0.
- [Release notes](https://github.com/RolifyCommunity/rolify/releases )
- [Changelog](https://github.com/RolifyCommunity/rolify/blob/master/CHANGELOG.rdoc )
- [Commits](https://github.com/RolifyCommunity/rolify/compare/v5.3.0...v6.0.0 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-04-26 10:12:19 -04:00
dependabot[bot]
e6c618370d
Bump @storybook/addon-a11y from 6.2.8 to 6.2.9 ( #13496 )
...
Bumps [@storybook/addon-a11y](https://github.com/storybookjs/storybook/tree/HEAD/addons/a11y ) from 6.2.8 to 6.2.9.
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v6.2.9/addons/a11y )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-04-26 06:26:22 -06:00
Michael Kohl
610f6151e6
Split Settings::Community from SiteConfig ( #13403 )
...
* Add settings_community_contents model
* Add settings_communities model
* Update usage
* Add controller and update code
* Add e2e test
* Add data update script
* Update schema.rb
* Fix specs
* PR feedback
* Remove experience_* from Settings::Community
* Update spec
* Fix spec
2021-04-26 10:46:35 +02:00
dependabot[bot]
6c7df12198
Bump @testing-library/user-event from 13.1.4 to 13.1.5 ( #13498 )
...
Bumps [@testing-library/user-event](https://github.com/testing-library/user-event ) from 13.1.4 to 13.1.5.
- [Release notes](https://github.com/testing-library/user-event/releases )
- [Changelog](https://github.com/testing-library/user-event/blob/master/CHANGELOG.md )
- [Commits](https://github.com/testing-library/user-event/compare/v13.1.4...v13.1.5 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-04-26 09:36:08 +02:00
Michael Kohl
f2f5e911cf
Add Settings::Mascot ( #13451 )
...
* Add Settings::Mascot
* Add DUS
* Update usage
* Fix e2e test and controller
* Fix specs
* Fix remaining spec
2021-04-26 11:39:19 +07:00
Michael Kohl
62542a35ab
15 minute fix: Remove /partnerships page ✂️ ( #13480 )
...
* Remove partnerships
* Remove dead link
2021-04-26 08:44:53 +07:00
Molly Struve
73973d3941
Refactor:Remove jobs_url and Dispaly Banner ( #13479 )
2021-04-25 12:59:54 -05:00
rhymes
996f6e980f
[Search 2.0] Users ( #13453 )
...
* Add Search::Postgres::User
* Add sorting params
* Use a better algorithm to filter out suspended users
* Add tsvector index on users.name
* Add specs
* Add UserRole spec
* Update spec/services/search/postgres/user_spec.rb
Co-authored-by: Michael Kohl <citizen428@dev.to>
* Fix search with quotes in users's names
Co-authored-by: Michael Kohl <citizen428@dev.to>
2021-04-24 19:06:06 +02:00
rhymes
3292f27d53
Homepage query should not fail for nil article's cached tag list ( #13492 )
2021-04-24 18:36:34 +02:00
Fernando Valverde
affc704c9b
Runtime Banner for Mobile Deep Linking ( #13190 )
...
* First version using custom schemes for iOS
* Starting to take shape with /r/mobile redirect page
* Wording and aasa
* Adds e2e tests
* Trigger CI
* Tweaks to AASA
* Uses external pivot domain to trigger Universal Links
* Add missing external domain deep link
* Fix test by enabling runtime_banner only in E2E tests
* Fix URL encoding mismatch in Cypress test
* banner sttyling
* Cleanup unrelated changes
* Add AASA tests + remove lingering Gemfile.lock changes
* Fix cypress test
* Remove unnecessary window global assignment
* Trigger Travis
* Replace querySelectorAll with querySelector
* Apply suggestions from code review
Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>
* Refactor inline comments, extract URL.deep_link logic and other review feedback
* Small tweaks
* Remove untrusted user-provided redirect (CodeQL suggestion)
* Fix failing tests
* Whoops - another test fix
* Use Forem's UDL server
* Extract timeoutDelay and add comment clarifying
* Add target='_blank' to deep link
* Add TODO comment for replacing hardcoded identifiers
* Apply suggestions from code review
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Add a11y attributes
Co-authored-by: Paweł Ludwiczak <ludwiczakpawel@gmail.com>
Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
2021-04-23 15:45:34 -06:00
Alex
f233be805b
Preload users instead of querying separately when searching for comments ( #13490 )
...
* Preload users instead of querying separately
* Add conditional to comment.user
2021-04-23 16:30:06 -04:00
Jacob Herrington
2f703e97f3
Fix bug when responding to listings ( #13366 )
...
* Fix bug when responding to listings
Sending a message to a listing author works about half the time. I
can't determine exactly what user behavior causes it to fail or succeed,
but after making this change it doesn't fail anymore. Looking at the
code, I'm not sure how it ever works...
* Notify Honeybadger when listing responses fail
* Add E2E test for contacting through listings
* Update e2e test
2021-04-23 13:55:33 -05:00
