Anna Buianova
dcfa6d29b8
Fix Rubocop lints ( #5155 )
2019-12-19 10:09:37 -05:00
Andy Zhao
71157c993e
Hide comment feature ( #4944 )
...
* Add MVP of hide comment feature
* Slight copy adjustments
* Remove unused file oops
* Fix strange styling issues
* Add hide/unhide comment specs
* Authenticate user for hide/unhide
* Add tests for hide/unhide functionality
* Remove opacity CSS for hidden comments
* Fix hidden comment explanation logic
* Fix some styling issues
* Fix hiding top level comment logic
* Show only hidden comments in permalink and not thread
* Hide subtree properly if hidden comment
* Fix weird CSS issue
* Properly hide comments for permalink view
* Show children comments in permalink view
* Add tests for comment hiding visibility
* Remove superfluous code and adjust copy
* Remove some more logical duplication
* Add dedicated article column for any comments hidden
* Add reload in test
2019-12-10 15:09:47 -05:00
rhymes
62edf443f3
Add FKs to notifications_subscriptions, page_views and users_roles ( #4999 ) [deploy]
2019-12-04 10:14:57 -06:00
Mac Siri
64f70fff8f
Use build_stubbed in Policy specs ( #4017 ) [ci skip]
2019-09-13 11:38:58 -04:00
rhymes
9d2c89fd2f
Upgrade factory_bot_rails to 5.2.0 ( #2532 ) [ci skip]
2019-04-23 13:21:22 -04:00
Andy Zhao
c4677071a7
Mute notifications for a comment thread ( #1636 )
...
* Use idempotent update instead of toggle
* Update editor guide with new comment instructions
* Render the settings button on page load
* Add settings button to comment dropdown
* Update styles to properly render
* Add comment mute function and settings page
* Clean up erb spacing
* Remove unneccessary user_id param
* Add receive_notifications for policy spec
* Update name for accuracy
* Add request spec for comments_mute
* Remove unused permitted attributes
* Add actually used permitted attributes
2019-01-24 17:20:38 -05:00
rhymes
6553f08d94
Rubocop cleanups ( #1415 )
...
* Update rubocop-todo.yml with new violations
* Fix Layout/EmptyLine* rules
* Fix Layout/Indentation* rules
* Fix remaining Layout/* rules
* Fix Lint/DuplicateMethods by removing unused accessor
* Fix Lint/IneffectiveAccessModifier
* Fix Lint/MissingCopEnableDirective
* Re-run rubocop auto gen config
* Fix Layout/RescueEnsureAlignment
* Fix Naming/* rules
* Fix some RSpec/* rules
* Fix typos
* Fix RSpec/LetBeforeExamples
* Series should only be an attr_writer, not an attr_accessor
* Fix RSpec/InstanceVariable
* Fix RSpec/InstanceVariable
* Fix RSpec/RepeatedDescription and RSpec/RepeatedExample
* Fix Style/ClassAndModuleChildren
* Fix Style/ConditionalAssignment
* Fix some Style/* rules
* Trigger Travis CI build because failing tests are not failing locally
* Revert "Fix Style/ClassAndModuleChildren"
This reverts commit 1686801d8a1516ba1894f79e24401a20dea65f99.
2019-01-02 11:20:02 -05:00
Andy Zhao
c888fd6faa
Add ability to prevent comment creation ( #554 )
2018-08-31 12:11:21 -04:00
rhymes
e588fa7ece
Code cleanups ( #659 )
...
* Initial automatic cleanup with rubocop
* Fix syntax error introduced by rubocop
* Cleanup seeds file
* Cleanup lib folder
* Exclude bin folder because it contains auto generated files
* Make Rubocop a little bit more chatty
* Block length should not include comments in the count
* Cleanup config folder
* Cleanup specs
* Updated Rubocop version and generated a todo file
* Fix broken ArticlesApi spec
* Fix tests
* Restored rubocop pre-commit hook
2018-08-07 11:00:13 -04:00
Andy Zhao
0785720908
Add comment policy and specs ( #475 )
...
* Fix edge case with apostrophes
* Add comment policy and specs
* Add login for deleting comment spec
* Change test to raise pundit error instead of 404
* Clean up comment destroy request specs
* Remove redundant raise
2018-06-21 17:20:34 -04:00
