Commit graph

4448 commits

Author SHA1 Message Date
Michael Kohl
02f86fedd7
Allow admins to delete users without emails (#6530) [deploy]
* Allow admins to delete users without emails

* Guard against blank email addresses
2020-03-10 22:20:36 +01:00
Abenet Tamiru
83a59063fc
Set user, password and db for postgres docker (#6564)
* Set user, password and db for postgres docker

* Sync other docker services with dockerfile DATABASE_URL
2020-03-10 14:44:26 -04:00
Michael Kohl
1cdbeea0a8
Add .slugignore (#6528) 2020-03-10 14:43:48 -04:00
Ben Halpern
8bcf95b3ec
Disallow /mod/ in robots.txt (#6562) [deploy] 2020-03-10 14:24:33 -04:00
Anna Buianova
e9f0891577
Improved the podcasts seeds (#6565) 2020-03-10 14:23:48 -04:00
Ben Halpern
923afed4e4
Move math around parenthases in score_experience_level (#6569) [deploy]
* Move math around parenthases in score_experience_level

* Clean up tests

* Remove flash notice from comments form
2020-03-10 14:14:08 -04:00
Faruk Talha Özbek
9c3868a33e
fixed some eslint errors (#6521)
* fixed some eslint errors

* changed async/await  to then/catch

* Added Honeybadger inside the catch block

* removed Honeybadger import and addes eslint global rule
2020-03-10 18:49:57 +01:00
Ben Halpern
77f0581673
Remove flash notice to avoid cache leak (#6570) [deploy] 2020-03-10 13:22:46 -04:00
Liz Fong-Jones
239edd5204
use beeline 2.0 (#6568) [deploy] 2020-03-10 12:35:15 -04:00
Vaidehi Joshi
502bef156e
Allow an article's main_image to be removed (#5687) [deploy]
Currently, we don't allow users to remove the `main_image` of an article once it has been set. It can be changed, but never removed.
This change allows the `main_image` to be removed by checking for the `cover_image` key in the frontmatter that is sent along in the article's markdown. This means that a user should be able to remove the image associated with an article by removing the value of `cover_image:` from their frontmatter.
2020-03-10 08:29:59 -07:00
Ben Halpern
0817e2ac9e
Create implicit experience level rating vote upon creating of readinglist reaction (#6522) [deploy]
* Do not render or link to empty rss feeds

* s

* Move calculation to worker

* remove xit test

* Also allow implicit rating votes in comments

* Fix alignment issue

* Remove comment logic
2020-03-10 10:59:49 -04:00
rhymes
235367e073
Make bin/setup predictable and repeatable and remove bin/update (#6566)
* Make bin/setup predictable and remove bin/update

* System not puts

* Give priority to ENV DATABASE_URL
2020-03-10 15:46:23 +01:00
Michael Kohl
8ab7a3fb6c
API: Remove reactions onboarding (#6529)
* Move reactions onboarding to internal API

* Don't add reactions onboarding to internal API

* Remove obsolete worker
2020-03-10 10:25:16 -04:00
Mac Siri
80088c51ab
Skip /welcome in serviceworkers (#6561) [deploy] 2020-03-10 09:27:04 +01:00
Vaidehi Joshi
70036ebc43
Allow preview image URL form to be visible for articles with videos (#6560) [deploy]
This fixes #6311!
2020-03-09 19:24:35 -07:00
Molly Struve
5ec96613df
dont delete chat channel memberships multiple times (#6556) 2020-03-09 20:04:40 -04:00
Mac Siri
8e4905522d
Implement KatexTag (#6237) [deploy]
* Install Katex gem

* Add Katex stylesheet and spec

* Implement basic error handling

* Remove comment

* Create more spec

* Update approval file

Changes is due to turning off RedCarpet's superscript feature

* Add instruction to _editor_guide_text

* Serve our own KaTeX css

* Apply Rhyme's suggestion

* Limit Katex's css use

* Update spec

* Add spec

Co-authored-by: Ben Halpern <bendhalpern@gmail.com>
2020-03-09 17:58:54 -04:00
Juan Vasquez
d461d83540
Fixed listings/dashboard/rowElements/location.jsx eslint error (#6491)
* Fixed listings/dashboard/rowElements/location.jsx eslint error

* Update app/javascript/listings/dashboard/rowElements/location.jsx

Co-Authored-By: Nick Taylor <nick@iamdeveloper.com>

Co-authored-by: Nick Taylor <nick@iamdeveloper.com>
2020-03-09 17:39:22 -04:00
Vaidehi Joshi
a66dc2693a
Refactor debounce usage into debounceAction util (#6506)
* Refactor debounce usage into debounceAction util

* Allow debounceAction's config to be merged, allow for named arguments

Also clean up the documentation as necessary!
2020-03-09 17:38:39 -04:00
dependabot-preview[bot]
ab2670625e
Bump jest-fetch-mock from 3.0.1 to 3.0.2 (#6535) 2020-03-09 17:31:07 -04:00
Ben Halpern
8157196fd3
Rename one more method (#6558) [deploy] 2020-03-09 17:01:47 -04:00
Molly Struve
7df5e6cfae
Rename feed method to correct name (#6557)
* rename method to correct name

* fix spec
2020-03-09 16:59:38 -04:00
dependabot-preview[bot]
776e0e7a07
Bump eslint-plugin-react from 7.18.3 to 7.19.0 (#6536)
Bumps [eslint-plugin-react](https://github.com/yannickcr/eslint-plugin-react) from 7.18.3 to 7.19.0.
- [Release notes](https://github.com/yannickcr/eslint-plugin-react/releases)
- [Changelog](https://github.com/yannickcr/eslint-plugin-react/blob/master/CHANGELOG.md)
- [Commits](https://github.com/yannickcr/eslint-plugin-react/compare/v7.18.3...v7.19.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-03-09 16:46:36 -04:00
Ben Halpern
5bd042e7d6
Prune old field tests for ongoing tests (#6540) [deploy] 2020-03-09 16:22:42 -04:00
dependabot-preview[bot]
b096b19897
Bump jest-axe from 3.3.0 to 3.4.0 (#6537)
Bumps [jest-axe](https://github.com/nickcolley/jest-axe) from 3.3.0 to 3.4.0.
- [Release notes](https://github.com/nickcolley/jest-axe/releases)
- [Changelog](https://github.com/nickcolley/jest-axe/blob/master/CHANGELOG.md)
- [Commits](https://github.com/nickcolley/jest-axe/compare/v3.3.0...v3.4.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-03-09 15:39:22 -04:00
Josh Puetz
a01d787301
Create comment ranking feed experiment (#6511) [deploy]
* Create more comments feed experiment

* Hook up experiment, rename

* Remove flakey test assertion
2020-03-09 14:20:02 -05:00
Liz Fong-Jones
283afe291e
[honeycomb] make error reporting concise (#6553) [deploy] 2020-03-09 15:01:24 -04:00
Molly Struve
3fa1287c2d
remove hypershield (#6554) [deploy] 2020-03-09 13:41:20 -04:00
Anna Buianova
99cabcbf6b
Removed unused campaign settings (#6532) [deploy] 2020-03-09 12:59:54 -04:00
rhymes
d7717e6eff
Re-enable correct operation of liquid tags with scripts in articles (#6473) [deploy]
* Re-enable correct operation of liquid tags with scripts in articles

* Fix typo
2020-03-09 12:47:13 -04:00
Ben Halpern
1cd38b55fd
Skip /ahoy/ in serviceworkers (#6547) 2020-03-09 12:32:00 -04:00
rhymes
c7503fd0b1
Fix scripts startup check for development mode (#6520)
* Fix scripts startup check for dev mode

* Update doc
2020-03-09 17:15:21 +01:00
Fernando Valverde
0bc7b0ea21
Podcast playback update for iOS app native implementation (#6035) [deploy]
* First experiment with supressing audio playback on native iOS

* Adds load audio message posting

* First version of refactor working on web

* handlePodcastMessages now receives messages sent into JS from native iOS app

* bump back to "v2" local storage key or playback state

* terminatePodcastBar now clears the currentAudioState

* function getMediaState now initializeMedia, fixes audioExistAndIsPlaying for web, better playAudio error management & others

* Fixes bug in playAudio() & clears audioInitialized when no Podcast was initialized

* Codeclimate tweaks

* Reorders functions to comply with codeclimate

* More codeclimate reordering & fixes

* Upgrades the audio bridge messages to JSON instead of strings

* codeclimate doh
2020-03-09 12:09:42 -04:00
Molly Struve
3556950322
store flare tag as a hash in Elasticsearch and add spec for putting json into ES (#6538) 2020-03-09 12:06:31 -04:00
rhymes
4c6b901b7a
Validate API OpenAPI 3 spec (#6519)
* Add @stoplight/spectral to dev dependencies for validation

* Add yarn api-docs:lint command

* Fix linting errors

* Lower severity level

* Add ibm-openapi-validator as linter, as it inspects slightly differently
2020-03-09 16:40:05 +01:00
Molly Struve
b43df4aff7
only activate hypershield in production (#6541) [deploy] 2020-03-09 11:31:51 -04:00
dependabot-preview[bot]
952930eb07
Bump ddtrace from 0.32.0 to 0.33.0 (#6534) [deploy]
Bumps [ddtrace](https://github.com/DataDog/dd-trace-rb) from 0.32.0 to 0.33.0.
- [Release notes](https://github.com/DataDog/dd-trace-rb/releases)
- [Changelog](https://github.com/DataDog/dd-trace-rb/blob/master/CHANGELOG.md)
- [Commits](https://github.com/DataDog/dd-trace-rb/compare/v0.32.0...v0.33.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-03-09 11:12:50 -04:00
dependabot-preview[bot]
ec93710a58
Bump oj from 3.10.3 to 3.10.5 (#6533)
Bumps [oj](https://github.com/ohler55/oj) from 3.10.3 to 3.10.5.
- [Release notes](https://github.com/ohler55/oj/releases)
- [Changelog](https://github.com/ohler55/oj/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/ohler55/oj/compare/v3.10.3...v3.10.5)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-03-09 11:12:24 -04:00
Vaidehi Joshi
99c87d7a17
Replace WELCOMING_USER_ID with mascot_user_id (#6484) [deploy]
Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>
Co-authored-by: Julianna Tetreault <32834804+juliannatetreault@users.noreply.github.com>

Co-authored-by: Julianna Tetreault <32834804+juliannatetreault@users.noreply.github.com>
2020-03-09 08:08:53 -07:00
rhymes
ed66d7b181
Run BackfillColumnForBroadcasts only if the column still exists (#6508) 2020-03-09 15:38:34 +01:00
Alex
20b6c77875
change classified_listings to .destroy_all (#6517) 2020-03-09 09:42:06 -04:00
Ridhwana
813389d36a
Keeping your forked branch up to date (#6531)
* chore: updates to sync your forked ranch

* chore: use rease instead

* feat: update the script to not bomb out if you have added the remote before

* chore: add the comment back
2020-03-09 09:37:46 -04:00
Molly Struve
521cf57e63
Create Hypershield Schema to Shield Sensitive data in Production (#6461) [deploy] 2020-03-09 08:54:31 -04:00
Fernando Valverde
0309bc2e17
Changes type date to string on Create/Update Listings (#6514)
Co-authored-by: rhymes <rhymesete@gmail.com>
2020-03-09 08:34:47 +01:00
rhymes
d73d0c34ab
Add CodeNewbie podcast to seeds (#6527) 2020-03-09 08:34:25 +01:00
Ben Halpern
1f81d1f225
Allow tag mods to approve posts even if they mod just one tag (#6525) [deploy] 2020-03-08 15:42:38 -04:00
Gaute Meek Olsen
e1e75953f7
removes negative margin and adds backgroundcolor to next element instead (#6524)
* removes negative margin and adds backgroundcolor to next element instead

* using box shadow instead of ::before on next element
2020-03-08 16:59:04 +01:00
Michel
7bf4373ef4
Fix 404 page css (#6505)
* Filter page styles with main css class.

* Use class names to select page element.
2020-03-07 09:06:02 +01:00
rhymes
21fca3e0f2
Comments API: hide deleted and hidden comments (plus docs) (#6482) [deploy]
* Modernize index test

* Hide comments body_html and user info if the comment is either deleted or hidden

* Shorten lines a bit

* Freeze repeated strings

* Document all /comments

* Document /comments/{id}
2020-03-07 09:02:10 +01:00
Molly Struve
9000a42de3
convert flare tag to json string before indexing (#6516) [deploy] 2020-03-06 20:27:57 -05:00