Joshua Wehner
bf7a406e2b
Tell Bullet to ignore unused distinct_reaction_categories ( #19332 )
2023-04-17 15:15:24 +02:00
Rajat Talesra
8c3f2c5a36
Fixing eager loading issue in admin/moderation/reports ( #19274 )
...
* Removed reports from eager loading
* Fixed the issue in a bit different way
2023-04-12 18:47:04 +05:30
Ridhwana
c285cf8f9e
Promotional Flair for external Billboard ( #19216 )
...
* Users can only opt-out of external ads
* Move random sampling out of FilteredAdsQuery
* Refactor filtered_ads_query_spec
* Add test for new permit_adjacent setting
* Rubocop
* Use permit_adjacent_sponsors on article sidebar and post-comments
* Remove, unused
* Update copy
* type_matched -> type_of_ads
* Remove non-applicable test
* feat: update the bullet safe list and add eager loading with organizations
* feat: add an indicator round for promoted
* feat: update the css
* feat: add il8n
* fix: styling changes
---------
Co-authored-by: Joshua Wehner <joshua@forem.com>
2023-03-23 18:37:04 +02:00
Aramayis
12e37330c7
Integrate Uffizzi ( #18792 )
...
Co-authored-by: Aramayis <>
2023-01-09 10:49:39 -05:00
Anna Buianova
455399bdba
Rubocop fixes ( #18461 )
...
* Rubocop fixes
* Fixed most Capybara/SpecificMatcher violations
* Moved flash notice texts to locales
2022-09-16 15:25:48 +03:00
Mac Siri
678dda8cf4
Routine Rubopcop lint fixes ( #17844 )
...
* Routine Rubopcop lint fixes
* Undo app_secrets_spec changes
* Fix broken spec
2022-06-07 10:17:16 -04:00
Dwight Scott
71294dca14
OpenGraph fallback for Embeds (merge-by-any-core) ( #17001 )
...
* WIP -- start of OpenGraph class that wraps MetaInspector gem
* use properties method instead of hash
* Update app/services/open_graph.rb
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Update app/services/open_graph.rb
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Update app/services/open_graph.rb
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Update app/services/open_graph.rb
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Update app/services/open_graph.rb
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Update app/services/open_graph.rb
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* address PR feedback
* adding some specs
* gem vendor cache
* more specs
* lock metainspector gem to 5.11
* Update app/services/open_graph.rb
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* WIP -- start of incorporating the open graph into the view
* regex match anything
* Update app/liquid_tags/open_graph_tag.rb
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Refactors and Improvements
* build UI (some wonkiness; see loom)
* UI improvements
* add hyperlink to embed url
* display site_name conditionally
* Make PR review changes; implement A-tag fallback for OG
* Address PR review comments
* Fix failing spec
* deleted superfluous assignment; switched filename annotations off
* nudge Travis
* Address PR feedback
* attempting to apply custom styles
* update specs
* update specs
* add favicon if exists
* remove site-name method
* styling changes ✨
* nudge Travis
* PR review comments
* keep border around A-tag fallback
* use preferred description
* remove www prefix from url
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Arit Amana <msarit@gmail.com>
2022-04-04 15:31:38 -04:00
Michael Kohl
33195929aa
Bump to Rails 7.0.2.2 MVP ( #15908 )
...
* Update gems
* Update more gems
* Update @rails/ujs package
* Explicitly add sprockets-rails
* Gemfile update
* Run bin/rails app:setup
* Update redis-actionpack
* Update stats initializer autoloading
* Update acts-as-taggable-on
* Disable signed: true option in session store
* Switch back to released version of redis-actionpack
* Update Gemfile.lock
* WIP
* Update Rails and gems
* Move hair_trigger back to released gem
* Add explicit requires to initializers
* Update Rails version
* Add more explicit require_relative calls
* Re-enable ForemStatsDriver
* Update schema
* Temp spec changes
* Bullet started raising errors?
* Fix broken spec
* Temporarily disable hair_trigger_spec
* Refactor
* Fix spec
* Enable use_rfc4122_namespaced_uuids
* Revert "Enable use_rfc4122_namespaced_uuids"
This reverts commit 5dac3722284bb08049586bfa943405f8a01289df.
* Temporarily deploy to canary
* Revert "Temporarily deploy to canary"
This reverts commit 04f8469501fab2a3177450baf051ff6259c41827.
* Update Containerfile
* Add comments to specs
Co-authored-by: Mac Siri <krairit.siri@gmail.com>
2022-03-30 15:00:33 -04:00
Mac Siri
dbe1fb6ff3
Remove Spring and spring-commands-rspec gem ( #16848 )
...
* Remove spring and spring-commands-rspec
* Remove all traces of Spring
* Temporarily remove warning gem
* Remove comment
2022-03-10 10:12:51 -05:00
Michael Kohl
3322b49e84
✂️ Remove myself from core contributors ( #16672 )
...
* Remove myself from core contributors
* Update comments
* Update more comments
2022-02-25 09:56:19 -05:00
Jeremy Friesen
4fa2d25924
Ensuring that test's URL methods are similar ( #16348 )
...
Prior to this commit, in test, we had two different answers to "what is
the host of this application?" For Rails generates
URLs (e.g. `root_url`) we would get one answer. For our custom
`URL.url("/")` we got another answer.
This resolves and patches that up.
Closes #16347
2022-01-31 09:18:13 -05:00
Anna Buianova
6a69d9bc61
Set config.cache_classes for test env depending on whether Spring is enabled ( #16344 )
...
* Set config.cache_classes for test env depending on whether Spring is enabled
* Explain setting config.cache_classes in the test env
2022-01-28 19:19:19 +03:00
Michael Kohl
f471ba9bd6
Don't load ActiveJob railtie ( #16074 )
2022-01-12 22:29:54 +07:00
Josh Soref
0403e78f08
Spelling ( #15702 )
...
* spelling: access
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: additional
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: administrative
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: aggregate
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: assigns
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: attributes
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: autocomplete
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: because
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: between
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: bootstrap
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: calculating
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: captcha
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: character
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: chosen
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: commenter
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: competitor
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: componentize
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: contrast
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: corresponding
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: description
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: destroyed
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: destroys
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: discussion
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: episode
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: escaped
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: evaluates
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: expired
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: explicitly
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: facebook
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: fragment
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: functionality
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: improper
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: incentive
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: interfere
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: latest
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: message
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: minimum
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: moderator
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: mouseover
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: mutual
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: nonexistent
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: notification
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: occasionally
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: occurrence
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: occurs
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: octokit
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: offset
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: omitted
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: opacity
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: organization
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: organizations
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: overridden
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: override
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: overriding
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: prefill
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: previous
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: profile
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: recycling
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: registered
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: repositories
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: rescuing
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: response
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: returns
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: second
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: separator
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: services
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: subscriber
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: subscription
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: success
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: successful
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: successfully
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: suppress
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: test
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: thought
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: uniqueness
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: unknown
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: unproductive
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: unreachable
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: unsuccessful
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: utilities
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: utility
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: valid
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: voluntarily
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: vomited
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: website
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: withholding
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>
2021-12-07 06:59:10 -07:00
Jamie Gaskins
34ad76ab1c
Automatically run DUSs in development ( #15489 )
...
robots doing things >>>>>>>>>>> robots telling humans to do things
2021-11-24 12:32:13 -05:00
Nick Taylor
e79975f705
Now an error is raised in dev/test environments if translations are missing ( #15089 )
2021-10-15 17:29:30 -04:00
VISHAL DEEPAK
c88f8dcdaa
In dashboard show api eager load collection with articles ( #14677 )
...
* In dashboard show api eager load collection with articles
* Dashboard Article Row view now loads collection to suppress bullet warning of eager loading
2021-09-09 11:11:03 +01:00
Michael Kohl
1b87cc7626
Profile generalization cleanup phase 2 ( #14555 )
...
* Remove ignored profile columns
* Update test.rb
* Remove dev profile fields CSV
* Fix first round of specs
* Add additional .includes
* More spec fixes
* Preload user in more locations
* Fix typo
* Spec/preloading fixes
* Specy McSpecFace
* Update e2e seeds
* Update e2e sees with correct display area
* Remove unused eager loading
* Update test.rb
* Add another entry to Bullet.safe_list
* Fix e2e seeds
2021-08-27 09:17:26 +07:00
Michael Kohl
1ebec4b67f
Remove hardcoded user profile fields ( #14079 )
...
* Remove duplicated work display from header
* Update work profile field handling
* Update DUS + spec
* Delegate more carefully
* Update delegation guard
* Adapt for removed delegation
* Undo accidental schema changes
* Fix seeds
* Remove accidentaly change
* Fix User#processed_website_url
* Update guard clause
* Update profile card content
* Add Organization#profile
* Be more conservative with profile fields
* Spec fixes round 1
* Fix typo
* Update spec
* Limit number of header fields and update card content
* Decorate correct model
* Update factory
* Update schema.rb
* Fix validation
* How bad could this possibly be?
* Pretty bad, nevermind
* Remove obsolete code
* Reset profile fields during test runs
* Move profile fields back to before(:suite)
* Spec fixes
* Remove accidentally re-added files
* More spec fixes
* Specs
* Change User#tag_keywords_for_search
* More spec fixes
* Add comment
* Undo accidental schema changes
* Attempt spec fix
* Remove fix attempt
* Fix e2e test
* Update spec
* Remove guard clause
* Remove hardcoded instances of education field
* WIP Access display_email_on_profile via User Settings
* Remove unused profile column
* WIP fix issues revealed by systems specs
* WIP fix issues revealed by services specs
* WIP Fix failing tests
* WIP Fix spec failures
* wip
* Move two attributes from controller to decorator
* Update comment
* More consistently use user.tag_line
Even before the profile changes we sometimes used the user.summary
attribute directly but used the user.tag_line method in other places.
* Remove education
* Add comment
* WIP
* Clean up mostly_work_with
* WIP
* Update work profile field handling
* More work-related changes
* Remove settings_only from display_area enum
* Remove quickfix from _metadata partial
* Remove special attributes
* Remove leftover spec
* Retrieve location from profile, not user
* Profile.special_attributes no longer exists
* Update specs
* More spec fixes
* Update UsersController
* Update UsersController and spec
* Fix e2e seeds
* Minor cleanup
* More e2e seed fixes
* Fix profile field CSV
* Fix e2e seeds
* Move one more attribute in e2e seeds
* Remove duplicate line
* Clear inputs before typing in them
Co-authored-by: Jacob Herrington <jacobherringtondeveloper@gmail.com>
2021-08-18 11:44:53 +07:00
rhymes
d42909401f
Bullet: rename deprecated add_whitelist to add_safelist ( #14521 )
2021-08-17 18:54:03 +02:00
Molly Struve
e87dead7ad
Use new UserSetting and UserNotificationSettings and Ignore Related User Table Fields ( #14121 )
...
* schema file undelete description
* feat: v1 of the script
* Flesh out remaining enums under their categories
* complete UsersSettings data update script
* complete DUS for relevant attributes in users and profiles tables
* complete DUS for users_notification_settings
* alphabetize user_settings sql file
* safeguard against null values for "null: false" settings
* Set up actual UsersSettings DUS and specs files
* fix broken DUS script
* complete specs for UsersSetting DUS
* Address QA of specs
* complete specs for users_notification_settings DUS
* fix the typos (thanks Julianna!)
* begin implementation
* still building
* add missing attribute "email_membership_newsletter"
* complete sync code (except race condition for user profile)
* complete implementation, remains tests
* Address PR review and fix Travis fails
* remove superfluous Profile.new
* fix travis fails
* feat: update the users_notification_setting attributes from the user model
* feat: use the config fonts enums to display the fonts
* feat: loop through the keys
* fix profile = nil blowing up; add specs for notification_setting model
* remove unneeded spec
* remove feed validation until after sync code removed; fixes feed_import spec failures
* remove spec associated with feed_url validation in user_setting model
* fix failing spec 😅
* add TODO
* feat: set the user settings in the user controller and use it in the customization form
* feat: move some update logic to the users settings controller thats being used from customization
* feat: show the updated values form the users_settingd and not the user instance
* Generalize redirect back to current tab
* still trying to reflect changed theme upon refresh
* customizations take effect on refresh
* remove 'with_feed' scope from user model
Co-authored-by: Jamie Gaskins <jamie@forem.com>
* start with takeover for fields previously in profiles table
* Takeover code for `publishing_from_rss` section in Settings (#13914 )
* implement takeover code part 1
* implement takeover code
* fix feed fetch
* need rhymes help
* complete implementation; specs pending
* fix STUPID omission that caused so many headaches 😫
* implement profile fields pointing to users_settings 🎉
* run migrations
* implement inbox type & guidelines takeover code; specs pending (#13911 )
* Point changes in notification settings to `users_notification_settings` table (#13910 )
* implement takeover code; remains specs
* address PR feedback; remove related sync code
* address PR review feedback
* need help with routing and specs
* address pr review
* addressing pr review
* Treat implementation edge cases and omissions 😅
* fix uncommented comment
* fixing implementation cases
* address more PR review feedback
* fixing notifications use-cases
* refactor settings controller
* more pr review changes
* solving bugs
* fix broken onboarding
* handle eperience_level calls
* more fixes
* remove unneeded mappings
* add To-dos for quety updates
* remove done TODO
* purge done TODOs
* update notification_settings-related queries
* start fixing specs
* fixing specs
* fix notification and lrg_forem specs
* fixing broken specs
* still fixing
* fix line dif and remove reloads from user.rb
* run specs
* silence bullet and other fixes
* remove setting migration scripts and specs, fix more settings for specs
* handle missing user for article builder and fix notification specs
* fix some final controller specs and re-add incorrectly removed specs
* remove deprecated data update scripts and related workers, put travis back
* refactor admin tags mods controller, write/move specs for users notifications settings controller
* schema cleanup and other small refactors for consistency
* set field we can invalidate in spec via active record instead of at the db level
* remove I think an uneccessary hook call from subscribe_to_mailchimp_newsletter
* use bnefore_create to setup settings, please dont blow up the test suite
* mailchimp bot fix
* remove decorator in favor of single model method
Co-authored-by: Arit Amana <msarit@gmail.com>
Co-authored-by: Ridhwana <ridhwana.khan16@gmail.com>
Co-authored-by: Arit Amana <32520970+msarit@users.noreply.github.com>
Co-authored-by: Jamie Gaskins <jamie@forem.com>
2021-07-08 09:31:34 -05:00
dependabot[bot]
816855ce3b
Bump rubocop from 1.17.0 to 1.18.0 ( #14107 )
...
* Bump rubocop from 1.17.0 to 1.18.0
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.17.0 to 1.18.0.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.17.0...v1.18.0 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
* yarn install
* Fix violations
* Restore the default aligned setting
* Trigger Travis CI
* Escape HTML
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: rhymes <github@rhymes.dev>
2021-07-01 13:51:49 +02:00
Mac Siri
a8c75fb0e8
Re-add dynamic delivery_method for ApplicationMailer ( #13994 )
2021-06-23 15:17:27 -04:00
Mac Siri
aba6033d9b
Revert dynamic email config changes ( #13983 )
...
* Add missing clear_cache in spec
* Fix broken spec
* Temporarily bring back old config
* Disable specs
2021-06-14 13:08:24 -04:00
Mac Siri
e38196df6f
Create Settings::SMTP ( #13943 )
...
* Fix typo
* Add SMTP configs to Settings::General
* Expand Settings's show page
* Expand Settings::General's constants
* Move smtp_enabled? logic to ApplicationMailer
* Apply suggestions from code review
Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>
* Add missing descriptions and placeholders
* Remove production guard clause
* Change delivery_method to a callback
* Create Settings::SMTP
* Run migration
* Move constants
* Remove SMTP from Settings::General
* Create SMTPSettingsController
* Add back guard clause
* Change which perform_deliveries configuration to use from
* Update config/environments/production.rb
* Rename migration to singular
* Run migration again
* Fix name
* Alphabetize and add validation for authentication
* Move settings and enabled? logic to Settings::SMTP
* Change after_action to before_action
* Fix broken spec
* Fix broken spec
* Create SMTP specs
* Provide default for port
* Create spec for ApplicationMailer
* Fix broken spec
* Move smtp_enabled?
* Search and replace
Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>
2021-06-14 10:29:43 -04:00
Takuma
33ac4d2490
Call config.action_mailer.perform_caching only once ( #13880 )
2021-06-01 14:28:06 +02:00
rhymes
ac898238c1
Enable view annotation in development ( #13860 )
2021-05-26 18:12:12 +02:00
rhymes
70e0e9b83a
[15 min fix] Fix some autoloading deprecation warnings ( #13793 )
...
* Fix autoloading for RateLimitChecker
* Fix autoloading for ForemStatsClient
* Fix autoloading for middlewares
* Move things to their proper place
* Move middleware usage to the proper place
* Re-add rest-client in datadog driver correctly
* Already required in config/initializers/middlewares.rb
* Bring that back
* Fix Honeybadger spec
2021-05-20 18:10:25 +02:00
Mac Siri
5b8b651b67
Allow sign up without email smtp config ( #13650 )
2021-05-14 11:43:49 -04:00
Mac Siri
25f6b3e9ed
Convert SMTP configs into environments vars ( #13542 )
...
Co-authored-by: rhymes <rhymes@hey.com>
2021-05-03 16:32:15 -04:00
Daniel Uber
2478bf7ec7
Enable redis cache store in development ( #13526 )
...
* Always setup redis cache store in development
We need this for argument passing for the podcast episode create
worker after 9973b7361e8936ecd95c938746093524ad56ff63
Do still disable action controller caching by default, but permit
Rails.cache.write and Rails.cache.read to do the expected things
between sidekiq processes.
2021-04-27 08:30:50 -05:00
rhymes
b6360fb80c
Upgrade Rails to 6.1.3.1 ( #11333 )
...
* Upgrade Rails to 6.1
* Switch to unreleased bullet
* Run rails app:update
* Add deprecation notices after reading changelogs
* Fix app:update error
* Move middleware in the correct place
* Temporarily disable ransack which does not support Rails 6.1
* Remove wrongly merged file
* Re-run spring binstub
* Fix double quotes
* Track ransack branch with Rails 6.1 support
* Fix deprecation
* Switch to Ransack 2.4 which supports Rails 6.1 rc1
* Fix missing default params for the duration substitution
* Fix new behavior of relation.pluck with contradictory queries
* Fix uploaders specs by tracking rspec-rails main repo
* Disable bullet temporarily
* Fix remaining fixture_file_upload usages
* Add default seconds for video article duration
* Trigger Travis CI
* Upgrade Rails to 6.1.0.rc2
* Remove file deleted on master
* Add Rails 6.1 gem to Gemfile
* Trigger Travis CI
* Revert "Disable bullet temporarily"
This reverts commit cee0c2ce61fb72cbc16d52c94b12ee681e873031.
* Fix bullet version
* Upgrade to acts-as-taggable 7 and fix conflict
* Update Gemfile and rspec-* gems
* Fix nokogiri in Gemfile.lock
* Switch to rspec-rails main branch
* Remove leftover vendored cached items
* Fix path for Rails 6.1
* Use latest release of erb_lint
* Re-run rails app:update to incorporate new changes
* Disable erb_lint's ErbSafety checks
* Fix Gemfile.lock and re-add platform specific gems of Nokogiri
* Add mini_portile2 as well
* Fix latest merge conflict by removing now unused faraday_middleware
* Upgrade to Rails 6.1.3.1
* Regenerate Gemfile.lock and vendor/cache
* Add x86_64 linux gem
* Mark spec as flaky
* Revert "Mark spec as flaky"
This reverts commit 3caba94b33645f9b59c84ba78ee8df042fc7aee0.
Co-authored-by: Mac Siri <krairit.siri@gmail.com>
2021-04-05 10:39:48 -04:00
Molly Struve
23ef8b7580
Bug Fix:Fix development.rb to Correctly Detect Rails command ( #12191 )
...
* Bug Fix:Fix development.rb to Correctly Detect Rails command
* add DBConsole to dus check
2021-01-11 08:49:20 -06:00
Nick Taylor
04b91520c4
Reenable End to End Testing... Again 😄 ( #11977 )
...
* Re-eneabled e2e tests in Travis.
* Explicitly set cache_template_loading to true for action views.
2020-12-21 06:27:00 -05:00
Ben Halpern
3c297ff05e
Lengthen local caching max-age ( #11970 )
2020-12-20 11:08:10 -05:00
Molly Struve
025c5213d1
Refactor:Remove Deprecated SENDGRID_USERNAME and SENDGRID_PASSWORD From production.rb ( #11376 )
2020-11-12 09:58:10 -06:00
rhymes
38963c6629
Move TimeZoneSetter middleware in proper place ( #11336 )
...
* Move TimeZoneSetter middleware in proper place
* Use explicit naming
2020-11-09 17:11:10 +01:00
Michael Kohl
32e461c66b
Update to Ruby 2.7.2 ( #10594 )
...
* Update to Ruby 2.7.2
* Update remaining files
* Remove VERBOSE from development.rb and test.rb
* Update Ruby version for dependabot and docs
* Readd accidentally removed code
2020-11-05 16:11:09 +01:00
Molly Struve
c55bd0948f
[deploy] Flaky Spec Fix:Set TimeZone For All Spec Requests to Match Zonebie ( #10891 )
2020-10-19 09:24:58 -05:00
rhymes
fe75dcde1c
Routine rubocop fixes ( #10478 )
2020-09-29 10:14:26 -04:00
Ben Halpern
3e09a7768f
[deploy] Remove need for ENV vars during asset precompile ( #10349 )
...
* Remove need for ENV vars during asset precompile
* Add open-search test
2020-09-16 13:57:05 -04:00
Ben Halpern
3a469a99e2
[deploy] Enable admin-configured app_domain ( #10206 )
...
* Move app_domain from env var to siteconfig *within app area*
* Fix SiteConfig
* Don't change URL.domain yet
* Not use in fastly cache purge yet
* Session store magoo
* Revert domain issue
* Add SetCookie middleware
* Temporarily remove cookie middleware and release tasks
* Re-enable SetCookieDomain
* Add some more comments, get it ready for testing
* Remove host from url options and temporarily show errors
* Allow forwarded host to be cookie
* Fix typo
* Change invalidAuthenticityToken
* Properly set app domain
* Proper Fastly cache
* Remove config.app_domain
* Remove config.app_domain
* Explicitely set remember_user_token
* More play with cookies
* Fiddle with remember_user_token
* Add remember_user_token changes
* Monkeypatch devise
* Sessions controller
* Include rememberable
* Include rememberable
* Proper cookie monkeypatch
* Proper cookie monkeypatch
* Proper cookie monkeypatch
* Remove extra cookie code
* User sign in tweak
* Close the loop
* Experiment with carrierwave public_url
* Finalize carrierwave monkeypatch
* Remove async controller specs
* Change some tests
* Update domain test
* Remove temporary production.rb change
* modify cookie logic
* Remove unneeded changes
* Remove unneeded changes
* Explicitely pass host
* Fix linting
* Fix social image test
* Add some cookie tests
* Modify article url
* Fix canonical urls
* Fix typo
* Remove sessions controller
* Remove devise monkeypatch
* Add monkeypatch
* Remove elsif
* Update spec/helpers/application_helper_spec.rb
Co-authored-by: Michael Kohl <citizen428@dev.to>
* Adjust remember_cookie_sync
* Remember user token experimentation
* Fiddle with devise
* Properly configure devise
* Fix typo
* Fix formatting issue
* Add comment about middleware
* Fix typo
Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>
* Remove commented-out code
Co-authored-by: Michael Kohl <citizen428@dev.to>
Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>
2020-09-11 09:38:34 -04:00
rhymes
2d881ef571
Routine rubocop fixes ( #10237 )
2020-09-08 12:06:47 -04:00
Molly Struve
268d2fc144
[deploy] Optimization:Default Production Logging to Error ( #10025 )
2020-08-26 16:15:29 -05:00
Molly Struve
00ad509c3a
[deploy] Update Sendgrid to Use API Key if Present ( #9981 )
2020-08-24 14:20:50 -05:00
Molly Struve
e371446833
Use APP_DOMAIN Locally if Set ( #9920 )
2020-08-21 12:57:36 -04:00
Michael Kohl
eff28766fc
[deploy] Migrate profile data ( #9750 )
...
* Add temporary Rake task for creating profile fields
* Fix problems after splitting branch
* Add profile migration Rake task
* Add unique index to profiles
* Add migration code to users
* Be smarter about updating profiles
* Update spec
* Update Bullet config
* Fix typo
* Change temporary rake task to data update script
* Re-add profile factory and update spec
* Change private declaration to make CodeClimate happy
* Update comment
* Drop validation in favor of DB default
* Update spec
2020-08-20 11:17:57 +07:00
Ben Halpern
244d632565
Check for heroku url presence before working with it ( #9866 )
2020-08-19 10:01:15 -04:00
Molly Struve
0a64ac067b
[deploy] Remove ENVied Gem, Use dotenv Take 2 ( #9767 )
2020-08-14 12:20:47 -05:00
rhymes
e727956640
Revert "[deploy] Refactor:Remove ENVied Gem, Use dotenv Instead for Test and Development ( #9621 )" ( #9757 )
...
This reverts commit 1be8c72206
2020-08-12 13:28:38 -04:00
