maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[deploy] Bug Fix:Sort Reactions by created_at (#10171)

Browse source
This commit is contained in:
Molly Struve 2020-09-03 14:18:02 -05:00 • committed by GitHub
parent d6449cab26
commit d0d3c2a2ab
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/services/search/query_builders/reaction.rb
View file

@ -22,7 +22,7 @@ module Search
}.freeze
DEFAULT_PARAMS = {
sort_by: "id",
sort_by: "created_at",
sort_direction: "desc",
size: 0
}.freeze

6
spec/services/search/reaction_spec.rb
View file

@ -10,8 +10,8 @@ RSpec.describe Search::Reaction, type: :service do
describe "::search_documents", elasticsearch: "Reaction" do
let(:article1) { create(:article) }
let(:article2) { create(:article) }
let(:reaction1) { create(:reaction, category: "readinglist", reactable: article1) }
let(:reaction2) { create(:reaction, category: "readinglist", reactable: article2) }
let(:reaction1) { create(:reaction, category: "readinglist", reactable: article1, created_at: 1.week.ago) }
let(:reaction2) { create(:reaction, category: "readinglist", reactable: article2, created_at: Time.current) }
let(:query_params) { { size: 5 } }
it "parses reaction document hits from search response" do
@ -112,7 +112,7 @@ RSpec.describe Search::Reaction, type: :service do
end
context "with default sorting" do
xit "sorts by id" do
it "sorts by created_at" do
index_documents([reaction1, reaction2])
reaction_docs = described_class.search_documents(params: query_params)["reactions"]