From d0d3c2a2ab3de92b0bc91f84cb815e94c37534a3 Mon Sep 17 00:00:00 2001 From: Molly Struve Date: Thu, 3 Sep 2020 14:18:02 -0500 Subject: [PATCH] [deploy] Bug Fix:Sort Reactions by created_at (#10171) --- app/services/search/query_builders/reaction.rb | 2 +- spec/services/search/reaction_spec.rb | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/app/services/search/query_builders/reaction.rb b/app/services/search/query_builders/reaction.rb index dddafa17e..aa641af73 100644 --- a/app/services/search/query_builders/reaction.rb +++ b/app/services/search/query_builders/reaction.rb @@ -22,7 +22,7 @@ module Search }.freeze DEFAULT_PARAMS = { - sort_by: "id", + sort_by: "created_at", sort_direction: "desc", size: 0 }.freeze diff --git a/spec/services/search/reaction_spec.rb b/spec/services/search/reaction_spec.rb index 81e3ab437..f145bfcc2 100644 --- a/spec/services/search/reaction_spec.rb +++ b/spec/services/search/reaction_spec.rb @@ -10,8 +10,8 @@ RSpec.describe Search::Reaction, type: :service do describe "::search_documents", elasticsearch: "Reaction" do let(:article1) { create(:article) } let(:article2) { create(:article) } - let(:reaction1) { create(:reaction, category: "readinglist", reactable: article1) } - let(:reaction2) { create(:reaction, category: "readinglist", reactable: article2) } + let(:reaction1) { create(:reaction, category: "readinglist", reactable: article1, created_at: 1.week.ago) } + let(:reaction2) { create(:reaction, category: "readinglist", reactable: article2, created_at: Time.current) } let(:query_params) { { size: 5 } } it "parses reaction document hits from search response" do @@ -112,7 +112,7 @@ RSpec.describe Search::Reaction, type: :service do end context "with default sorting" do - xit "sorts by id" do + it "sorts by created_at" do index_documents([reaction1, reaction2]) reaction_docs = described_class.search_documents(params: query_params)["reactions"]