maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove unused freezeScrolling (#19808)

Browse source 
* Remove unused freezeScrolling

* chore: try see if this helps to skip the flakey test that wasn't being skipped

* chore: try see if this helps to skip the flakey test that wasn't being skipped

* oops: revert the gemfile changes

---------

Co-authored-by: Mai Irie <mai@forem.com>
Co-authored-by: Mac Siri <mac@forem.com>
Co-authored-by: Ridhwana <ridhwana.khan16@gmail.com>
This commit is contained in:
Joshua Wehner 2023-08-03 12:47:15 -04:00 • committed by GitHub
parent d28b69b658
commit 8bb007396c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 4 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
app/assets/javascripts/initializePage.js
View file

@ -39,10 +39,6 @@ function initializePage() {
callInitializers();
function freezeScrolling(event) {
event.preventDefault();
}
nextPage = 0;
fetching = false;
done = false;

7
spec/services/admin/charts_data_spec.rb
View file

@ -29,8 +29,7 @@ RSpec.describe Admin::ChartsData, type: :service do
Timecop.return
end
it "returns proper number of items" do
skip "flaky spec"
it "returns proper number of items", skip: "flakey spec" do
create(:article, published_at: Time.zone.today)
create_list(:article, 3, published_at: 4.days.ago)
create_list(:article, 2, published_at: 7.days.ago)
@ -44,9 +43,7 @@ RSpec.describe Admin::ChartsData, type: :service do
expect(described_class.new.call.first.second).to eq(0)
end
it "goes back seven days by default" do
skip "flaky spec"
it "goes back seven days by default", skip: "flakey spec" do
create(:article, published_at: 7.days.ago)
create(:article, published_at: 8.days.ago)

6
spec/services/comment_creator_spec.rb
View file

@ -37,15 +37,13 @@ RSpec.describe CommentCreator, type: :service do
creator.save
end
it "notifies subscribers" do
skip "flaky spec"
it "notifies subscribers", skip: "flakey spec" do
expect(NotificationSubscription).to have_received(:create)
expect(Notification).to have_received(:send_new_comment_notifications_without_delay)
expect(Mention).to have_received(:create_all)
end
it "creates a new reaction" do
skip "flaky spec"
it "creates a new reaction", skip: "flakey spec" do
expect(Reaction).to have_received(:create)
end
end