From 8bb007396c712a672dc24709450eea53e702d1dd Mon Sep 17 00:00:00 2001 From: Joshua Wehner Date: Thu, 3 Aug 2023 12:47:15 -0400 Subject: [PATCH] Remove unused freezeScrolling (#19808) * Remove unused freezeScrolling * chore: try see if this helps to skip the flakey test that wasn't being skipped * chore: try see if this helps to skip the flakey test that wasn't being skipped * oops: revert the gemfile changes --------- Co-authored-by: Mai Irie Co-authored-by: Mac Siri Co-authored-by: Ridhwana --- app/assets/javascripts/initializePage.js | 4 ---- spec/services/admin/charts_data_spec.rb | 7 ++----- spec/services/comment_creator_spec.rb | 6 ++---- 3 files changed, 4 insertions(+), 13 deletions(-) diff --git a/app/assets/javascripts/initializePage.js b/app/assets/javascripts/initializePage.js index c934e9368..f29c3dc66 100644 --- a/app/assets/javascripts/initializePage.js +++ b/app/assets/javascripts/initializePage.js @@ -39,10 +39,6 @@ function initializePage() { callInitializers(); - function freezeScrolling(event) { - event.preventDefault(); - } - nextPage = 0; fetching = false; done = false; diff --git a/spec/services/admin/charts_data_spec.rb b/spec/services/admin/charts_data_spec.rb index 060d7685a..cee658e17 100644 --- a/spec/services/admin/charts_data_spec.rb +++ b/spec/services/admin/charts_data_spec.rb @@ -29,8 +29,7 @@ RSpec.describe Admin::ChartsData, type: :service do Timecop.return end - it "returns proper number of items" do - skip "flaky spec" + it "returns proper number of items", skip: "flakey spec" do create(:article, published_at: Time.zone.today) create_list(:article, 3, published_at: 4.days.ago) create_list(:article, 2, published_at: 7.days.ago) @@ -44,9 +43,7 @@ RSpec.describe Admin::ChartsData, type: :service do expect(described_class.new.call.first.second).to eq(0) end - it "goes back seven days by default" do - skip "flaky spec" - + it "goes back seven days by default", skip: "flakey spec" do create(:article, published_at: 7.days.ago) create(:article, published_at: 8.days.ago) diff --git a/spec/services/comment_creator_spec.rb b/spec/services/comment_creator_spec.rb index 43a3ca20f..65945e9a0 100644 --- a/spec/services/comment_creator_spec.rb +++ b/spec/services/comment_creator_spec.rb @@ -37,15 +37,13 @@ RSpec.describe CommentCreator, type: :service do creator.save end - it "notifies subscribers" do - skip "flaky spec" + it "notifies subscribers", skip: "flakey spec" do expect(NotificationSubscription).to have_received(:create) expect(Notification).to have_received(:send_new_comment_notifications_without_delay) expect(Mention).to have_received(:create_all) end - it "creates a new reaction" do - skip "flaky spec" + it "creates a new reaction", skip: "flakey spec" do expect(Reaction).to have_received(:create) end end