maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add a safe default value for cloudinary secure (#16989)

Browse source 
* Add a comment, and a safe default value for cloudinary

When moving a site from imgproxy to cloudinary, we observed that
wrapping the cloud name in quotes caused off-looking urls (with the
user name in %22 escaped quotes).

Additionally, if cloudinary is enabled, cloudinary secure should
be set to true. We leave the others blank to prevent conditionally enabling this
service (we check for ENV var presence) mistakenly, but the secure
flag won't turn it on or off and is safe to keep a default value.

* remove unnecessary comment

quoting the env vars had no effect when tested.
This commit is contained in:
Daniel Uber 2022-03-24 09:29:07 -05:00 • committed by GitHub
parent df0efd57d9
commit 659ddb8829
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.env_sample
View file

@ -99,7 +99,7 @@ BUFFER_LISTINGS_PROFILE="Optional"
CLOUDINARY_API_KEY=
CLOUDINARY_API_SECRET=
CLOUDINARY_CLOUD_NAME=
CLOUDINARY_SECURE=
CLOUDINARY_SECURE=true
# HTML/CSS to Image for generating social preview images
# (https://docs.htmlcsstoimage.com/example-code/ruby)