From 659ddb8829edfb45d5ea83a96c01ed37f79c0907 Mon Sep 17 00:00:00 2001 From: Daniel Uber Date: Thu, 24 Mar 2022 09:29:07 -0500 Subject: [PATCH] Add a safe default value for cloudinary secure (#16989) * Add a comment, and a safe default value for cloudinary When moving a site from imgproxy to cloudinary, we observed that wrapping the cloud name in quotes caused off-looking urls (with the user name in %22 escaped quotes). Additionally, if cloudinary is enabled, cloudinary secure should be set to true. We leave the others blank to prevent conditionally enabling this service (we check for ENV var presence) mistakenly, but the secure flag won't turn it on or off and is safe to keep a default value. * remove unnecessary comment quoting the env vars had no effect when tested. --- .env_sample | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.env_sample b/.env_sample index 5890ec9fe..a59de0cf7 100644 --- a/.env_sample +++ b/.env_sample @@ -99,7 +99,7 @@ BUFFER_LISTINGS_PROFILE="Optional" CLOUDINARY_API_KEY= CLOUDINARY_API_SECRET= CLOUDINARY_CLOUD_NAME= -CLOUDINARY_SECURE= +CLOUDINARY_SECURE=true # HTML/CSS to Image for generating social preview images # (https://docs.htmlcsstoimage.com/example-code/ruby)