maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Take :display_ad_event params as well as :billboard_event (#19810)

Browse source
This commit is contained in:
Anna Buianova 2023-07-21 17:53:28 +03:00 • committed by GitHub
parent 6c2c1660db
commit 3adeb14ea0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 13 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
app/controllers/billboard_events_controller.rb
View file

@ -33,6 +33,7 @@ class BillboardEventsController < ApplicationMetalController
end
def billboard_event_params
params[:billboard_event].slice(:context_type, :category, :display_ad_id)
event_params = params[:billboard_event] || params[:display_ad_event]
event_params.slice(:context_type, :category, :display_ad_id)
end
end

11
spec/requests/billboard_events_spec.rb
View file

@ -22,6 +22,17 @@ RSpec.describe "BillboardEvents" do
expect(display_ad.reload.clicks_count).to eq(1)
end
it "creates a display ad click event with old params" do
post "/billboard_events", params: {
display_ad_event: {
display_ad_id: display_ad.id,
context_type: DisplayAdEvent::CONTEXT_TYPE_HOME,
category: DisplayAdEvent::CATEGORY_CLICK
}
}
expect(display_ad.reload.clicks_count).to eq(1)
end
it "creates a display ad impression event" do
post "/billboard_events", params: {
billboard_event: {