From 3adeb14ea05c5c032350fec28b1b0cc690a766e8 Mon Sep 17 00:00:00 2001 From: Anna Buianova Date: Fri, 21 Jul 2023 17:53:28 +0300 Subject: [PATCH] Take :display_ad_event params as well as :billboard_event (#19810) --- app/controllers/billboard_events_controller.rb | 3 ++- spec/requests/billboard_events_spec.rb | 11 +++++++++++ 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/app/controllers/billboard_events_controller.rb b/app/controllers/billboard_events_controller.rb index 37fa9198c..e2fcc494c 100644 --- a/app/controllers/billboard_events_controller.rb +++ b/app/controllers/billboard_events_controller.rb @@ -33,6 +33,7 @@ class BillboardEventsController < ApplicationMetalController end def billboard_event_params - params[:billboard_event].slice(:context_type, :category, :display_ad_id) + event_params = params[:billboard_event] || params[:display_ad_event] + event_params.slice(:context_type, :category, :display_ad_id) end end diff --git a/spec/requests/billboard_events_spec.rb b/spec/requests/billboard_events_spec.rb index befee97a6..4b71ba3ad 100644 --- a/spec/requests/billboard_events_spec.rb +++ b/spec/requests/billboard_events_spec.rb @@ -22,6 +22,17 @@ RSpec.describe "BillboardEvents" do expect(display_ad.reload.clicks_count).to eq(1) end + it "creates a display ad click event with old params" do + post "/billboard_events", params: { + display_ad_event: { + display_ad_id: display_ad.id, + context_type: DisplayAdEvent::CONTEXT_TYPE_HOME, + category: DisplayAdEvent::CATEGORY_CLICK + } + } + expect(display_ad.reload.clicks_count).to eq(1) + end + it "creates a display ad impression event" do post "/billboard_events", params: { billboard_event: {