maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix broken email settings documentation link (#16792)

Browse source 
* Fix broken documentation link

When sending an invitation, and smtp isn't configured, we show a link
to the old smtp-settings page, which has been renamed
email-server-settings in the admin documentation site.

* Remove explicit link target, assert link text is present

This spec failed when I changed the link target to match the
documentation. Rather than moving the target, I'm just asserting we
show a link to the docs (not where the docs are located).
This commit is contained in:
Daniel Uber 2022-03-07 10:45:35 -06:00 • committed by GitHub
parent 1b337b85d9
commit 1bf350c321
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/views/admin/invitations/new.html.erb
View file

@ -8,7 +8,7 @@
SMTP settings are required so that your Forem can send emails.
If you wish to send invites, email digests and activity notifications you will need to
specify which email host will relay those messages for you. You can
<a href="https://admin.forem.com/docs/advanced-customization/config/smtp-settings" target="_blank">read more about SMTP Settings in our admin guide</a>.
<a href="https://admin.forem.com/docs/advanced-customization/config/email-server-settings" target="_blank">read more about SMTP Settings in our admin guide</a>.
</div>
<div class="my-4">
Please note that you will need to reload this page after configuring your SMTP Settings.

2
spec/system/admin/admin_invites_user_spec.rb
View file

@ -26,7 +26,7 @@ RSpec.describe "Admin invites user", type: :system do
end
it "contains a link to the documentation" do
expect(page).to have_link("read more about SMTP Settings in our admin guide", href: "https://admin.forem.com/docs/advanced-customization/config/smtp-settings")
expect(page).to have_link("read more about SMTP Settings in our admin guide")
end
it "contains a link to configure SMTP settings" do