From 1bf350c321093db83e9001de9c2e5cd468ea651b Mon Sep 17 00:00:00 2001 From: Daniel Uber Date: Mon, 7 Mar 2022 10:45:35 -0600 Subject: [PATCH] Fix broken email settings documentation link (#16792) * Fix broken documentation link When sending an invitation, and smtp isn't configured, we show a link to the old smtp-settings page, which has been renamed email-server-settings in the admin documentation site. * Remove explicit link target, assert link text is present This spec failed when I changed the link target to match the documentation. Rather than moving the target, I'm just asserting we show a link to the docs (not where the docs are located). --- app/views/admin/invitations/new.html.erb | 2 +- spec/system/admin/admin_invites_user_spec.rb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/views/admin/invitations/new.html.erb b/app/views/admin/invitations/new.html.erb index 5b44aebda..ea5dc2fc5 100644 --- a/app/views/admin/invitations/new.html.erb +++ b/app/views/admin/invitations/new.html.erb @@ -8,7 +8,7 @@ SMTP settings are required so that your Forem can send emails. If you wish to send invites, email digests and activity notifications you will need to specify which email host will relay those messages for you. You can - read more about SMTP Settings in our admin guide. + read more about SMTP Settings in our admin guide.
Please note that you will need to reload this page after configuring your SMTP Settings. diff --git a/spec/system/admin/admin_invites_user_spec.rb b/spec/system/admin/admin_invites_user_spec.rb index 052d89923..923c873e4 100644 --- a/spec/system/admin/admin_invites_user_spec.rb +++ b/spec/system/admin/admin_invites_user_spec.rb @@ -26,7 +26,7 @@ RSpec.describe "Admin invites user", type: :system do end it "contains a link to the documentation" do - expect(page).to have_link("read more about SMTP Settings in our admin guide", href: "https://admin.forem.com/docs/advanced-customization/config/smtp-settings") + expect(page).to have_link("read more about SMTP Settings in our admin guide") end it "contains a link to configure SMTP settings" do