bc4dbeee7b
The Routes component skips calling the possible loadData of a page if the logout is in progress. However, the logoutSuccess and the clearCurrentUser actions were dispatched in an order that cleared the user from the store before the logout was marked done. The fix was to order the actions so that the logout is marked done first and then all the cleanup is done. A better solution in the future would be to batch actions so that extra render loops are avoided when dispatching multiple actions at once. |
||
|---|---|---|
| docs | ||
| public | ||
| server | ||
| src | ||
| .gitignore | ||
| .nsprc | ||
| .prettierignore | ||
| circle.yml | ||
| heroku-copy-ssh-key-from-env.sh | ||
| package.json | ||
| README.md | ||
| yarn.lock | ||
Sharetribe Starter App
This is a template application for a Sharetribe marketplace that can be extended and customised. It is based on an application bootstrapped with create-react-app with some additions, namely server side rendering and a custom CSS setup.
Documentation
Documentation can be found in the docs directory.
Getting started
Install required tools:
Clone this repository and install dependencies:
yarn install
Development
To develop the application and to see changes live, start the frontend development server:
yarn run dev
Known issues:
- Adding/changing
imports may not be synced properly with ESLint. You may see an errorUnable to resolve path to moduleeven though the module existing in right path. Restarting the server doesn't help. To solve the issue, you need to make a change to the file where the error occurs.
Development Server
To develop the server setup, run:
yarn run dev-server
This runs the frontend production build and starts the Express.js
server in server/index.js that renders the application routes in the
server. The server is automatically restarted when there are changes
in the server/ directory.
Not that this server does not pick up changes in the frontend application code.
Tests
To start the test watcher, run
yarn test
See more in the testing documentation.
Deployment
The master branch is automatically deployed to Heroku. If you want
to deploy a feature branch, setup the sharetribe-starter-app Heroku
app and push the feature branch:
git push heroku my-feature-branch:master