diff --git a/CHANGELOG.md b/CHANGELOG.md index 6910e12d..4982358a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -16,8 +16,13 @@ way to update this template, but currently, we follow a pattern: ## [v3.5.1] 2019-09-16 -- [add] add orverriding function `onAdd` and `onRemove` for `CustomOverlayView` in `SearchMapWithGoogleMap` to abide to React rules and do not `unmountComponentAtNode` when a component is rendered by React and use `appendChild` on `onAdd` instead of `draw` to [improve performance](https://github.com/tomchentw/react-google-maps/issues/817). -- [fix] fix `CustomOverlayView` in `SearchMapWithGoogleMap` to work with new `react-intl` version, overriding `render` method to render child object by using `createPortal` instead of `unstable_renderSubtreeIntoContainer`. +- [add] add orverriding function `onAdd` and `onRemove` for `CustomOverlayView` in + `SearchMapWithGoogleMap` to abide to React rules and do not `unmountComponentAtNode` when a + component is rendered by React and use `appendChild` on `onAdd` instead of `draw` to + [improve performance](https://github.com/tomchentw/react-google-maps/issues/817). +- [fix] fix `CustomOverlayView` in `SearchMapWithGoogleMap` to work with new `react-intl` version, + overriding `render` method to render child object by using `createPortal` instead of + `unstable_renderSubtreeIntoContainer`. ## [v3.5.0] 2019-08-29 diff --git a/src/components/SearchMap/SearchMapWithGoogleMap.js b/src/components/SearchMap/SearchMapWithGoogleMap.js index a22d9737..b7ba46b1 100644 --- a/src/components/SearchMap/SearchMapWithGoogleMap.js +++ b/src/components/SearchMap/SearchMapWithGoogleMap.js @@ -88,7 +88,6 @@ export const isMapsLibLoaded = () => * https://github.com/tomchentw/react-google-maps/issues/482 */ class CustomOverlayView extends OverlayView { - onRemove() { this.containerElement.parentNode.removeChild(this.containerElement); //Remove `unmountComponentAtNode` for react version 16 @@ -118,10 +117,7 @@ class CustomOverlayView extends OverlayView { render() { if (React.version.match(/^16/) && this.containerElement) { - return ReactDOM.createPortal( - React.Children.only(this.props.children), - this.containerElement - ); + return ReactDOM.createPortal(React.Children.only(this.props.children), this.containerElement); } return false; }