maverick/flex-template-web
1
0
Fork 0
mirror of https://github.com/kingomarnajjar/flex-template-web.git synced 2026-07-31 02:26:50 +10:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #712 from sharetribe/fix-filter-label

Browse source 
Add validation for filtering query params
This commit is contained in:
Hannu Lyytikäinen 2018-02-19 08:31:05 +02:00 • committed by GitHub
commit d5b7352215
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 14 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
src/containers/SearchPage/SearchPage.js
View file

@ -71,6 +71,16 @@ const validURLParamForExtendedData = (paramKey, urlParams) => {
return {};
};
// validate filter params
const validURLParamsForExtendedData = params => {
const { [CATEGORY_URL_PARAM]: category, [AMENITIES_URL_PARAM]: amenities, ...rest } = params;
return {
...rest,
...validURLParamForExtendedData(CATEGORY_URL_PARAM, params),
...validURLParamForExtendedData(AMENITIES_URL_PARAM, params),
};
};
// extract search parameters, including a custom attribute named category
const pickSearchParamsOnly = params => {
const { address, origin, bounds, country, ...rest } = params || {};
@ -244,6 +254,8 @@ export class SearchPageComponent extends Component {
const totalItems = searchParamsMatch && hasPaginationInfo ? pagination.totalItems : 0;
const listingsAreLoaded = !searchInProgress && searchParamsMatch && hasPaginationInfo;
const validQueryParams = validURLParamsForExtendedData(searchInURL);
const searchError = (
<h2 className={css.error}>
<FormattedMessage id="SearchPage.searchError" />
@ -333,7 +345,7 @@ export class SearchPageComponent extends Component {
<div className={css.searchResultContainer}>
<SearchFilters
className={css.searchFilters}
urlQueryParams={searchInURL}
urlQueryParams={validQueryParams}
listingsAreLoaded={listingsAreLoaded}
resultsCount={totalItems}
searchInProgress={searchInProgress}
@ -345,7 +357,7 @@ export class SearchPageComponent extends Component {
/>
<SearchFiltersMobile
className={css.searchFiltersMobile}
urlQueryParams={searchInURL}
urlQueryParams={validQueryParams}
listingsAreLoaded={listingsAreLoaded}
resultsCount={totalItems}
searchInProgress={searchInProgress}