maverick/flex-template-web
1
0
Fork 0
mirror of https://github.com/kingomarnajjar/flex-template-web.git synced 2026-07-25 22:37:18 +10:00
Code Issues Projects Releases Packages Wiki Activity Actions

Revert PORT handling to previous behaviour

Browse source
This commit is contained in:
Olli Vanhapiha 2018-03-15 22:25:47 +02:00
parent 6380d7569f
commit d55cc7b250
6 changed files with 34 additions and 26 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
.env-template
View file

@ -12,7 +12,6 @@ REACT_APP_SHARETRIBE_SDK_BASE_URL=http://localhost:8088
REACT_APP_SHARETRIBE_MARKETPLACE_CURRENCY=USD REACT_APP_SHARETRIBE_MARKETPLACE_CURRENCY=USD
REACT_APP_CANONICAL_ROOT_URL=http://localhost:3000 REACT_APP_CANONICAL_ROOT_URL=http://localhost:3000
PORT=4000
# This is overwritten by configuration in .env.development and # This is overwritten by configuration in .env.development and
# .env.test. In production deployments use env variable and set it to # .env.test. In production deployments use env variable and set it to

1
.env.development
View file

@ -1 +1,2 @@
REACT_APP_ENV=development REACT_APP_ENV=development

3
.env.test
View file

@ -1,3 +1,4 @@
REACT_APP_ENV=test REACT_APP_ENV=test
REACT_APP_SHARETRIBE_MARKETPLACE_CURRENCY=USD REACT_APP_SHARETRIBE_MARKETPLACE_CURRENCY=USD
REACT_APP_CANONICAL_ROOT_URL=http://localhost:3000 REACT_APP_CANONICAL_ROOT_URL=http://localhost:3000

2
README.md
View file

@ -27,7 +27,7 @@ Clone this repository and install dependencies:
**First, you need to configure Client Id, Google Maps API key and **First, you need to configure Client Id, Google Maps API key and
Stripe publishable API key via [environment Stripe publishable API key via [environment
variables](./docs/env.md).** The quickest way to do this is to copy variables](./docs/env.md).** The quickest way to do this is to copy
.env-template -> .env, and edit the file to add the three mandatory `.env-template` -> `.env`, and edit the file to set the three mandatory
configuration values. configuration values.
To develop the application and to see changes live, start the frontend development server: To develop the application and to see changes live, start the frontend development server:

51
docs/env.md
View file

@ -3,32 +3,39 @@
The following configuration variables can be set to control the Starter App behaviour. Most of them The following configuration variables can be set to control the Starter App behaviour. Most of them
have defaults that work for development environment. For production deploys most should be set. have defaults that work for development environment. For production deploys most should be set.
| Variable | Must be set? | Default | Description | | Variable | Description |
| ----------------------------------------- | ------------ | --------------------- | ----------------------------------------------------------------------------------------------------------------- | | ----------------------------------------- | ----------------------------------------------------------------------------------------------------------------- |
| REACT_APP_GOOGLE_MAPS_API_KEY | X | - | See: [Google Maps API key](./google-maps.md) | | REACT_APP_GOOGLE_MAPS_API_KEY | See: [Google Maps API key](./google-maps.md) |
| REACT_APP_SHARETRIBE_SDK_CLIENT_ID | X | - | Client ID (API key). You will get this from the Sharetribe team. | | REACT_APP_SHARETRIBE_SDK_CLIENT_ID | Client ID (API key). You will get this from the Sharetribe team. |
| REACT_APP_STRIPE_PUBLISHABLE_KEY | X | - | Stripe publishable API key for generating tokens with Stripe API. Use test key (prefix pk*test*) for development. | | REACT_APP_STRIPE_PUBLISHABLE_KEY | Stripe publishable API key for generating tokens with Stripe API. Use test key (prefix pk*test*) for development. |
| REACT_APP_SHARETRIBE_SDK_BASE_URL | | http://localhost:8088 | The base url to access the Sharetribe Flex Marketplace API. | | REACT_APP_SHARETRIBE_SDK_BASE_URL | The base url to access the Sharetribe Flex Marketplace API. |
| REACT_APP_SHARETRIBE_MARKETPLACE_CURRENCY | | USD | The currency used in the Marketplace as ISO 4217 currency code. For example: USD, EUR, CAD, AUD, etc. | | REACT_APP_SHARETRIBE_MARKETPLACE_CURRENCY | The currency used in the Marketplace as ISO 4217 currency code. For example: USD, EUR, CAD, AUD, etc. |
| REACT_APP_CANONICAL_ROOT_URL | | http://localhost:3000 | Canonical root url of the marketplace. Needed for social media sharing and SEO optimization. | | REACT_APP_CANONICAL_ROOT_URL | Canonical root url of the marketplace. Needed for social media sharing and SEO optimization. |
| NODE_ENV | | ? | Node env. Use 'development' for development and 'production' for production. | | NODE_ENV | Node env. Use 'development' for development and 'production' for production. |
| PORT | | 4000 | Port for server to accept connections. | | PORT | Port for server to accept connections. |
| REACT_APP_ENV | | production | Env for client side. Use the same value as with NODE_ENV. | | REACT_APP_ENV | Env for client side. Use the same value as with NODE_ENV. |
| REACT_APP_SHARETRIBE_USING_SSL | | false | Redirect HTTP to HTTPS? | | REACT_APP_SHARETRIBE_USING_SSL | Redirect HTTP to HTTPS? |
| SERVER_SHARETRIBE_TRUST_PROXY | | false | Set when running the app behind a reverse proxy, e.g. in Heroku. | | SERVER_SHARETRIBE_TRUST_PROXY | Set when running the app behind a reverse proxy, e.g. in Heroku. |
| REACT_APP_PUBLIC_SENTRY_DSN | | - | See: [Error logging with Sentry](./sentry.md) | | REACT_APP_PUBLIC_SENTRY_DSN | See: [Error logging with Sentry](./sentry.md) |
| SERVER_SENTRY_DSN | | - | See: [Error logging with Sentry](./sentry.md) | | SERVER_SENTRY_DSN | See: [Error logging with Sentry](./sentry.md) |
| REACT_APP_CSP | | - | See: [Content Security Policy (CSP)](./content-security-policy.md) | | REACT_APP_CSP | See: [Content Security Policy (CSP)](./content-security-policy.md) |
| BASIC_AUTH_USERNAME | | - | Set to enable HTTP Basic Auth | | BASIC_AUTH_USERNAME | Set to enable HTTP Basic Auth |
| BASIC_AUTH_PASSWORD | | - | Set to enable HTTP Basic Auth | | BASIC_AUTH_PASSWORD | Set to enable HTTP Basic Auth |
| REACT_APP_GOOGLE_ANALYTICS_ID | | - | See: [Google Analytics](./analytics.md) | | REACT_APP_GOOGLE_ANALYTICS_ID | See: [Google Analytics](./analytics.md) |
## Defining the env variables ## Defining configuration
When the Starter App is started locally with `yarn run dev` or `yarn run dev-server`, you can set When the Starter App is started locally with `yarn run dev` or `yarn run dev-server`, you can set
environment variables by using the file .env file. The repository contains a template file environment variables by using the (gitignored) `.env` file. The repository contains a template file
.env-template. Just copy that as .env and edit as necessary. `.env-template` with default configuration. Just copy that as `.env` and edit as necessary.
In production, it's recommended that you set the configuration via env variables and do not deploy In production, it's recommended that you set the configuration via env variables and do not deploy
an .env file. The client application will only be packaged with env variables that start with an .env file. The client application will only be packaged with env variables that start with
REACT_APP. This way server secrets don't end up in client bundles. REACT_APP. This way server secrets don't end up in client bundles.
**With deploys note that the configuration options are bundled in the
client at build time.**** The configuration of the build environment
must match run environment for things to work consistently. To apply
changes to configuration values client bundle must be rebuilt. Just
restarting the server is not enough.

2
package.json
View file

@ -66,7 +66,7 @@
"test-ci": "sharetribe-scripts test --env=jsdom --runInBand", "test-ci": "sharetribe-scripts test --env=jsdom --runInBand",
"eject": "sharetribe-scripts eject", "eject": "sharetribe-scripts eject",
"start": "node server/index.js", "start": "node server/index.js",
"dev-server": "export NODE_ENV=development REACT_APP_CANONICAL_ROOT_URL=http://localhost:4000&&yarn run build&&nodemon --watch server server/index.js", "dev-server": "export NODE_ENV=development PORT=4000 REACT_APP_CANONICAL_ROOT_URL=http://localhost:4000&&yarn run build&&nodemon --watch server server/index.js",
"heroku-prebuild": "./heroku-copy-ssh-key-from-env.sh", "heroku-prebuild": "./heroku-copy-ssh-key-from-env.sh",
"heroku-postbuild": "yarn run build", "heroku-postbuild": "yarn run build",
"audit": "nsp check --preprocessor yarn" "audit": "nsp check --preprocessor yarn"