maverick/flex-template-web
1
0
Fork 0
mirror of https://github.com/kingomarnajjar/flex-template-web.git synced 2026-07-28 12:43:11 +10:00
Code Issues Projects Releases Packages Wiki Activity Actions

Remove confirmation values filter

Browse source 
Use 'y' and 'N' instead of filtering them to booleans as the filtered
value is printed to the console and is confusing is differs from the one
user typed.
This commit is contained in:
Hannu Lyytikainen 2018-11-26 17:17:53 +02:00
parent 3f18707e72
commit d15a9652e0
1 changed files with 4 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
translations.js
View file

@ -137,10 +137,10 @@ const run = () => {
return confirmTranslation(targetLang, key, translation);
})
.then(answers => {
// a bool value if translation addition is confirmed
// 'y' or 'N'
const confirmation = answers.value;
if (!confirmation) {
if (confirmation === 'N') {
console.log('Discarding new translation');
throw new BreakSignal();
}
@ -237,7 +237,7 @@ const addTranslation = (targetLang, key, source) => {
* @param {String} key Key for the new translation
* @param {Object} source Source language translations
*
* @return a Promise with the answers hash containing a boolean value field
* @return a Promise with with answers.value being 'y' or 'N'
*/
const confirmTranslation = (targetLang, key, translation) => {
return inquirer.prompt([
@ -247,8 +247,7 @@ const confirmTranslation = (targetLang, key, translation) => {
message: `Do you want to add the ${targetLangName(targetLang)} translation ${chalk.green(
translation
)} for the key ${chalk.blueBright(key)}? (y/N)`,
filter: value => (value === 'y' ? true : value === 'N' ? false : value),
validate: value => value === true || value === false,
validate: value => value === 'y' || value === 'N',
},
]);
};