From d07fd9f63d92d77e60b3d28109d4f31dfc898177 Mon Sep 17 00:00:00 2001
From: Kimmo Puputti <git@kimmo.kpuputti.fi>
Date: Mon, 23 Oct 2017 15:05:52 +0300
Subject: [PATCH] Make TODOs about draft listings into generic comments

The API might not ever support saving unpublished/draft listings, so
no need to keep the TODO comments as tasks in the code.
---
 .../EditListingDescriptionPanel.js                           | 5 ++++-
 .../EditListingLocationPanel/EditListingLocationPanel.js     | 5 ++++-
 .../EditListingPhotosPanel/EditListingPhotosPanel.js         | 5 ++++-
 .../EditListingPricingPanel/EditListingPricingPanel.js       | 5 ++++-
 src/components/EditListingWizard/EditListingWizard.js        | 4 +++-
 src/containers/EditListingPage/EditListingPage.duck.js       | 1 -
 6 files changed, 19 insertions(+), 6 deletions(-)

diff --git a/src/components/EditListingDescriptionPanel/EditListingDescriptionPanel.js b/src/components/EditListingDescriptionPanel/EditListingDescriptionPanel.js
index 2e6d89cf..e2cb6733 100644
--- a/src/components/EditListingDescriptionPanel/EditListingDescriptionPanel.js
+++ b/src/components/EditListingDescriptionPanel/EditListingDescriptionPanel.js
@@ -71,7 +71,10 @@ EditListingDescriptionPanel.defaultProps = {
 EditListingDescriptionPanel.propTypes = {
   className: string,
   rootClassName: string,
-  listing: object, // TODO Should be propTypes.listing after API support is added.
+
+  // We cannot use propTypes.listing since the listing might be a draft.
+  listing: object,
+
   onSubmit: func.isRequired,
   onChange: func.isRequired,
   submitButtonText: string.isRequired,
diff --git a/src/components/EditListingLocationPanel/EditListingLocationPanel.js b/src/components/EditListingLocationPanel/EditListingLocationPanel.js
index 038b7703..fba13a5e 100644
--- a/src/components/EditListingLocationPanel/EditListingLocationPanel.js
+++ b/src/components/EditListingLocationPanel/EditListingLocationPanel.js
@@ -86,7 +86,10 @@ EditListingLocationPanel.defaultProps = {
 EditListingLocationPanel.propTypes = {
   className: string,
   rootClassName: string,
-  listing: object, // TODO Should be propTypes.listing after API support is added.
+
+  // We cannot use propTypes.listing since the listing might be a draft.
+  listing: object,
+
   onSubmit: func.isRequired,
   onChange: func.isRequired,
   submitButtonText: string.isRequired,
diff --git a/src/components/EditListingPhotosPanel/EditListingPhotosPanel.js b/src/components/EditListingPhotosPanel/EditListingPhotosPanel.js
index 5efb3797..1734f44e 100644
--- a/src/components/EditListingPhotosPanel/EditListingPhotosPanel.js
+++ b/src/components/EditListingPhotosPanel/EditListingPhotosPanel.js
@@ -193,7 +193,10 @@ EditListingPhotosPanel.propTypes = {
   fetchInProgress: bool.isRequired,
   newListingCreated: bool.isRequired,
   images: array,
-  listing: object, // TODO Should be propTypes.listing after API support is added.
+
+  // We cannot use propTypes.listing since the listing might be a draft.
+  listing: object,
+
   onImageUpload: func.isRequired,
   onPayoutDetailsFormChange: func.isRequired,
   onPayoutDetailsSubmit: func.isRequired,
diff --git a/src/components/EditListingPricingPanel/EditListingPricingPanel.js b/src/components/EditListingPricingPanel/EditListingPricingPanel.js
index 015b3ff3..e07aab3f 100644
--- a/src/components/EditListingPricingPanel/EditListingPricingPanel.js
+++ b/src/components/EditListingPricingPanel/EditListingPricingPanel.js
@@ -68,7 +68,10 @@ EditListingPricingPanel.defaultProps = {
 EditListingPricingPanel.propTypes = {
   className: string,
   rootClassName: string,
-  listing: object, // TODO Should be propTypes.listing after API support is added.
+
+  // We cannot use propTypes.listing since the listing might be a draft.
+  listing: object,
+
   onSubmit: func.isRequired,
   onChange: func.isRequired,
   submitButtonText: string.isRequired,
diff --git a/src/components/EditListingWizard/EditListingWizard.js b/src/components/EditListingWizard/EditListingWizard.js
index 1a024527..debe048c 100644
--- a/src/components/EditListingWizard/EditListingWizard.js
+++ b/src/components/EditListingWizard/EditListingWizard.js
@@ -276,8 +276,9 @@ EditListingWizard.propTypes = {
     push: func.isRequired,
   }).isRequired,
   images: array.isRequired,
+
+  // We cannot use propTypes.listing since the listing might be a draft.
   listing: shape({
-    // TODO Should be propTypes.listing after API support is added.
     attributes: shape({
       address: string,
       description: string,
@@ -287,6 +288,7 @@ EditListingWizard.propTypes = {
     }),
     images: array,
   }),
+
   onCreateListing: func.isRequired,
   onUpdateListing: func.isRequired,
   onCreateListingDraft: func.isRequired,
diff --git a/src/containers/EditListingPage/EditListingPage.duck.js b/src/containers/EditListingPage/EditListingPage.duck.js
index c5366da6..01848919 100644
--- a/src/containers/EditListingPage/EditListingPage.duck.js
+++ b/src/containers/EditListingPage/EditListingPage.duck.js
@@ -186,7 +186,6 @@ export const updateImageOrder = imageOrder => ({
   payload: { imageOrder },
 });
 
-// TODO These temporary listing actions will be changed when API supports unpublished listings
 export const createListingDraft = listingData => {
   const { description, title } = listingData;
   return {