maverick/flex-template-web
1
0
Fork 0
mirror of https://github.com/kingomarnajjar/flex-template-web.git synced 2026-07-28 03:43:28 +10:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #532 from sharetribe/update-errors

Browse source 
Update API error checks
This commit is contained in:
Boyan Tabakov 2017-11-02 17:21:55 +02:00 • committed by GitHub
commit cf4cd02c62
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 19 additions and 25 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

35
src/util/errors.js
View file

@ -10,9 +10,11 @@
*/
import {
ERROR_CODE_TRANSITION_PARAMETER_VALIDATION_FAILED,
ERROR_CODE_TRANSACTION_LISTING_NOT_FOUND,
ERROR_CODE_PAYMENT_FAILED,
ERROR_CODE_EMAIL_TAKEN,
ERROR_CODE_EMAIL_NOT_FOUND,
ERROR_CODE_EMAIL_NOT_VERIFIED,
ERROR_CODE_TOO_MANY_VERIFICATION_REQUESTS,
ERROR_CODE_UPLOAD_OVER_LIMIT,
} from './propTypes';
@ -78,36 +80,23 @@ export const isUploadProfileImageOverLimitError = error =>
* Check if the given API error (from `sdk.passwordReset.request()`)
* is due to no user having the given email address.
*/
export const isPasswordRecoveryEmailNotFoundError = error => error && error.status === 404;
export const isPasswordRecoveryEmailNotFoundError = error =>
hasErrorWithCode(error, ERROR_CODE_EMAIL_NOT_FOUND);
/**
* Check if the given API error (from `sdk.passwordReset.request()`)
* is due to the email not being verified, preventing the reset.
*/
export const isPasswordRecoveryEmailNotVerifiedError = error => error && error.status === 409;
export const isPasswordRecoveryEmailNotVerifiedError = error =>
hasErrorWithCode(error, ERROR_CODE_EMAIL_NOT_VERIFIED);
/**
* Check if the given API error (from `sdk.transaction.initiate()` or
* `sdk.transaction.initiateSpeculative()`) is due to the listing
* being closed or deleted.
*/
export const isTransactionInitiateListingNotFoundError = error => {
return responseAPIErrors(error).some(apiError => {
let notfound = false;
try {
// TODO: This is clearly a temporary solution for digging out
// the deleted information from the error and should be changed
// to a proper error code when the API supports a specific code
// for this.
notfound = apiError.details.data.rep[0][1].reason === 'listing-not-found';
} catch (e) {
// Ignore
}
return apiError.code === ERROR_CODE_TRANSITION_PARAMETER_VALIDATION_FAILED && notfound;
});
};
export const isTransactionInitiateListingNotFoundError = error =>
hasErrorWithCode(error, ERROR_CODE_TRANSACTION_LISTING_NOT_FOUND);
/**
* Check if the given API error (from `sdk.transaction.initiate()`) is
@ -122,8 +111,10 @@ export const isTransactionInitiateAmountTooLowError = error => {
try {
// TODO: This is a temporary solution until a proper error code
// for this specific error is received in the response.
const msg = apiError.details.msg;
isAmountTooLow = msg.startsWith('Amount must be at least');
const msg = apiError.meta.stripe_message;
isAmountTooLow =
msg.startsWith('Amount must be at least') ||
msg.startsWith('Amount must convert to at least');
} catch (e) {
// Ignore
}

9
src/util/propTypes.js
View file

@ -218,16 +218,19 @@ export const pagination = shape({
totalPages: number.isRequired,
});
export const ERROR_CODE_TRANSITION_PARAMETER_VALIDATION_FAILED =
'transition-parameter-validation-failed';
export const ERROR_CODE_TRANSACTION_LISTING_NOT_FOUND = 'transaction-listing-not-found';
export const ERROR_CODE_PAYMENT_FAILED = 'transaction-payment-failed';
export const ERROR_CODE_EMAIL_TAKEN = 'email-taken';
export const ERROR_CODE_EMAIL_NOT_FOUND = 'email-not-found';
export const ERROR_CODE_EMAIL_NOT_VERIFIED = 'email-unverified';
export const ERROR_CODE_TOO_MANY_VERIFICATION_REQUESTS = 'email-too-many-verification-requests';
export const ERROR_CODE_UPLOAD_OVER_LIMIT = 'request-upload-over-limit';
const ERROR_CODES = [
ERROR_CODE_TRANSITION_PARAMETER_VALIDATION_FAILED,
ERROR_CODE_TRANSACTION_LISTING_NOT_FOUND,
ERROR_CODE_PAYMENT_FAILED,
ERROR_CODE_EMAIL_TAKEN,
ERROR_CODE_EMAIL_NOT_FOUND,
ERROR_CODE_EMAIL_NOT_VERIFIED,
ERROR_CODE_TOO_MANY_VERIFICATION_REQUESTS,
ERROR_CODE_UPLOAD_OVER_LIMIT,
];