Migrate LocationSearchForm to Final Form

src/containers/NotFoundPage/__snapshots__/NotFoundPage.test.js.snap

@@ -36,7 +36,7 @@ exports[`NotFoundPageComponent matches snapshot 1`] = `
               values={Object {}}
             />
           </p>
-          <ReduxForm
+          <InjectIntl(LocationSearchFormComponent)
             onSubmit={[Function]}
           />
         </div>

src/forms/LocationSearchForm/LocationSearchForm.js

@@ -1,7 +1,6 @@
 import React from 'react';
-import PropTypes from 'prop-types';
-import { compose } from 'redux';
-import { Field, reduxForm, propTypes as formPropTypes } from 'redux-form';
+import { func, string } from 'prop-types';
+import { Form as FinalForm, Field } from 'react-final-form';
 import { intlShape, injectIntl } from 'react-intl';
 import classNames from 'classnames';
 import { Form, LocationAutocompleteInput } from '../../components';
@@ -9,47 +8,65 @@ import { Form, LocationAutocompleteInput } from '../../components';
 import css from './LocationSearchForm.css';
 
 const LocationSearchFormComponent = props => {
-  const { rootClassName, className, intl, onSubmit } = props;
-
-  const onChange = location => {
+  const handleChange = location => {
     if (location.selectedPlace) {
       // Note that we use `onSubmit` instead of the conventional
       // `handleSubmit` prop for submitting. We want to autosubmit
       // when a place is selected, and don't require any extra
       // validations for the form.
-      onSubmit({ location });
+      props.onSubmit({ location });
     }
   };
 
-  const classes = classNames(rootClassName || css.root, className);
-
-  // Allow form submit only when the place has changed
-  const preventFormSubmit = e => e.preventDefault();
-
   return (
-    <Form className={classes} onSubmit={preventFormSubmit}>
-      <Field
-        name="location"
-        label="Location"
-        placeholder={intl.formatMessage({ id: 'LocationSearchForm.placeholder' })}
-        format={null}
-        component={LocationAutocompleteInput}
-        iconClassName={css.searchInputIcon}
-        inputClassName={css.searchInput}
-        predictionsClassName={css.searchPredictions}
-        onChange={onChange}
-      />
-    </Form>
+    <FinalForm
+      {...props}
+      render={({ rootClassName, className, intl, handleSubmit }) => {
+        const classes = classNames(rootClassName || css.root, className);
+
+        // Allow form submit only when the place has changed
+        const preventFormSubmit = e => e.preventDefault();
+
+        return (
+          <Form className={classes} onSubmit={preventFormSubmit}>
+            <Field
+              name="location"
+              format={null}
+              render={({ input, meta }) => {
+                const { onChange, ...restInput } = input;
+
+                // Merge the standard onChange function with custom behaviur. A better solution would
+                // be to use the FormSpy component from Final Form and pass this.onChange to the
+                // onChange prop but that breaks due to insufficient subscription handling.
+                // See: https://github.com/final-form/react-final-form/issues/159
+                const searchOnChange = value => {
+                  onChange(value);
+                  handleChange(value);
+                };
+
+                const searchInput = { ...restInput, onChange: searchOnChange };
+                return (
+                  <LocationAutocompleteInput
+                    placeholder={intl.formatMessage({ id: 'LocationSearchForm.placeholder' })}
+                    iconClassName={css.searchInputIcon}
+                    inputClassName={css.searchInput}
+                    predictionsClassName={css.searchPredictions}
+                    input={searchInput}
+                    meta={meta}
+                  />
+                );
+              }}
+            />
+          </Form>
+        );
+      }}
+    />
   );
 };
 
-const { func, string } = PropTypes;
-
 LocationSearchFormComponent.defaultProps = { rootClassName: null, className: null };
 
 LocationSearchFormComponent.propTypes = {
-  ...formPropTypes,
-
   rootClassName: string,
   className: string,
   onSubmit: func.isRequired,
@@ -58,10 +75,6 @@ LocationSearchFormComponent.propTypes = {
   intl: intlShape.isRequired,
 };
 
-const defaultFormName = 'TopbarSearchForm';
-
-const LocationSearchForm = compose(reduxForm({ form: defaultFormName }), injectIntl)(
-  LocationSearchFormComponent
-);
+const LocationSearchForm = injectIntl(LocationSearchFormComponent);
 
 export default LocationSearchForm;