From 7fc3f2847bcd76f1366d734b840d9d1e039f2b20 Mon Sep 17 00:00:00 2001 From: Kimmo Puputti Date: Mon, 22 Jan 2018 15:43:43 +0200 Subject: [PATCH] Stop using address attribute --- .../EditListingWizard/EditListingWizard.js | 5 +- .../TransactionPanel.test.js.snap | 84 ------------------- .../TransactionPage.test.js.snap | 2 - src/util/test-data.js | 2 - src/util/types.js | 2 - 5 files changed, 2 insertions(+), 93 deletions(-) diff --git a/src/components/EditListingWizard/EditListingWizard.js b/src/components/EditListingWizard/EditListingWizard.js index 05588cb3..c4530f34 100644 --- a/src/components/EditListingWizard/EditListingWizard.js +++ b/src/components/EditListingWizard/EditListingWizard.js @@ -167,11 +167,10 @@ const EditListingWizard = props => { submitButtonText={submitText(intl, isNew, LOCATION)} onChange={onChange} onSubmit={values => { - const { building, location } = values; + const { building = "", location } = values; const { selectedPlace: { address, origin } } = location; const updateValues = { geolocation: origin, - address, publicData: { location: { address, building }, }, @@ -286,8 +285,8 @@ EditListingWizard.propTypes = { // We cannot use propTypes.listing since the listing might be a draft. listing: shape({ attributes: shape({ - address: string, customAttributes: object, // structure (key: value) can be defined in management console + publicData: object, description: string, geolocation: object, pricing: object, diff --git a/src/components/TransactionPanel/__snapshots__/TransactionPanel.test.js.snap b/src/components/TransactionPanel/__snapshots__/TransactionPanel.test.js.snap index b94f3dbc..5e908238 100644 --- a/src/components/TransactionPanel/__snapshots__/TransactionPanel.test.js.snap +++ b/src/components/TransactionPanel/__snapshots__/TransactionPanel.test.js.snap @@ -55,7 +55,6 @@ exports[`TransactionPanel - Order accepted matches snapshot 1`] = ` currentListing={ Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -169,7 +168,6 @@ exports[`TransactionPanel - Order accepted matches snapshot 1`] = ` }, "listing": Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -302,7 +300,6 @@ exports[`TransactionPanel - Order accepted matches snapshot 1`] = ` }, "listing": Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -432,7 +429,6 @@ exports[`TransactionPanel - Order accepted matches snapshot 1`] = ` }, "listing": Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -562,7 +558,6 @@ exports[`TransactionPanel - Order accepted matches snapshot 1`] = ` }, "listing": Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -810,7 +805,6 @@ exports[`TransactionPanel - Order accepted matches snapshot 1`] = ` }, "listing": Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -921,7 +915,6 @@ exports[`TransactionPanel - Order autodeclined matches snapshot 1`] = ` currentListing={ Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -1035,7 +1028,6 @@ exports[`TransactionPanel - Order autodeclined matches snapshot 1`] = ` }, "listing": Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -1168,7 +1160,6 @@ exports[`TransactionPanel - Order autodeclined matches snapshot 1`] = ` }, "listing": Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -1298,7 +1289,6 @@ exports[`TransactionPanel - Order autodeclined matches snapshot 1`] = ` }, "listing": Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -1428,7 +1418,6 @@ exports[`TransactionPanel - Order autodeclined matches snapshot 1`] = ` }, "listing": Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -1676,7 +1665,6 @@ exports[`TransactionPanel - Order autodeclined matches snapshot 1`] = ` }, "listing": Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -1787,7 +1775,6 @@ exports[`TransactionPanel - Order canceled matches snapshot 1`] = ` currentListing={ Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -1901,7 +1888,6 @@ exports[`TransactionPanel - Order canceled matches snapshot 1`] = ` }, "listing": Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -2034,7 +2020,6 @@ exports[`TransactionPanel - Order canceled matches snapshot 1`] = ` }, "listing": Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -2164,7 +2149,6 @@ exports[`TransactionPanel - Order canceled matches snapshot 1`] = ` }, "listing": Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -2294,7 +2278,6 @@ exports[`TransactionPanel - Order canceled matches snapshot 1`] = ` }, "listing": Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -2542,7 +2525,6 @@ exports[`TransactionPanel - Order canceled matches snapshot 1`] = ` }, "listing": Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -2653,7 +2635,6 @@ exports[`TransactionPanel - Order declined matches snapshot 1`] = ` currentListing={ Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -2767,7 +2748,6 @@ exports[`TransactionPanel - Order declined matches snapshot 1`] = ` }, "listing": Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -2900,7 +2880,6 @@ exports[`TransactionPanel - Order declined matches snapshot 1`] = ` }, "listing": Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -3030,7 +3009,6 @@ exports[`TransactionPanel - Order declined matches snapshot 1`] = ` }, "listing": Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -3160,7 +3138,6 @@ exports[`TransactionPanel - Order declined matches snapshot 1`] = ` }, "listing": Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -3408,7 +3385,6 @@ exports[`TransactionPanel - Order declined matches snapshot 1`] = ` }, "listing": Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -3519,7 +3495,6 @@ exports[`TransactionPanel - Order delivered matches snapshot 1`] = ` currentListing={ Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -3633,7 +3608,6 @@ exports[`TransactionPanel - Order delivered matches snapshot 1`] = ` }, "listing": Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -3766,7 +3740,6 @@ exports[`TransactionPanel - Order delivered matches snapshot 1`] = ` }, "listing": Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -3896,7 +3869,6 @@ exports[`TransactionPanel - Order delivered matches snapshot 1`] = ` }, "listing": Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -4026,7 +3998,6 @@ exports[`TransactionPanel - Order delivered matches snapshot 1`] = ` }, "listing": Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -4274,7 +4245,6 @@ exports[`TransactionPanel - Order delivered matches snapshot 1`] = ` }, "listing": Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -4385,7 +4355,6 @@ exports[`TransactionPanel - Order enquired matches snapshot 1`] = ` currentListing={ Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -4499,7 +4468,6 @@ exports[`TransactionPanel - Order enquired matches snapshot 1`] = ` }, "listing": Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -4632,7 +4600,6 @@ exports[`TransactionPanel - Order enquired matches snapshot 1`] = ` }, "listing": Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -4762,7 +4729,6 @@ exports[`TransactionPanel - Order enquired matches snapshot 1`] = ` }, "listing": Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -4892,7 +4858,6 @@ exports[`TransactionPanel - Order enquired matches snapshot 1`] = ` }, "listing": Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -5140,7 +5105,6 @@ exports[`TransactionPanel - Order enquired matches snapshot 1`] = ` }, "listing": Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -5251,7 +5215,6 @@ exports[`TransactionPanel - Order preauthorized matches snapshot 1`] = ` currentListing={ Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -5365,7 +5328,6 @@ exports[`TransactionPanel - Order preauthorized matches snapshot 1`] = ` }, "listing": Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -5498,7 +5460,6 @@ exports[`TransactionPanel - Order preauthorized matches snapshot 1`] = ` }, "listing": Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -5628,7 +5589,6 @@ exports[`TransactionPanel - Order preauthorized matches snapshot 1`] = ` }, "listing": Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -5758,7 +5718,6 @@ exports[`TransactionPanel - Order preauthorized matches snapshot 1`] = ` }, "listing": Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -6006,7 +5965,6 @@ exports[`TransactionPanel - Order preauthorized matches snapshot 1`] = ` }, "listing": Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -6111,7 +6069,6 @@ exports[`TransactionPanel - Sale accepted matches snapshot 1`] = ` currentListing={ Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -6225,7 +6182,6 @@ exports[`TransactionPanel - Sale accepted matches snapshot 1`] = ` }, "listing": Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -6345,7 +6301,6 @@ exports[`TransactionPanel - Sale accepted matches snapshot 1`] = ` }, "listing": Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -6463,7 +6418,6 @@ exports[`TransactionPanel - Sale accepted matches snapshot 1`] = ` }, "listing": Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -6581,7 +6535,6 @@ exports[`TransactionPanel - Sale accepted matches snapshot 1`] = ` }, "listing": Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -6817,7 +6770,6 @@ exports[`TransactionPanel - Sale accepted matches snapshot 1`] = ` }, "listing": Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -6909,7 +6861,6 @@ exports[`TransactionPanel - Sale autodeclined matches snapshot 1`] = ` currentListing={ Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -7023,7 +6974,6 @@ exports[`TransactionPanel - Sale autodeclined matches snapshot 1`] = ` }, "listing": Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -7143,7 +7093,6 @@ exports[`TransactionPanel - Sale autodeclined matches snapshot 1`] = ` }, "listing": Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -7261,7 +7210,6 @@ exports[`TransactionPanel - Sale autodeclined matches snapshot 1`] = ` }, "listing": Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -7379,7 +7327,6 @@ exports[`TransactionPanel - Sale autodeclined matches snapshot 1`] = ` }, "listing": Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -7615,7 +7562,6 @@ exports[`TransactionPanel - Sale autodeclined matches snapshot 1`] = ` }, "listing": Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -7707,7 +7653,6 @@ exports[`TransactionPanel - Sale canceled matches snapshot 1`] = ` currentListing={ Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -7821,7 +7766,6 @@ exports[`TransactionPanel - Sale canceled matches snapshot 1`] = ` }, "listing": Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -7941,7 +7885,6 @@ exports[`TransactionPanel - Sale canceled matches snapshot 1`] = ` }, "listing": Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -8059,7 +8002,6 @@ exports[`TransactionPanel - Sale canceled matches snapshot 1`] = ` }, "listing": Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -8177,7 +8119,6 @@ exports[`TransactionPanel - Sale canceled matches snapshot 1`] = ` }, "listing": Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -8413,7 +8354,6 @@ exports[`TransactionPanel - Sale canceled matches snapshot 1`] = ` }, "listing": Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -8505,7 +8445,6 @@ exports[`TransactionPanel - Sale declined matches snapshot 1`] = ` currentListing={ Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -8619,7 +8558,6 @@ exports[`TransactionPanel - Sale declined matches snapshot 1`] = ` }, "listing": Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -8739,7 +8677,6 @@ exports[`TransactionPanel - Sale declined matches snapshot 1`] = ` }, "listing": Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -8857,7 +8794,6 @@ exports[`TransactionPanel - Sale declined matches snapshot 1`] = ` }, "listing": Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -8975,7 +8911,6 @@ exports[`TransactionPanel - Sale declined matches snapshot 1`] = ` }, "listing": Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -9211,7 +9146,6 @@ exports[`TransactionPanel - Sale declined matches snapshot 1`] = ` }, "listing": Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -9303,7 +9237,6 @@ exports[`TransactionPanel - Sale delivered matches snapshot 1`] = ` currentListing={ Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -9417,7 +9350,6 @@ exports[`TransactionPanel - Sale delivered matches snapshot 1`] = ` }, "listing": Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -9537,7 +9469,6 @@ exports[`TransactionPanel - Sale delivered matches snapshot 1`] = ` }, "listing": Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -9655,7 +9586,6 @@ exports[`TransactionPanel - Sale delivered matches snapshot 1`] = ` }, "listing": Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -9773,7 +9703,6 @@ exports[`TransactionPanel - Sale delivered matches snapshot 1`] = ` }, "listing": Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -10009,7 +9938,6 @@ exports[`TransactionPanel - Sale delivered matches snapshot 1`] = ` }, "listing": Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -10101,7 +10029,6 @@ exports[`TransactionPanel - Sale enquired matches snapshot 1`] = ` currentListing={ Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -10215,7 +10142,6 @@ exports[`TransactionPanel - Sale enquired matches snapshot 1`] = ` }, "listing": Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -10335,7 +10261,6 @@ exports[`TransactionPanel - Sale enquired matches snapshot 1`] = ` }, "listing": Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -10453,7 +10378,6 @@ exports[`TransactionPanel - Sale enquired matches snapshot 1`] = ` }, "listing": Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -10571,7 +10495,6 @@ exports[`TransactionPanel - Sale enquired matches snapshot 1`] = ` }, "listing": Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -10807,7 +10730,6 @@ exports[`TransactionPanel - Sale enquired matches snapshot 1`] = ` }, "listing": Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -10899,7 +10821,6 @@ exports[`TransactionPanel - Sale preauthorized matches snapshot 1`] = ` currentListing={ Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -11013,7 +10934,6 @@ exports[`TransactionPanel - Sale preauthorized matches snapshot 1`] = ` }, "listing": Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -11133,7 +11053,6 @@ exports[`TransactionPanel - Sale preauthorized matches snapshot 1`] = ` }, "listing": Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -11251,7 +11170,6 @@ exports[`TransactionPanel - Sale preauthorized matches snapshot 1`] = ` }, "listing": Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -11369,7 +11287,6 @@ exports[`TransactionPanel - Sale preauthorized matches snapshot 1`] = ` }, "listing": Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -11605,7 +11522,6 @@ exports[`TransactionPanel - Sale preauthorized matches snapshot 1`] = ` }, "listing": Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, diff --git a/src/containers/TransactionPage/__snapshots__/TransactionPage.test.js.snap b/src/containers/TransactionPage/__snapshots__/TransactionPage.test.js.snap index f71009e4..320ce24d 100644 --- a/src/containers/TransactionPage/__snapshots__/TransactionPage.test.js.snap +++ b/src/containers/TransactionPage/__snapshots__/TransactionPage.test.js.snap @@ -148,7 +148,6 @@ exports[`TransactionPage - Order matches snapshot 1`] = ` }, "listing": Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, @@ -347,7 +346,6 @@ exports[`TransactionPage - Sale matches snapshot 1`] = ` }, "listing": Object { "attributes": Object { - "address": "listing1 address", "closed": false, "customAttributes": Object {}, "deleted": false, diff --git a/src/util/test-data.js b/src/util/test-data.js index 4f7eed0a..576a220c 100644 --- a/src/util/test-data.js +++ b/src/util/test-data.js @@ -81,7 +81,6 @@ export const createListing = (id, attributes = {}, includes = {}) => ({ attributes: { title: `${id} title`, description: `${id} description`, - address: `${id} address`, geolocation: new LatLng(40, 60), closed: false, deleted: false, @@ -100,7 +99,6 @@ export const createOwnListing = (id, attributes = {}, includes = {}) => ({ attributes: { title: `${id} title`, description: `${id} description`, - address: `${id} address`, geolocation: new LatLng(40, 60), closed: false, deleted: false, diff --git a/src/util/types.js b/src/util/types.js index 9a175dae..cc952eb6 100644 --- a/src/util/types.js +++ b/src/util/types.js @@ -128,7 +128,6 @@ propTypes.user = shape({ const listingAttributes = shape({ title: string.isRequired, description: string.isRequired, - address: string.isRequired, geolocation: propTypes.latlng.isRequired, closed: bool.isRequired, deleted: propTypes.value(false).isRequired, @@ -140,7 +139,6 @@ const listingAttributes = shape({ const ownListingAttributes = shape({ title: string.isRequired, description: string.isRequired, - address: string.isRequired, geolocation: propTypes.latlng.isRequired, closed: bool.isRequired, deleted: propTypes.value(false).isRequired,