From 7446fca2da7d0358bb811a6c14da797a379e380d Mon Sep 17 00:00:00 2001
From: Vesa Luusua <vesa.luusua@gmail.com>
Date: Wed, 11 Oct 2017 20:11:55 +0300
Subject: [PATCH] ContactDetailsPage uses TopbarContainer

---
 .../ContactDetailsPage/ContactDetailsPage.js  | 69 ++++---------------
 .../ContactDetailsPage.test.js.snap           | 26 +------
 2 files changed, 16 insertions(+), 79 deletions(-)

diff --git a/src/containers/ContactDetailsPage/ContactDetailsPage.js b/src/containers/ContactDetailsPage/ContactDetailsPage.js
index 94f937e1..2c10ac84 100644
--- a/src/containers/ContactDetailsPage/ContactDetailsPage.js
+++ b/src/containers/ContactDetailsPage/ContactDetailsPage.js
@@ -1,46 +1,35 @@
 import React, { PropTypes } from 'react';
 import { compose } from 'redux';
 import { connect } from 'react-redux';
-import { withRouter } from 'react-router-dom';
 import { FormattedMessage } from 'react-intl';
 import * as propTypes from '../../util/propTypes';
 import { ensureCurrentUser } from '../../util/data';
 import { fetchCurrentUser, sendVerificationEmail } from '../../ducks/user.duck';
-import { logout, authenticationInProgress } from '../../ducks/Auth.duck';
-import { manageDisableScrolling, isScrollingDisabled } from '../../ducks/UI.duck';
 import {
   ContentWrapper,
   LayoutSideNavigation,
   Page,
   SideNavWrapper,
   TabNav,
-  Topbar,
   TopbarWrapper,
   UserNav,
 } from '../../components';
-import { ContactDetailsForm } from '../../containers';
+import { ContactDetailsForm, TopbarContainer } from '../../containers';
 
+import { isScrollingDisabled } from '../../ducks/UI.duck';
 import { changeEmail, changeEmailClear } from './ContactDetailsPage.duck';
 import css from './ContactDetailsPage.css';
 
 export const ContactDetailsPageComponent = props => {
   const {
     authInfoError,
-    authInProgress,
     changeEmailError,
     changeEmailInProgress,
     currentUser,
-    currentUserHasListings,
-    currentUserHasOrders,
     emailChanged,
-    history,
-    isAuthenticated,
-    location,
     logoutError,
-    notificationCount,
     onChange,
-    onLogout,
-    onManageDisableScrolling,
+    scrollingDisabled,
     sendVerificationEmailInProgress,
     sendVerificationEmailError,
     onResendVerificationEmail,
@@ -83,26 +72,18 @@ export const ContactDetailsPageComponent = props => {
     : null;
 
   return (
-    <Page authInfoError={authInfoError} logoutError={logoutError} title="Contact details">
+    <Page
+      authInfoError={authInfoError}
+      logoutError={logoutError}
+      title="Contact details"
+      scrollingDisabled={scrollingDisabled}
+    >
       <LayoutSideNavigation>
         <TopbarWrapper>
-          <Topbar
-            authInProgress={authInProgress}
+          <TopbarContainer
             currentPage="ContactDetailsPage"
-            currentUser={currentUser}
-            currentUserHasListings={currentUserHasListings}
-            currentUserHasOrders={currentUserHasOrders}
             desktopClassName={css.desktopTopbar}
-            history={history}
-            isAuthenticated={isAuthenticated}
-            location={location}
             mobileClassName={css.mobileTopbar}
-            notificationCount={notificationCount}
-            onLogout={onLogout}
-            onManageDisableScrolling={onManageDisableScrolling}
-            onResendVerificationEmail={onResendVerificationEmail}
-            sendVerificationEmailInProgress={sendVerificationEmailInProgress}
-            sendVerificationEmailError={sendVerificationEmailError}
           />
           <UserNav selectedPageName="ContactDetailsPage" />
         </TopbarWrapper>
@@ -126,39 +107,25 @@ ContactDetailsPageComponent.defaultProps = {
   authInfoError: null,
   changeEmailError: null,
   currentUser: null,
-  currentUserHasOrders: null,
   logoutError: null,
-  notificationCount: 0,
   sendVerificationEmailError: null,
 };
 
-const { bool, func, instanceOf, number, object, shape } = PropTypes;
+const { bool, func, instanceOf } = PropTypes;
 
 ContactDetailsPageComponent.propTypes = {
   authInfoError: instanceOf(Error),
-  authInProgress: bool.isRequired,
   changeEmailError: instanceOf(Error),
   changeEmailInProgress: bool.isRequired,
   currentUser: propTypes.currentUser,
-  currentUserHasListings: bool.isRequired,
-  currentUserHasOrders: bool,
   emailChanged: bool.isRequired,
-  isAuthenticated: bool.isRequired,
   logoutError: instanceOf(Error),
-  notificationCount: number,
   onChange: func.isRequired,
-  onLogout: func.isRequired,
-  onManageDisableScrolling: func.isRequired,
   onSubmitChangeEmail: func.isRequired,
+  scrollingDisabled: bool.isRequired,
   sendVerificationEmailInProgress: bool.isRequired,
   sendVerificationEmailError: instanceOf(Error),
   onResendVerificationEmail: func.isRequired,
-
-  // from withRouter
-  history: shape({
-    push: func.isRequired,
-  }).isRequired,
-  location: shape({ state: object }).isRequired,
 };
 
 const mapStateToProps = state => {
@@ -167,23 +134,16 @@ const mapStateToProps = state => {
   // Topbar needs user info.
   const {
     currentUser,
-    currentUserHasListings,
-    currentUserHasOrders,
-    currentUserNotificationCount: notificationCount,
     sendVerificationEmailInProgress,
     sendVerificationEmailError,
   } = state.user;
   const { changeEmailError, changeEmailInProgress, emailChanged } = state.ContactDetailsPage;
   return {
     authInfoError,
-    authInProgress: authenticationInProgress(state),
     changeEmailError,
     changeEmailInProgress,
     currentUser,
-    currentUserHasListings,
-    currentUserHasOrders,
     emailChanged,
-    notificationCount,
     isAuthenticated,
     logoutError,
     scrollingDisabled: isScrollingDisabled(state),
@@ -194,14 +154,11 @@ const mapStateToProps = state => {
 
 const mapDispatchToProps = dispatch => ({
   onChange: () => dispatch(changeEmailClear()),
-  onLogout: historyPush => dispatch(logout(historyPush)),
-  onManageDisableScrolling: (componentId, disableScrolling) =>
-    dispatch(manageDisableScrolling(componentId, disableScrolling)),
   onResendVerificationEmail: () => dispatch(sendVerificationEmail()),
   onSubmitChangeEmail: values => dispatch(changeEmail(values)),
 });
 
-const ContactDetailsPage = compose(connect(mapStateToProps, mapDispatchToProps), withRouter)(
+const ContactDetailsPage = compose(connect(mapStateToProps, mapDispatchToProps))(
   ContactDetailsPageComponent
 );
 
diff --git a/src/containers/ContactDetailsPage/__snapshots__/ContactDetailsPage.test.js.snap b/src/containers/ContactDetailsPage/__snapshots__/ContactDetailsPage.test.js.snap
index 44084334..dbea9b03 100644
--- a/src/containers/ContactDetailsPage/__snapshots__/ContactDetailsPage.test.js.snap
+++ b/src/containers/ContactDetailsPage/__snapshots__/ContactDetailsPage.test.js.snap
@@ -2,6 +2,7 @@ exports[`ContactDetailsPage matches snapshot 1`] = `
 <Page
   authInfoError={null}
   logoutError={null}
+  scrollingDisabled={false}
   title="Contact details">
   <LayoutSideNavigation
     className={null}
@@ -10,29 +11,8 @@ exports[`ContactDetailsPage matches snapshot 1`] = `
     <TopbarWrapper
       className={null}
       rootClassName={null}>
-      <Topbar
-        authInProgress={false}
-        currentPage="ContactDetailsPage"
-        currentUser={null}
-        currentUserHasListings={false}
-        currentUserHasOrders={null}
-        history={
-          Object {
-            "push": [Function],
-          }
-        }
-        isAuthenticated={false}
-        location={
-          Object {
-            "search": "",
-          }
-        }
-        notificationCount={0}
-        onLogout={[Function]}
-        onManageDisableScrolling={[Function]}
-        onResendVerificationEmail={[Function]}
-        sendVerificationEmailError={null}
-        sendVerificationEmailInProgress={false} />
+      <Connect(withRouter(TopbarContainerComponent))
+        currentPage="ContactDetailsPage" />
       <UserNav
         className={null}
         rootClassName={null}