maverick/flex-template-web
1
0
Fork 0
mirror of https://github.com/kingomarnajjar/flex-template-web.git synced 2026-07-26 06:47:17 +10:00
Code Issues Projects Releases Packages Wiki Activity Actions

Menu needs to wait mounting to calculate dimensions reliably

Browse source
This commit is contained in:
Vesa Luusua 2019-05-22 12:54:15 +03:00
parent e01dfa0258
commit 740e2f24bc
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/components/Menu/Menu.js
View file

@ -38,7 +38,7 @@ class Menu extends Component {
constructor(props) {
super(props);
this.state = { isOpen: false };
this.state = { isOpen: false, ready: false };
const { isOpen, onToggleActive } = props;
const isIndependentMenu = isOpen === null && onToggleActive === null;
@ -60,6 +60,10 @@ class Menu extends Component {
this.menu = null;
this.menuContent = null;
}
componentDidMount() {
// Menu needs to know about DOM before it can calculate it's size proberly.
this.setState({ ready: true });
}
onBlur(event) {
// FocusEvent is fired faster than the link elements native click handler
@ -168,7 +172,7 @@ class Menu extends Component {
const { className, rootClassName } = this.props;
const rootClass = rootClassName || css.root;
const classes = classNames(rootClass, className);
const menuChildren = this.prepareChildren();
const menuChildren = this.state.ready ? this.prepareChildren() : null;
return (
<div