Merge pull request #1039 from sharetribe/fix-fieldbirthdayinput-placeholder

Fix fieldbirthdayinput placeholder
This commit is contained in:
Vesa Luusua 2019-03-06 11:35:13 +02:00 committed by GitHub
commit 2f27c3e8a7
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 3 deletions

View file

@ -14,6 +14,9 @@ way to update this template, but currently, we follow a pattern:
## Upcoming version 2019-XX-XX
- [fix] FieldBirthdayInput: placeholder text was not selected by default.
[#1039](https://github.com/sharetribe/flex-template-web/pull/1039)
## [v2.12.0] 2019-02-28
- [fix] Fix to PR [#1035](https://github.com/sharetribe/flex-template-web/pull/1035). In

View file

@ -155,7 +155,9 @@ class BirthdayInputComponent extends Component {
onBlur={() => this.handleSelectBlur()}
onChange={e => this.handleSelectChange('day', e.target.value)}
>
<option disabled>{datePlaceholder}</option>
<option disabled value="">
{datePlaceholder}
</option>
{days.map(d => (
<option key={d} value={d}>
{pad(d)}
@ -176,7 +178,9 @@ class BirthdayInputComponent extends Component {
onBlur={() => this.handleSelectBlur()}
onChange={e => this.handleSelectChange('month', e.target.value)}
>
<option disabled>{monthPlaceholder}</option>
<option disabled value="">
{monthPlaceholder}
</option>
{months.map(m => (
<option key={m} value={m}>
{pad(m)}
@ -197,7 +201,9 @@ class BirthdayInputComponent extends Component {
onBlur={() => this.handleSelectBlur()}
onChange={e => this.handleSelectChange('year', e.target.value)}
>
<option disabled>{yearPlaceholder}</option>
<option disabled value="">
{yearPlaceholder}
</option>
{years.map(y => (
<option key={y} value={y}>
{y}