Remove unnecessary Google Maps refs from docs and code comments

This commit is contained in:
Vesa Luusua 2018-09-14 16:02:37 +03:00
parent a3e1cde7c7
commit 2bf0500fdf
8 changed files with 15 additions and 12 deletions

View file

@ -2,9 +2,11 @@
# Mandatory configuration
#
REACT_APP_SHARETRIBE_SDK_CLIENT_ID=
REACT_APP_GOOGLE_MAPS_API_KEY=
REACT_APP_MAPBOX_ACCESS_TOKEN=
REACT_APP_STRIPE_PUBLISHABLE_KEY=
REACT_APP_MAPBOX_ACCESS_TOKEN=
# Or set up an alternative map provider (Google Maps). Check documentation.
# REACT_APP_GOOGLE_MAPS_API_KEY=
# Defaults
#

View file

@ -35,6 +35,7 @@ Documentation for specific topics can be found in the following files:
* [Customization guide](customization-guide.md)
* [Folder structure](folder-structure.md)
* [Integration to map providers](map-providers.md)
* [Translations](translations.md)
* [Styling a marketplace](styling.md)
* [Static pages](static-pages.md)
@ -49,7 +50,6 @@ Documentation for specific topics can be found in the following files:
* [Content Security Policy (CSP)](content-security-policy.md)
* [Original create-react-app documentation](https://github.com/sharetribe/create-react-app/blob/master/packages/react-scripts/template/README.md)
* [Customization checklist](customization-checklist.md)
* [Google Maps](google-maps.md)
* [Icons](icons.md)
The application was bootstrapped with a forked version of

View file

@ -5,7 +5,8 @@ them have defaults that work for development environment. For production deploys
| Variable | Description |
| ----------------------------------------- | ----------------------------------------------------------------------------------------------------------------- |
| REACT_APP_GOOGLE_MAPS_API_KEY | See: [Google Maps API key](./google-maps.md) |
| REACT_APP_MAPBOX_ACCESS_TOKEN | See: [Integrating to map providers](./map-providers.md) |
| REACT_APP_GOOGLE_MAPS_API_KEY | See: [Google Maps API key](./google-maps.md) (Alternative map provider) |
| REACT_APP_SHARETRIBE_SDK_CLIENT_ID | Client ID (API key). You will get this from the Sharetribe team. |
| REACT_APP_STRIPE_PUBLISHABLE_KEY | Stripe publishable API key for generating tokens with Stripe API. Use test key (prefix pk*test*) for development. |
| REACT_APP_SHARETRIBE_SDK_BASE_URL | The base url to access the Sharetribe Flex Marketplace API. |

View file

@ -42,8 +42,8 @@ After cloning the repo, your project should look like this:
## public/index.html
This is the page template. It includes fonts, Stripe SDK, Google Maps JavaScript API, and app icons.
It also specifies placeholders for tags generated by
This is the page template. It includes fonts, Stripe SDK, Mapbox API (and Google Maps JavaScript
API), and app icons. It also specifies placeholders for tags generated by
[React Helmet](https://github.com/nfl/react-helmet)
## src/

View file

@ -152,8 +152,8 @@ Then, in `render` method, you need to put `SearchMapWithGoogleMap` component int
props is already there in the comments:
```js
// Using Google Maps as map provider should use following component
// instead of SearchMapWithMapbox:
// When changing from default map provider to Google Maps, you should use the following
// component instead of SearchMapWithMapbox:
//
// <SearchMapWithGoogleMap
// containerElement={

View file

@ -141,8 +141,8 @@ export class SearchMapComponent extends Component {
this.setState({ mapReattachmentCount: window.mapReattachmentCount });
};
// Using Google Maps as map provider should use following component
// instead of SearchMapWithMapbox:
// When changing from default map provider to Google Maps, you should use the following
// component instead of SearchMapWithMapbox:
//
// <SearchMapWithGoogleMap
// containerElement={

View file

@ -1,4 +1,4 @@
// NOTE: renderdeep doesn't work due to Google Maps API integration
// NOTE: renderdeep doesn't work due to map integration
import React from 'react';
import { renderShallow } from '../../util/test-helpers';
import { fakeIntl } from '../../util/test-data';

View file

@ -1,4 +1,4 @@
// NOTE: renderdeep doesn't work due to Google Maps API integration
// NOTE: renderdeep doesn't work due to map integration
import React from 'react';
import { renderShallow } from '../../util/test-helpers';
import { fakeIntl } from '../../util/test-data';