maverick/flex-template-web
1
0
Fork 0
mirror of https://github.com/kingomarnajjar/flex-template-web.git synced 2026-07-28 03:43:28 +10:00
Code Issues Projects Releases Packages Wiki Activity Actions

Change filter param validation checks

Browse source 
Prefer validURLParamsForExtendedData over multiple calls to validURLParamForExtendedData when validating search filter query parameters.
This commit is contained in:
Hannu Lyytikainen 2018-04-12 16:00:56 +03:00
parent fc38342f75
commit 2ba05aa8f1
1 changed files with 5 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
src/containers/SearchPage/SearchPage.js
View file

@ -25,7 +25,6 @@ import { TopbarContainer } from '../../containers';
import { searchListings, searchMapListings, setActiveListing } from './SearchPage.duck';
import {
pickSearchParamsOnly,
validURLParamForExtendedData,
validURLParamsForExtendedData,
createSearchResultSchema,
} from './SearchPage.helpers';
@ -119,9 +118,9 @@ export class SearchPageComponent extends Component {
bounds: viewportBounds,
country,
mapSearch: true,
...validURLParamForExtendedData(CATEGORY_URL_PARAM, rest, customURLParamToConfig),
...validURLParamForExtendedData(AMENITIES_URL_PARAM, rest, customURLParamToConfig),
...validURLParamsForExtendedData(rest, customURLParamToConfig),
};
this.viewportBounds = viewportBounds;
history.push(
createResourceLocatorString('SearchPage', routeConfiguration(), {}, searchParams)
@ -169,25 +168,14 @@ export class SearchPageComponent extends Component {
// urlQueryParams doesn't contain page specific url params
// like mapSearch, page or origin (origin depends on config.sortSearchByDistance)
const urlQueryParams = pickSearchParamsOnly(
searchInURL,
customURLParamToConfig
);
const urlQueryParams = pickSearchParamsOnly(searchInURL, customURLParamToConfig);
// Page transition might initially use values from previous search
const urlQueryString = stringify(urlQueryParams);
const paramsQueryString = stringify(
pickSearchParamsOnly(
searchParams,
customURLParamToConfig
)
);
const paramsQueryString = stringify(pickSearchParamsOnly(searchParams, customURLParamToConfig));
const searchParamsAreInSync = urlQueryString === paramsQueryString;
const validQueryParams = validURLParamsForExtendedData(
searchInURL,
customURLParamToConfig
);
const validQueryParams = validURLParamsForExtendedData(searchInURL, customURLParamToConfig);
const isWindowDefined = typeof window !== 'undefined';
const isMobileLayout = isWindowDefined && window.innerWidth < MODAL_BREAKPOINT;