From 08952bc4fd7ffa93e83ac7eba482c70ef9fdb59e Mon Sep 17 00:00:00 2001 From: Kimmo Puputti Date: Mon, 3 Apr 2017 14:02:11 +0300 Subject: [PATCH] Fix React Router not updating routes https://github.com/ReactTraining/react-router/issues/4671 --- src/Routes.js | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/Routes.js b/src/Routes.js index 6eced264..42d7e48c 100644 --- a/src/Routes.js +++ b/src/Routes.js @@ -131,4 +131,10 @@ Routes.propTypes = { const mapStateToProps = state => ({ isAuthenticated: state.Auth.isAuthenticated }); -export default compose(connect(mapStateToProps), withRouter, withFlattenedRoutes)(Routes); +// Note: it is important that the withRouter HOC is **outside** the +// connect HOC, otherwise React Router won't rerender any Route +// components since connect implements a shouldComponentUpdate +// lifecycle hook. +// +// See: https://github.com/ReactTraining/react-router/issues/4671 +export default compose(withRouter, connect(mapStateToProps), withFlattenedRoutes)(Routes);