docbrown/spec
Daniel Uber 195b202d85
Use normal db transactions around tests (#13035)
* Use normal db transactions around tests

An unrelated spec failure was observed when this was run before
another test expecting the seed data to be present. It looks like the
specific pain point in https://github.com/forem/forem/pull/8865 was
around an rss reader spec (which is no longer in use) and I'd like to
try reverting this truncation behavior here.

The minimal failing test case I had on master was this

```
 rspec ./spec/system/dashboards/user_sorts_dashboard_articles_spec.rb:44  ./spec/lib/data_update_scripts/fix_profile_field_edge_cases_spec.rb
```

The find_by(attribute:...) in the edge case spec returned nil (since
there was no such profile field, the table had been truncated). Tests
pass locally so this might be fine to just leave on the defaults (if
that's the case the truncation support added in #8865 can also be
removed, this is the last caller).

* Reenable transactional feeds imports

rhymes pointed out that a second test uses this db_strategy and that's
the successor to the rss_feed_spec.rb that was the initial issue.

Attempt removal of the truncation strategy, and reenable the
transactional tests, for the feeds import.

* Remove database cleaner

Having removed the last use of it (in the feeds import spec) we no
longer need this gem.

* remove spec support for database cleaner
2021-03-18 12:56:55 -05:00
..
black_box Routine rubocop fixes (#10237) 2020-09-08 12:06:47 -04:00
decorators Improve cumulative layout shift on comment reactions + optimizations (#12309) 2021-01-18 19:29:44 -05:00
factories Add mobile push notifications to Forem (#12419) 2021-03-12 14:08:18 -06:00
fixtures Deployment Task: Update onboarding fields prior to #11629 (#11704) 2020-12-07 14:57:18 -05:00
generator Add service generator (#11265) 2020-11-10 09:09:35 +07:00
helpers Revert "Revert "Removed service worker (#12974)" (#13014)" (#13015) 2021-03-17 10:57:56 -04:00
initializers Fix regression in Honeybadger.config.exceptions.ignore (#12796) 2021-02-23 19:08:29 +01:00
lib [15-minute fix] Add ThrottledCall to DisplayAdEventsController (#12924) 2021-03-09 09:06:11 +07:00
liquid_tags improve keyboard accessibility of modals 12427 10610 (#12511) 2021-02-24 16:01:10 +00:00
mailers Email confirmation to abuse reports (#12557) 2021-02-03 22:59:50 +03:00
models Remove experimental /call functionality from Connect ✂️✂️✂️ (#12979) 2021-03-17 17:06:15 +01:00
policies Prevent banned users from using API (#12730) 2021-02-18 17:56:16 -05:00
queries/admin Add all new functionality for trusted (#10816) 2020-10-15 17:00:49 -04:00
refinements Update data exporter to handle admin send (#10274) 2020-10-26 18:00:56 -04:00
requests Get the correct episode by finding the given podcast's episodes (#13034) 2021-03-18 12:02:37 -04:00
routing Add mobile push notifications to Forem (#12419) 2021-03-12 14:08:18 -06:00
serializers/search [deploy] Refactor:Remove Reaction Search Code (#10377) 2020-09-23 12:27:50 -05:00
services Use normal db transactions around tests (#13035) 2021-03-18 12:56:55 -05:00
support Use normal db transactions around tests (#13035) 2021-03-18 12:56:55 -05:00
system Use normal db transactions around tests (#13035) 2021-03-18 12:56:55 -05:00
tasks Refactor:Send Welcome Broadcast Notifications From Sidekiq (#9923) 2020-08-21 12:57:08 -04:00
uploaders Bump carrierwave from 2.1.1 to 2.2.0 (#12802) 2021-02-25 10:53:25 +01:00
view_objects Enable Rubocop 0.89 cops and fix Lint/ violations (#9709) 2020-08-10 16:57:12 +02:00
views Update the UI for Low-Quality-Comments Notice (#12952) 2021-03-16 09:40:29 -04:00
workers [15-minute fix] Add ThrottledCall to DisplayAdEventsController (#12924) 2021-03-09 09:06:11 +07:00
rails_helper.rb Bump rubocop from 1.10.0 to 1.11.0 (#12848) 2021-03-01 14:34:13 +00:00
spec_helper.rb Manually load dotenv in test (#9971) 2020-08-24 20:19:03 +02:00