docbrown/spec/support
Suzanne Aitchison 5bed8f56d4
improve keyboard accessibility of modals 12427 10610 (#12511)
* adds focusTrap wrapper to preact Modal component

* add view specific code for focus trap in admin add nav link

* add script to return a focustrap toggle, use in add nav link modal partial

* add trap to edit nav link modal

* add handlers for sign up modal

* update modal controller for admin section, update nav link modals to use

* update other admin modals with new data values for trap

* remove unneeded erb script file

* remove unneeded target

* refactor to remove extra unneeded param

* remove duplicate code, store getFocusTrapToggle in window

* trap focus in comment and bookmark showModal instances for not logged in user

* remove need for activator id

* clean up id refs no longer needed

* remove custom code and re-use focsu-trap lib

* update storybook docs

* update default export in focusTrap

* prevent close button click triggering a modal toggle twice

* ensure if user navigates from a modal the trap is deactivated

* add jsdoc comments and add dynamic import

* ensure admin controller modal traps are cleaned up on disconnect

* update sign up modal to use crayons

* update modal controller and admin nav links modals to use preact modal

* update profile fields modals for new controller

* tweak styling of sign up and admin modals to match previous

* update listings modal to use crayons modal, adapt focus trap to work with click outside

* memoize deactivate callback to ensure modal can be presented on first page load

* add missed focustrap changes

* fix focus trap issues in onboarding flow

* refactor onboarding focus trap, remove getFocusTrapToggle

* tweaks for styling and article modal toggle

* add click outside tests to modal

* add cypress tests for the login modal

* update liquid tag tests affected by change

* refactors to address review comments

* fix issue with login modal presented twice on comment add

* change ids to selectors in admin modals

* small pr comment refactors

* add listings e2e tests

* add nav link modal tests

* fix issue with help modal

* tweak to fix ui bug from merge

* remove context from showLoginModal

* rename toggleModal

* rename state property for clarity

Co-authored-by: Nick Taylor <nick@dev.to>
2021-02-24 16:01:10 +00:00
..
fixtures Save Data Update Script errors to database and show them on http://localhost:3000/admin/data_update_scripts (#12348) 2021-01-21 14:48:34 +01:00
initializers Fix RSpec unit testing when using Docker dev setup (#10950) 2020-10-20 10:36:41 -04:00
seeds improve keyboard accessibility of modals 12427 10610 (#12511) 2021-02-24 16:01:10 +00:00
api_analytics_shared_examples.rb [deploy] Rubocop: fix violations of Layout/LineLength (#9197) 2020-07-08 08:36:36 -05:00
database_cleaner.rb Add data cleaning pre-test run to end to end tests (#12001) 2020-12-26 16:58:12 +01:00
elasticsearch_helpers.rb Flaky Spec Fixes: Dont Assume No Elasticsearch Data, Refresh before delete_by_query (#8354) 2020-06-09 07:55:28 -05:00
omniauth_helpers.rb Add Sign in with Apple (#11934) 2020-12-18 10:22:33 -06:00
runkit_tag_context.rb Fix Runkit tags not being activated when comment is added (#6767) 2020-05-15 14:27:46 +02:00
shared_context.rb Code cleanups (#659) 2018-08-07 11:00:13 -04:00
sidekiq_test_helpers.rb Add implicit points to follows to improve feed relevancy (in all algorithms) (#11513) 2020-11-25 16:09:51 -05:00
within_block_is_expected.rb Improve ArticlesController's authorization (#466) 2018-06-21 14:18:32 -04:00