ca6ba1af7d
* Removes collective_noun and collective_noun_disabled from app * Config Generalization: replaces community_qualified_name with community_name - Generalizes SiteConfig after the removal of collective_noun field - Updates copy where necessary to be readable with community_name - Makes the community_name SiteConfig description more explicit - Adds flexibility for Admins by removing appended "community" * Adds a data_update script to remove collective_noun and collective_noun_disabled * Removes appended community from stories_controller.rb * Removes unnecessary quotation marks around SiteConfig.community_name.to_s * Makes SiteConfig community_name description more explicit * Removes topic from #email_from and replaces arg with _ * Removes argument from #email_from (facepalm) * Reverts changes to application_mailer and notify_mailer_spec * Removes default "Community" topic from application_mailer and makes topic optional * Refactors #prepopulate_new_form to resolve Code Climate failures * Refactors #email_from even further by use of a ternary operator per review suggestion * Simplifies the data_update script used to remove collective_noun per review request * Adds a data_update script to append community to community_name * Updates data_update script to correctly append Community to community_name * Removes RemoveCollectiveNounFromConfig and updates other script * Removes superfluous false from data_update script * Updates data_update script to be more idiomatic
137 lines
4.4 KiB
Ruby
137 lines
4.4 KiB
Ruby
require "rails_helper"
|
|
|
|
RSpec.describe "ArticlesShow", type: :request do
|
|
let(:user) { create(:user) }
|
|
let(:article) { create(:article, user: user, published: true, organization: organization) }
|
|
let(:organization) { create(:organization) }
|
|
let(:doc) { Nokogiri::HTML(response.body) }
|
|
let(:text) { doc.at('script[type="application/ld+json"]').text }
|
|
let(:response_json) { JSON.parse(text) }
|
|
|
|
describe "GET /:slug (articles)" do
|
|
before do
|
|
allow(SiteConfig).to receive(:logo_png).and_return("logo.png")
|
|
get article.path
|
|
end
|
|
|
|
it "returns a 200 status when navigating to the article's page" do
|
|
expect(response).to have_http_status(:ok)
|
|
end
|
|
|
|
# rubocop:disable RSpec/ExampleLength
|
|
it "renders the proper JSON-LD for an article" do
|
|
expect(response_json).to include(
|
|
"@context" => "http://schema.org",
|
|
"@type" => "Article",
|
|
"mainEntityOfPage" => {
|
|
"@type" => "WebPage",
|
|
"@id" => URL.article(article)
|
|
},
|
|
"url" => URL.article(article),
|
|
"image" => [
|
|
ApplicationController.helpers.article_social_image_url(article, width: 1080, height: 1080),
|
|
ApplicationController.helpers.article_social_image_url(article, width: 1280, height: 720),
|
|
ApplicationController.helpers.article_social_image_url(article, width: 1600, height: 900),
|
|
],
|
|
"publisher" => {
|
|
"@context" => "http://schema.org",
|
|
"@type" => "Organization",
|
|
"name" => SiteConfig.community_name.to_s,
|
|
"logo" => {
|
|
"@context" => "http://schema.org",
|
|
"@type" => "ImageObject",
|
|
"url" => ApplicationController.helpers.optimized_image_url(SiteConfig.logo_png, width: 192,
|
|
fetch_format: "png"),
|
|
"width" => "192",
|
|
"height" => "192"
|
|
}
|
|
},
|
|
"headline" => article.title,
|
|
"author" => {
|
|
"@context" => "http://schema.org",
|
|
"@type" => "Person",
|
|
"url" => URL.user(user),
|
|
"name" => user.name
|
|
},
|
|
"datePublished" => article.published_timestamp,
|
|
"dateModified" => article.published_timestamp,
|
|
)
|
|
end
|
|
end
|
|
|
|
it "renders the proper organization for an article when one is present" do
|
|
get organization.path
|
|
expect(response_json).to include(
|
|
{
|
|
"@context" => "http://schema.org",
|
|
"@type" => "Organization",
|
|
"mainEntityOfPage" => {
|
|
"@type" => "WebPage",
|
|
"@id" => URL.organization(organization)
|
|
},
|
|
"url" => URL.organization(organization),
|
|
"image" => Images::Profile.call(organization.profile_image_url, length: 320),
|
|
"name" => organization.name,
|
|
"description" => organization.summary
|
|
},
|
|
)
|
|
end
|
|
# rubocop:enable RSpec/ExampleLength
|
|
|
|
context "when keywords are set" do
|
|
it "shows keywords" do
|
|
allow(SiteConfig).to receive(:meta_keywords).and_return({ article: "hello, world" })
|
|
article.update_column(:cached_tag_list, "super sheep")
|
|
get article.path
|
|
expect(response.body).to include('<meta name="keywords" content="super sheep, hello, world">')
|
|
end
|
|
end
|
|
|
|
context "when keywords are not" do
|
|
it "does not show keywords" do
|
|
allow(SiteConfig).to receive(:meta_keywords).and_return({ article: "" })
|
|
article.update_column(:cached_tag_list, "super sheep")
|
|
get article.path
|
|
expect(response.body).not_to include(
|
|
'<meta name="keywords" content="super sheep, hello, world">',
|
|
)
|
|
end
|
|
end
|
|
|
|
context "when user signed in" do
|
|
before do
|
|
sign_in user
|
|
get article.path
|
|
end
|
|
|
|
describe "GET /:slug (user)" do
|
|
it "does not render json ld" do
|
|
expect(response.body).not_to include "application/ld+json"
|
|
end
|
|
end
|
|
end
|
|
|
|
context "when user not signed in" do
|
|
before do
|
|
get article.path
|
|
end
|
|
|
|
describe "GET /:slug (user)" do
|
|
it "does not render json ld" do
|
|
expect(response.body).to include "application/ld+json"
|
|
end
|
|
end
|
|
end
|
|
|
|
context "when user not signed in but internal nav triggered" do
|
|
before do
|
|
get "#{article.path}?i=i"
|
|
end
|
|
|
|
describe "GET /:slug (user)" do
|
|
it "does not render json ld" do
|
|
expect(response.body).not_to include "application/ld+json"
|
|
end
|
|
end
|
|
end
|
|
end
|