No description
Find a file
Jeremy Friesen fbce226c08
Low Stakes Refactor of Feed class (#15180)
* Removing state change and unused method

Prior to this commit, the `@comment_weight` value would change.  This is
not ideal as depending on the call sequence, can notably change the
output.  I suspect this state change occurred so as to not alter an
underlying spec.

What this change does is remove the state change, removes a dead method,
renames a method (to the dead method name), and leverages
parameterization to better test a spec that was brittle based on
possible state changes.

I believe, from a logical stand point, that this change does not impact
the functionality nor the actual logic that is part of the production
call path.

* Marking methods as @api private

The goal is to highlight that we really shouldn't be calling these
outside of their contained class.  Ideally, I'd love to make them
private methods, but there are specs and would prefer to not use
`__send__` to change those specs.

This is a noop change.

* Renaming method to refelct returned param order

Prior to this commit the "default_home_feed_and_featured_story" returned
an array of `[featured_story, default_home_feed]`.  The method name and
the order of the returned values were misaligned.  This change helps
align the method name and the order of those returned values.

Note, methods such as `each_with_index` have an `element, index`
parameter order.
2021-10-26 09:57:33 -04:00
.buildkite Removes this dupe container block since we are going to run this pipeline (#11506) 2020-11-19 15:05:49 -06:00
.gems Bugfix for #7663 and refactor of container setup (#7747) 2020-05-28 12:11:51 -05:00
.github Remove @forem/sre from locales changes (#14985) 2021-10-07 17:17:13 -04:00
.husky [15 min fix] Updated husky package and configuration/pre-commit hook (#14346) 2021-07-27 15:39:00 -04:00
.vscode Added the MDX extension for VS Code. (#12816) 2021-02-25 10:22:18 +01:00
.yarn/releases Update to latest yarn version (#10441) 2020-09-28 13:24:35 -04:00
app Low Stakes Refactor of Feed class (#15180) 2021-10-26 09:57:33 -04:00
bin Parallelize cypress specs (#15142) 2021-10-22 12:41:56 -04:00
config Add back reaction translations (#15194) 2021-10-25 18:15:05 -04:00
cypress Podcasts fixes (#15130) 2021-10-22 11:06:11 +02:00
datadog Declare DD_VERSION in prerun.sh 2nd try (#13258) 2021-04-05 17:10:46 -04:00
db Allow users to choose their default Home and Tags-View Feed (Part 1) (#15128) 2021-10-20 18:02:59 -04:00
lib Modify capitalization of default navigation link (#14849) 2021-10-01 09:42:17 -04:00
log
public Make podcast-playback to be controllable via keyboard (#14139) 2021-08-20 12:45:53 +02:00
scripts Add real release version into the running code (#14870) 2021-10-04 09:35:20 -04:00
spec Low Stakes Refactor of Feed class (#15180) 2021-10-26 09:57:33 -04:00
vendor Bump omniauth-facebook from 8.0.0 to 9.0.0 (#15186) 2021-10-25 13:05:12 -06:00
.codeclimate.yml Upgrade to Ruby 3.0.2 (#12103) 2021-08-25 14:26:33 -04:00
.dockerignore Remove docs from repo ✂✂✂ (#14579) 2021-08-23 17:23:42 -04:00
.editorconfig
.env_sample When AWS_ID is the placeholder value, act as though AWS not setup (#13850) 2021-05-26 13:54:16 -05:00
.erb-lint.yml Upgrade Rails to 6.1.3.1 (#11333) 2021-04-05 10:39:48 -04:00
.eslintignore Remove non application files from frontend code coverage (#11752) 2020-12-04 20:00:20 -05:00
.eslintrc.js Disabled 'no default exports' rule for Storybook files and Stimulus controllers (#13032) 2021-03-17 21:29:39 -04:00
.gitattributes Enable union merges for translations (#15061) 2021-10-14 10:51:09 +07:00
.gitignore Add .pryrc to gitignore (#14844) 2021-09-28 18:03:02 +02:00
.gitpod.dockerfile Made GitHub CLI install permanent in Gitpod (#14787) 2021-09-21 15:27:39 -04:00
.gitpod.yml Gitpod improvements for initial load and persisting gems in container (#14764) 2021-09-21 10:32:22 -04:00
.nvmrc Update to use Node 14.x (#13136) 2021-03-29 11:27:20 -04:00
.postcssrc.yml
.prettierignore
.prettierrc.json Extracting prettier config (#10847) 2020-10-14 22:28:31 -04:00
.rspec [deploy] Spec Speedup: Use Knapsack to Run Parallel Builds (#8390) 2020-06-11 10:27:11 -05:00
.rubocop.yml Rubocop fixes (#14868) 2021-09-30 13:22:09 -04:00
.rubocop_todo.yml Make Rubocop happy again (#14729) 2021-09-14 09:15:01 -05:00
.ruby-version Upgrade to Ruby 3.0.2 (#12103) 2021-08-25 14:26:33 -04:00
.simplecov Remove resource_admin dashboards (Administrate) (#11792) 2020-12-08 12:38:13 -06:00
.slugignore Remove docs from repo ✂✂✂ (#14579) 2021-08-23 17:23:42 -04:00
.travis.yml Parallelize cypress specs (#15142) 2021-10-22 12:41:56 -04:00
.yardopts
.yarnclean Remove assets folder from .yarnclean (#13869) 2021-05-27 10:39:59 -04:00
.yarnrc Update to latest yarn version (#10441) 2020-09-28 13:24:35 -04:00
babel.config.js Profile generalization: cleanup (#12947) 2021-08-20 16:36:02 +02:00
CHANGELOG.md Add support for versioned releases (#13750) 2021-07-28 10:10:33 -04:00
CODE_OF_CONDUCT.md
config.ru Upgrade Rails to 6.1.3.1 (#11333) 2021-04-05 10:39:48 -04:00
container-compose.yml Remove Elasticsearch ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ (#13606) 2021-05-03 11:09:45 -04:00
Containerfile Upgrade to Ruby 3.0.2 (#12103) 2021-08-25 14:26:33 -04:00
CONTRIBUTING.md Fix broken links (#14588) 2021-08-24 16:59:56 -04:00
customJsDomEnvironment.js Bump jsdom from 16.7.0 to 18.0.0 (#15047) 2021-10-12 14:32:30 -06:00
cypress.dev.json Cleaning Test Runs for End to End (E2E) Tests (#12143) 2021-01-29 13:34:01 +01:00
cypress.json add retries for cypress ci tests (#14241) 2021-07-15 12:34:30 +01:00
docker-compose.yml Update docker-compose.yml file to permit login (#13792) 2021-05-24 20:03:36 -05:00
Dockerfile Bugfix for #7663 and refactor of container setup (#7747) 2020-05-28 12:11:51 -05:00
empty-module.js
Gemfile Bump omniauth-facebook from 8.0.0 to 9.0.0 (#15186) 2021-10-25 13:05:12 -06:00
Gemfile.lock Bump omniauth-facebook from 8.0.0 to 9.0.0 (#15186) 2021-10-25 13:05:12 -06:00
gitpod-init.sh Made GitHub CLI install permanent in Gitpod (#14787) 2021-09-21 15:27:39 -04:00
Guardfile Upgrade rubocop* packages to the latest version and fix violations (#11972) 2020-12-21 18:29:43 +01:00
jest.config.js Bump jsdom from 16.7.0 to 18.0.0 (#15047) 2021-10-12 14:32:30 -06:00
jsconfig.json Added the @components webpack alias to the project (#12808) 2021-02-24 16:07:48 +01:00
LICENSE.md
package.json Bump lint-staged from 11.2.3 to 11.2.4 (#15188) 2021-10-25 16:58:58 -04:00
postcss.config.js Suppress Postcss warnings & Re-enable Benhalpern deploy (#11521) 2020-11-20 11:27:49 -05:00
Procfile remove rake jobs:work references from code (#6082) [deploy] 2020-02-14 15:18:08 -05:00
Procfile.dev Adapt dev env to run on a remote box (#8232) 2020-06-18 13:01:49 +02:00
Procfile.dev-hot
Rakefile Remove fix-db-schema-conflicts gem (#12432) 2021-01-26 10:52:38 -05:00
README.md Remove rhymes from the Core Team (#15167) 2021-10-22 20:51:40 +02:00
release-tasks.sh Remove Elasticsearch ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ (#13606) 2021-05-03 11:09:45 -04:00
SECURITY.md [deploy] 🚀 Feature: Chat channel membership manager component (#8945) 2020-07-20 08:08:31 -04:00
svgo.config.js svgo: update configuration for 2.4 syntax (#14524) 2021-08-17 18:54:10 +02:00
testSetup.js workaround getComputedStyle issues in all jest tests (#14737) 2021-09-21 10:52:54 +01:00
yarn.lock Bump lint-staged from 11.2.3 to 11.2.4 (#15188) 2021-10-25 16:58:58 -04:00


Forem 🌱

For Empowering Community

ruby version rails version Travis Status for forem/forem Code Climate maintainability Code Climate technical debt CodeTriage badge Dependabot Badge GitPod badge Netlify badge GitHub code size in bytes GitHub commit activity GitHub issues ready for dev Honeybadger badge Knapsack Pro Parallel CI builds for dev.to

Welcome to the Forem codebase, the platform that powers dev.to. We are so excited to have you. With your help, we can build out Forems usability, scalability, and stability to better serve our communities.

What is Forem?

Forem is open source software for building communities. Communities for your peers, customers, fanbases, families, friends, and any other time and space where people need to come together to be part of a collective. See our announcement post for a high-level overview of what Forem is.

dev.to (or just DEV) is hosted by Forem. It is a community of software developers who write articles, take part in discussions, and build their professional profiles. We value supportive and constructive dialogue in the pursuit of great code and career growth for all members. The ecosystem spans from beginner to advanced developers, and all are welcome to find their place within our community. ❤️

Table of Contents

Community

For a place to have open discussions on features, voice your ideas, or get help with general questions please visit our community at forem.dev.

Contributing

We encourage you to contribute to Forem! Please check out the Contributing to Forem guide for guidelines about how to proceed.

Getting Started

This section provides a high-level quick start guide. If you're looking for a more thorough installation guide (for example with macOS, you'll want to refer to our complete Developer Documentation.

We run on a Rails backend, and we are currently transitioning to a Preact-first frontend.

A more complete overview of our stack is available in our docs.

Prerequisites

Local

Containers

Linux

OS X

Installation Documentation

Please see our installation guides, such as the one for macOS.

Developer Documentation

Check out our dedicated docs page for more technical documentation.

Core team

Vulnerability disclosure

Forem is the open source software which powers DEV.

We welcome security research on DEV under the terms of our vulnerability disclosure policy.

Acknowledgments

Thank you to the Twemoji project for the usage of their emojis.

License

This program is free software: you can redistribute it and/or modify it under the terms of the GNU Affero General Public License as published by the Free Software Foundation, either version 3 of the License, or (at your option) any later version. Please see the LICENSE file in our repository for the full text.

Like many open source projects, we require that contributors provide us with a Contributor License Agreement (CLA). By submitting code to the Forem project, you are granting us a right to use that code under the terms of the CLA.

Our version of the CLA was adapted from the Microsoft Contributor License Agreement, which they generously made available to the public domain under Creative Commons CC0 1.0 Universal.

Any questions, please refer to our license FAQ doc or email yo@dev.to.


Sloan, the sloth mascot
Happy Coding ❤️

⬆ Back to Top