c3c884f4d0
* WIP - Conditional rendering of "Create Post" link This PR builds on the conversation from forem/forem#17056 and moves in a slightly different direction. Important in all of this is that the ability to create a post is enforced on the server. If the "Create Post" button were to be visible but the user couldn't create a post when they clicked the button, they would get an authorization error (or some such response). This PR posits a different and perhaps competing approach to forem/forem#16606. This PR provides a general approach in which we add class attributes in our HTML erb files. Note: I have not included Cypress tests as I don't want to yet commit that time. I'm also wondering if this is the "right" thing to do. I definitely think we want to add some JS tests. But could we do JS and unit tests? (How do we reach consensus regarding our test approach?) Again, thank you for the conversation and expect an even more "complete" PR after we have our discussion. * Extracting AsyncInfo model to ease testing * Renaming forbidden to visible * Adding cypress test to assert no 'Create Post' These are always treacherous. What happens when we rename the button? The test will continue to work. * Apply suggestions from code review Co-authored-by: Suzanne Aitchison <suzanne@forem.com> * Switching to pack file for policy Follows on [Suzanne's comment](https://github.com/forem/forem/pull/17076#issuecomment-1088567286) * Update app/javascript/packs/applyApplicationPolicyToggles.js Co-authored-by: Suzanne Aitchison <suzanne@forem.com> Co-authored-by: Suzanne Aitchison <suzanne@forem.com> |
||
|---|---|---|
| .. | ||
| fixtures | ||
| integration | ||
| plugins | ||
| support | ||
| util | ||
| .eslintrc.js | ||
| jsconfig.json | ||