* This change abstracts the DatadogStatsClient into a ForemStatsClient. The purpose of this abstraction is to set the foundation for a subsequent PR that will allow one to use New Relic for recording Forem stats, instead of Datadog, if there is a New Relic configuration found. This specific change creates an abstraction layer that can be built upon, without changing any actual default behavior. All specs still pass. * Use delegate instead of explicit methods. * Delegate instead of explicit methods. * Fix the error. * Refactor according to the suggestions in the comments. * Ooops. Stats work better when all of the code is committed. * Removing the alias of count to increment since that was done in error.
182 lines
7.2 KiB
Ruby
182 lines
7.2 KiB
Ruby
require "rails_helper"
|
|
|
|
RSpec.describe Payments::Customer, type: :service do
|
|
let(:customer) { Stripe::Customer.create }
|
|
|
|
before do
|
|
StripeMock.start
|
|
end
|
|
|
|
after do
|
|
StripeMock.stop
|
|
end
|
|
|
|
describe ".get" do
|
|
it "retrieves an existing customer" do
|
|
expect(described_class.get(customer.id)).to be_present
|
|
end
|
|
|
|
it "raises Payments::CustomerNotFoundError if the customer does not exist" do
|
|
expect { described_class.get("foobar") }.to raise_error(Payments::InvalidRequestError)
|
|
end
|
|
|
|
it "increments stripe.errors if the customer does not exist" do
|
|
allow(ForemStatsClient).to receive(:increment)
|
|
|
|
expect { described_class.get("foobar") }.to raise_error(Payments::InvalidRequestError)
|
|
tags = hash_including(tags: array_including("error:InvalidRequestError"))
|
|
expect(ForemStatsClient).to have_received(:increment).with("stripe.errors", tags)
|
|
end
|
|
|
|
it "raises Payments::PaymentsError for any other known error" do
|
|
allow(Stripe::Customer).to receive(:retrieve).with("foobar").and_raise(Stripe::StripeError)
|
|
expect { described_class.get("foobar") }.to raise_error(Payments::PaymentsError)
|
|
end
|
|
|
|
it "increments stripe.errors for any other known error" do
|
|
allow(ForemStatsClient).to receive(:increment)
|
|
allow(Stripe::Customer).to receive(:retrieve).with("foobar").and_raise(Stripe::StripeError)
|
|
|
|
expect { described_class.get("foobar") }.to raise_error(Payments::PaymentsError)
|
|
tags = hash_including(tags: array_including("error:StripeError"))
|
|
expect(ForemStatsClient).to have_received(:increment).with("stripe.errors", tags)
|
|
end
|
|
end
|
|
|
|
describe ".create" do
|
|
it "creates a new customer" do
|
|
expect(described_class.create).to be_present
|
|
end
|
|
|
|
it "raises an error if anything in the params is invalid" do
|
|
error = Stripe::InvalidRequestError.new("message", :email)
|
|
allow(Stripe::Customer).to receive(:create).and_raise(error)
|
|
expect { described_class.create(email: "foobar") }.to raise_error(Payments::InvalidRequestError)
|
|
end
|
|
|
|
it "raises Payments::PaymentsError for any other known error" do
|
|
allow(Stripe::Customer).to receive(:create).with(email: "foobar")
|
|
.and_raise(Stripe::StripeError)
|
|
expect { described_class.create(email: "foobar") }.to raise_error(Payments::PaymentsError)
|
|
end
|
|
end
|
|
|
|
describe ".create_source" do
|
|
it "creates a new source" do
|
|
customer = Stripe::Customer.create
|
|
expect(described_class.create_source(customer.id, "token")).to be_present
|
|
end
|
|
|
|
it "raises an error if anything in the params is invalid" do
|
|
error = Stripe::InvalidRequestError.new("message", :token)
|
|
allow(Stripe::Customer).to receive(:create_source).and_raise(error)
|
|
expect { described_class.create_source("customer_id", "token") }.to raise_error(Payments::InvalidRequestError)
|
|
end
|
|
|
|
it "increments stripe.errors if anything in the params is invalid" do
|
|
error = Stripe::InvalidRequestError.new("message", :token)
|
|
allow(Stripe::Customer).to receive(:create_source).and_raise(error)
|
|
allow(ForemStatsClient).to receive(:increment)
|
|
|
|
expect { described_class.create_source("customer_id", "token") }.to raise_error(Payments::InvalidRequestError)
|
|
tags = hash_including(tags: array_including("error:InvalidRequestError"))
|
|
expect(ForemStatsClient).to have_received(:increment).with("stripe.errors", tags)
|
|
end
|
|
|
|
it "raises Payments::PaymentsError for any other known error" do
|
|
allow(Stripe::Customer).to receive(:create_source).and_raise(Stripe::StripeError)
|
|
expect { described_class.create_source("customer_id", "token") }.to raise_error(Payments::PaymentsError)
|
|
end
|
|
|
|
it "increments stripe.errors for any other known error" do
|
|
allow(Stripe::Customer).to receive(:create_source).and_raise(Stripe::StripeError)
|
|
allow(ForemStatsClient).to receive(:increment)
|
|
|
|
expect { described_class.create_source("customer_id", "token") }.to raise_error(Payments::PaymentsError)
|
|
tags = hash_including(tags: array_including("error:StripeError"))
|
|
expect(ForemStatsClient).to have_received(:increment).with("stripe.errors", tags)
|
|
end
|
|
end
|
|
|
|
describe ".get_source" do
|
|
it "gets an existing source" do
|
|
source = Stripe::Customer.create_source(customer.id, source: "token")
|
|
|
|
expect(described_class.get_source(customer, source.id)).to be_present
|
|
end
|
|
|
|
it "raises Payments::InvalidRequestError if the source does not exist" do
|
|
expect { described_class.get_source(customer, "token") }.to raise_error(Payments::InvalidRequestError)
|
|
end
|
|
|
|
it "raises Payments::PaymentsError for any other known error" do
|
|
allow(customer).to receive(:sources).and_raise(Stripe::StripeError)
|
|
|
|
expect { described_class.get_source(customer, "token") }.to raise_error(Payments::PaymentsError)
|
|
end
|
|
end
|
|
|
|
describe ".detach_source" do
|
|
it "removes an existing source" do
|
|
source = Stripe::Customer.create_source(customer.id, source: "token")
|
|
|
|
expect(described_class.detach_source(customer.id, source.id).deleted).to be(true)
|
|
end
|
|
|
|
it "raises Payments::InvalidRequestError if the source does not exist" do
|
|
expect { described_class.detach_source(customer.id, "token") }.to raise_error(Payments::InvalidRequestError)
|
|
end
|
|
|
|
it "raises Payments::PaymentsError for any other known error" do
|
|
allow(Stripe::Customer).to receive(:detach_source).and_raise(Stripe::StripeError)
|
|
|
|
expect { described_class.detach_source(customer.id, "token") }.to raise_error(Payments::PaymentsError)
|
|
end
|
|
end
|
|
|
|
describe ".charge" do
|
|
let(:stripe_helper) { StripeMock.create_test_helper }
|
|
|
|
it "charges a customer" do
|
|
charge = described_class.charge(customer: customer, amount: 1, description: "Test charge")
|
|
expect(charge).to be_present
|
|
end
|
|
|
|
it "charges a customer with an explicit card id" do
|
|
token = stripe_helper.generate_card_token
|
|
card = Stripe::Customer.create_source(customer.id, source: token)
|
|
charge = described_class.charge(
|
|
customer: customer, amount: 1, description: "Test charge", card_id: card.id,
|
|
)
|
|
expect(charge).to be_present
|
|
end
|
|
|
|
it "raises a card error if the card has any troubles" do
|
|
StripeMock.prepare_card_error(:expired_card)
|
|
|
|
token = stripe_helper.generate_card_token
|
|
card = Stripe::Customer.create_source(customer.id, source: token)
|
|
|
|
expect do
|
|
described_class.charge(
|
|
customer: customer, amount: 1, description: "Test charge", card_id: card.id,
|
|
)
|
|
end.to raise_error(Payments::CardError)
|
|
end
|
|
|
|
it "increments stripe.errors if the card has any troubles" do
|
|
StripeMock.prepare_card_error(:expired_card)
|
|
allow(ForemStatsClient).to receive(:increment)
|
|
|
|
customer = Stripe::Customer.create
|
|
token = stripe_helper.generate_card_token
|
|
card = Stripe::Customer.create_source(customer.id, source: token)
|
|
|
|
expect do
|
|
described_class.charge(customer: customer, amount: 1, description: "Test charge", card_id: card.id)
|
|
end.to raise_error(Payments::CardError)
|
|
tags = hash_including(tags: array_including("error:CardError"))
|
|
expect(ForemStatsClient).to have_received(:increment).with("stripe.errors", tags)
|
|
end
|
|
end
|
|
end
|