ed74f2f245
* This change abstracts the DatadogStatsClient into a ForemStatsClient. The purpose of this abstraction is to set the foundation for a subsequent PR that will allow one to use New Relic for recording Forem stats, instead of Datadog, if there is a New Relic configuration found. This specific change creates an abstraction layer that can be built upon, without changing any actual default behavior. All specs still pass. * Use delegate instead of explicit methods. * Delegate instead of explicit methods. * Fix the error. * Refactor according to the suggestions in the comments. * Ooops. Stats work better when all of the code is committed. * Removing the alias of count to increment since that was done in error.
54 lines
2.5 KiB
Ruby
54 lines
2.5 KiB
Ruby
require "rails_helper"
|
|
|
|
RSpec.describe FastlyConfig::Snippets, type: :service do
|
|
let(:fastly) { instance_double Fastly }
|
|
let(:fastly_version) { instance_double Fastly::Version }
|
|
let(:fastly_snippet) { instance_double Fastly::Snippet }
|
|
let(:snippets_config) { described_class.new(fastly, fastly_version) }
|
|
|
|
it "determines if an update is needed" do
|
|
allow(fastly_version).to receive(:number).and_return(1)
|
|
allow(fastly).to receive(:get_snippet).and_return(fastly_snippet)
|
|
allow(fastly_snippet).to receive(:content).and_return("some VCL")
|
|
expect(snippets_config.update_needed?).to be true
|
|
end
|
|
|
|
describe "upsert_config" do
|
|
it "creates a new snippet if one isn't found" do
|
|
allow(fastly_version).to receive(:number).and_return(1)
|
|
allow(fastly).to receive(:get_snippet).and_return(nil)
|
|
allow(fastly).to receive(:create).and_return(fastly_snippet)
|
|
allow(fastly_snippet).to receive(:name).and_return("test")
|
|
snippets_config.update(fastly_version)
|
|
expect(fastly).to have_received(:create).at_least(:once)
|
|
end
|
|
|
|
it "updates a snippet if one is found" do
|
|
allow(fastly_version).to receive(:number).and_return(1)
|
|
allow(fastly).to receive(:get_snippet).and_return(fastly_snippet)
|
|
allow(fastly_snippet).to receive(:content).and_return("test")
|
|
allow(fastly_snippet).to receive(:content=).and_return("test")
|
|
allow(fastly_snippet).to receive(:save!).and_return(fastly_snippet)
|
|
allow(fastly_snippet).to receive(:name).and_return("test")
|
|
snippets_config.update(fastly_version)
|
|
expect(fastly_snippet).to have_received(:save!).at_least(:once)
|
|
end
|
|
|
|
it "logs success messages" do
|
|
allow(ForemStatsClient).to receive(:increment)
|
|
allow(fastly_version).to receive(:number).and_return(1)
|
|
allow(fastly).to receive(:get_snippet).and_return(fastly_snippet)
|
|
allow(fastly_snippet).to receive(:content).and_return("test")
|
|
allow(fastly_snippet).to receive(:content=).and_return("test")
|
|
allow(fastly_snippet).to receive(:save!).and_return(fastly_snippet)
|
|
allow(fastly_snippet).to receive(:name).and_return("test")
|
|
|
|
snippets_config.update(fastly_version)
|
|
|
|
tags = hash_including(tags: array_including("snippet_update_type:update", "snippet_name:test",
|
|
"new_version:#{fastly_version.number}"))
|
|
|
|
expect(ForemStatsClient).to have_received(:increment).with("fastly.snippets", tags).at_least(:once)
|
|
end
|
|
end
|
|
end
|