maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
docbrown/spec/services/articles/feeds
History
Jeremy Friesen 2b3f4e1342
Refactoring cached_followed_tags (#16175) 
* Refactoring cached_followed_tags

This refactor consolidates two queries and a loop into a single query.

One thing that is unclear is if we're ever really clearing the cache of
the user by id?

What follows is un-related to the refactor but appears to be related to #14937.

> First, I see we set a cache here:
>
> ebdaaaf15b/app/decorators/user_decorator.rb (L23-L34)
>
> But when I look at what busts the user cache, it doesn’t look like we’re busting it for the above cached location:
>
> ebdaaaf15b/app/services/edge_cache/bust_user.rb (L3-L22)
>
> What if anything am I missing in regards to cache busting?

* Adding some deprecated methods

* Updating documentation

* Bump for travis

* Bump for travis

* Updating comments to fix confusion

NOTE: I might be introducing more confusion, but at least
I'm addressing the prior confusion.

* Bump for travis

* Updating so we don't cache ActiveRecord objects

* Selecting only applicable attributes for caching

* Apply suggestions from code review

Co-authored-by: Michael Kohl <citizen428@forem.com>

* Adjusting code based on feedback

* Bump for travis

* Bump for travis

* Update app/decorators/user_decorator.rb

Co-authored-by: Michael Kohl <citizen428@forem.com>

Co-authored-by: Michael Kohl <citizen428@forem.com>
2022-01-24 19:53:48 -05:00
..
article_score_calculator_for_user_spec.rb Extracting a common calculator for feed weights (#15199) 2021-10-27 04:45:53 -04:00
basic_spec.rb Refactoring cached_followed_tags (#16175) 2022-01-24 19:53:48 -05:00
find_featured_story_spec.rb Parameterizing featured story requiring main image (#15333) 2021-11-18 16:28:58 -05:00
large_forem_experimental_spec.rb Move system tests (#16077) 2022-01-18 08:08:41 -06:00
latest_spec.rb Spelling (#15702) 2021-12-07 06:59:10 -07:00
tag_spec.rb Clean up feed-related code (#14707) 2021-09-17 09:23:32 +07:00
timeframe_spec.rb Clean up feed-related code (#14707) 2021-09-17 09:23:32 +07:00
weighted_query_strategy_spec.rb Refactor AB Experiments and exercise all variants in rspec (#16236) 2022-01-24 17:03:58 -05:00