docbrown/spec/requests/buffer_updates_spec.rb
Fabbri Paolo 89e893f157 Fix rubocop detected offenses (#4552)
* Run Inspecting 1050 files
....................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C.....................................................................................................................................................................................................................................................................................................

Offenses:

spec/models/article_spec.rb:195:7: C: RSpec/NestedGroups: Maximum example group nesting exceeded [4/3]. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/NestedGroups)
      context "when description is empty" do
      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

1050 files inspected, 1 offense detected to fix autofixable errors

* Refactor  to correct test

it was braking the rule RSpec/NestedGroups: Maximum example group nesting exceeded [4/3]. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/NestedGroups)

* Run `rubocop --auto-gen-config` to regenrate `.rubocop_todo.yml`
2019-10-24 11:53:03 -04:00

94 lines
3.5 KiB
Ruby

require "rails_helper"
RSpec.describe "BufferUpdates", type: :request do
let(:user) { create(:user) }
let(:mod_user) { create(:user) }
let(:article) { create(:article, user_id: user.id) }
let(:mod_article) { create(:article, user_id: mod_user.id) }
let(:comment) { create(:comment, user_id: user.id, commentable_id: article.id) }
context "when trusted user is logged in" do
before do
sign_in mod_user
mod_user.add_role(:trusted)
end
it "creates buffer update for tweet if tweet params are passed" do
post "/buffer_updates",
params:
{ buffer_update: { body_text: "This is the text!!!!", tag_id: "javascript", article_id: article.id } }
expect(BufferUpdate.all.size).to eq(2)
expect(BufferUpdate.last.body_text).to start_with("This is the text!!!!")
expect(BufferUpdate.last.status).to eq("pending")
end
it "creates buffer update with link" do
post "/buffer_updates",
params:
{ buffer_update: { body_text: "This is the text!!!!", tag_id: "javascript", article_id: article.id } }
expect(BufferUpdate.first.body_text).to include(article.path)
end
it "creates buffer hashtag" do
post "/buffer_updates",
params:
{ buffer_update: { body_text: "This is the text!!!!", tag_id: "javascript", article_id: article.id } }
expect(BufferUpdate.first.body_text).to include("#DEVCommunity")
end
it "creates satellite and Facebook buffer" do
article.update_column(:cached_tag_list, "ruby, rails, meta")
create(:tag, name: "rails")
tag = create(:tag, buffer_profile_id_code: "placeholder", name: "ruby")
post "/buffer_updates",
params:
{ buffer_update: { body_text: "This is the text!!!!", tag_id: "javascript", article_id: article.id } }
expect(BufferUpdate.all.size).to eq(3)
expect(BufferUpdate.second.tag_id).to eq(tag.id)
expect(BufferUpdate.last.social_service_name).to eq("facebook")
end
end
context "when non-trusted user is logged in" do
before do
sign_in user
mod_user.add_role(:trusted)
end
it "rejects buffer update for non-trusted user" do
expect do
post "/buffer_updates",
params:
{ buffer_update: { body_text: "This is the text!!!!", tag_id: "javascript", article_id: mod_article.id } }
end.to raise_error(Pundit::NotAuthorizedError)
end
it "accepts buffer update from author of article" do
post "/buffer_updates",
params:
{ buffer_update: { body_text: "This is the text!!!!", tag_id: "javascript", article_id: article.id } }
expect(BufferUpdate.first.body_text).to include(article.path)
end
end
# it "updates last buffered at" do
# post "/internal/buffer_updates",
# params:
# { social_channel: "main_twitter", article_id: article.id, tweet: "Hello this is a test" }
# expect(article.reload.last_buffered).not_to eq(nil)
# end
# it "updates last buffered at with satellite buffer" do
# post "/internal/buffer_updates",
# params:
# { social_channel: "satellite_twitter", article_id: article.id, tweet: "Hello this is a test" }
# expect(article.reload.last_buffered).not_to eq(nil)
# end
# it "updates last facebook buffered at" do
# post "/internal/buffer_updates",
# params:
# { social_channel: "facebook", article_id: article.id, tweet: "Hello this is a test" }
# expect(article.reload.facebook_last_buffered).not_to eq(nil)
# end
end