docbrown/app/services/notifications/new_comment/send.rb
Molly Struve e87dead7ad
Use new UserSetting and UserNotificationSettings and Ignore Related User Table Fields (#14121)
* schema file undelete description

* feat: v1 of the script

* Flesh out remaining enums under their categories

* complete UsersSettings data update script

* complete DUS for relevant attributes in users and profiles tables

* complete DUS for users_notification_settings

* alphabetize user_settings sql file

* safeguard against null values for "null: false" settings

* Set up actual UsersSettings DUS and specs files

* fix broken DUS script

* complete specs for UsersSetting DUS

* Address QA of specs

* complete specs for users_notification_settings DUS

* fix the typos (thanks Julianna!)

* begin implementation

* still building

* add missing attribute "email_membership_newsletter"

* complete sync code (except race condition for user profile)

* complete implementation, remains tests

* Address PR review and fix Travis fails

* remove superfluous Profile.new

* fix travis fails

* feat: update the users_notification_setting attributes from the user model

* feat: use the config fonts enums to display the fonts

* feat: loop through the keys

* fix profile = nil blowing up; add specs for notification_setting model

* remove unneeded spec

* remove feed validation until after sync code removed; fixes feed_import spec failures

* remove spec associated with feed_url validation in user_setting model

* fix failing spec 😅

* add TODO

* feat: set the user settings in the user controller  and use it in the customization form

* feat: move some update logic to the users settings controller thats being used from customization

* feat: show the updated values form the users_settingd and not the user instance

* Generalize redirect back to current tab

* still trying to reflect changed theme upon refresh

* customizations take effect on refresh

* remove 'with_feed' scope from user model

Co-authored-by: Jamie Gaskins <jamie@forem.com>

* start with takeover for fields previously in profiles table

* Takeover code for `publishing_from_rss` section in Settings (#13914)

* implement takeover code part 1

* implement takeover code

* fix feed fetch

* need rhymes help

* complete implementation; specs pending

* fix STUPID omission that caused so many headaches 😫

* implement profile fields pointing to users_settings 🎉

* run migrations

* implement inbox type & guidelines takeover code; specs pending (#13911)

* Point changes in notification settings to `users_notification_settings` table (#13910)

* implement takeover code; remains specs

* address PR feedback; remove related sync code

* address PR review feedback

* need help with routing and specs

* address pr review

* addressing pr review

* Treat implementation edge cases and omissions 😅

* fix uncommented comment

* fixing implementation cases

* address more PR review feedback

* fixing notifications use-cases

* refactor settings controller

* more pr review changes

* solving bugs

* fix broken onboarding

* handle eperience_level calls

* more fixes

* remove unneeded mappings

* add To-dos for quety updates

* remove done TODO

* purge done TODOs

* update notification_settings-related queries

* start fixing specs

* fixing specs

* fix notification and lrg_forem specs

* fixing broken specs

* still fixing

* fix line dif and remove reloads from user.rb

* run specs

* silence bullet and other fixes

* remove setting migration scripts and specs, fix more settings for specs

* handle missing user for article builder and fix notification specs

* fix some final controller specs and re-add incorrectly removed specs

* remove deprecated data update scripts and related workers, put travis back

* refactor admin tags mods controller, write/move specs for users notifications settings controller

* schema cleanup and other small refactors for consistency

* set field we can invalidate in spec via active record instead of at the db level

* remove I think an uneccessary hook call from subscribe_to_mailchimp_newsletter

* use bnefore_create to setup settings, please dont blow up the test suite

* mailchimp bot fix

* remove decorator in favor of single model method

Co-authored-by: Arit Amana <msarit@gmail.com>
Co-authored-by: Ridhwana <ridhwana.khan16@gmail.com>
Co-authored-by: Arit Amana <32520970+msarit@users.noreply.github.com>
Co-authored-by: Jamie Gaskins <jamie@forem.com>
2021-07-08 09:31:34 -05:00

94 lines
2.5 KiB
Ruby

# send notifications about the new comment
module Notifications
module NewComment
class Send
def initialize(comment)
@comment = comment
end
delegate :user_data, :comment_data, to: Notifications
def self.call(...)
new(...).call
end
def call
return if comment.score.negative?
user_ids = Set.new(comment_user_ids + subscribed_user_ids + top_level_user_ids + author_subscriber_user_ids)
user_ids.delete(comment.user_id)
json_data = {
user: user_data(comment.user),
comment: comment_data(comment)
}
user_ids.each do |user_id|
Notification.create(
user_id: user_id,
notifiable_id: comment.id,
notifiable_type: comment.class.name,
action: nil,
json_data: json_data,
)
end
# Send PNs using Rpush - respecting users' notificaton delivery settings
targets = User.joins(:notification_setting)
.where(notification_setting: { mobile_comment_notifications: true }).ids
PushNotifications::Send.call(
user_ids: targets,
title: "@#{comment.user.username}",
body: "Re: #{comment.parent_or_root_article.title.strip}",
payload: {
url: URL.url(comment.path),
type: "new comment"
},
)
return unless comment.commentable.organization_id
Notification.create(
organization_id: comment.commentable.organization_id,
notifiable_id: comment.id,
notifiable_type: comment.class.name,
action: nil,
json_data: json_data,
)
# no push notifications for organizations yet
end
private
attr_reader :comment
def user_ids_for(config_name)
NotificationSubscription
.where(notifiable_id: comment.commentable_id, notifiable_type: "Article", config: config_name)
.pluck(:user_id)
end
def comment_user_ids
comment.ancestors.where(receive_notifications: true).pluck(:user_id)
end
def subscribed_user_ids
user_ids_for("all_comments")
end
def top_level_user_ids
return [] if comment.ancestry.present?
user_ids_for("top_level_comments")
end
def author_subscriber_user_ids
return [] if comment.user_id != comment.commentable.user_id
user_ids_for("only_author_comments")
end
end
end
end