e626cfa933
* feat: define the different social media handles * feat: dynamically render all the social media fields * feat: ensure that the social media handles are permitter and dealt in a separate path from the rest * test: update social_networks_handle to social_media_handles * feat: update the sidebar to use different social media * feat: update the twitter:site meta handle to be SiteConfig.social_media_handles["twitter"] * feat: update the a links to tweets * feat: make the links dynamic and only show those that there is a value for * refactor: make @ThePracticalDev dynamic * refactor: make @ThePracticalDev dynamic * feat: add dynamic social media handles * chore: rename values * chore: remove extra social handles * chore: some spacing * chore: remove lines * rafector: user rails-settings-cached type: :hash to set the type and the defaults * feat: use nil and blank instead of "" and empty * chore: move the social media handles into the right box * refactor: rearrange model placement based on the UI * chore: code climate * refactor: comments from PR * chore: rename the ff * chore: amended twitter username * chore: add a temporary rake task * feat: update names * chore: why am i using the old syntax :( * chore: revert dynamic erb variable in offline.html
261 lines
12 KiB
Ruby
261 lines
12 KiB
Ruby
require "rails_helper"
|
|
|
|
RSpec.describe "/internal/config", type: :request do
|
|
let_it_be(:user) { create(:user) }
|
|
let_it_be(:admin) { create(:user, :super_admin) }
|
|
let_it_be(:admin_plus_config) { create(:user, :super_plus_single_resource_admin, resource: Config) }
|
|
let_it_be(:confirmation_message) { "My username is @#{admin_plus_config.username} and this action is 100% safe and appropriate." }
|
|
|
|
describe "POST internal/events as a user" do
|
|
before do
|
|
sign_in(user)
|
|
end
|
|
|
|
it "bars the regular user to access" do
|
|
expect { post "/internal/config", params: {} }.to raise_error(Pundit::NotAuthorizedError)
|
|
end
|
|
end
|
|
|
|
# rubocop:disable RSpec/NestedGroups
|
|
describe "POST internal/events" do
|
|
context "when admin has typical admin permissions but not single resource" do
|
|
before do
|
|
sign_in(admin)
|
|
end
|
|
|
|
it "does not allow user to update config if they have proper confirmation" do
|
|
expected_image_url = "https://dummyimage.com/300x300"
|
|
expect { post "/internal/config", params: { site_config: { favicon_url: expected_image_url }, confirmation: confirmation_message } }.to raise_error Pundit::NotAuthorizedError
|
|
end
|
|
|
|
it "does not allow user to update config if they do not have proper confirmation" do
|
|
expected_image_url = "https://dummyimage.com/300x300"
|
|
expect { post "/internal/config", params: { site_config: { favicon_url: expected_image_url }, confirmation: "Not proper" } }.to raise_error Pundit::NotAuthorizedError
|
|
end
|
|
end
|
|
|
|
context "when admin has full permissions including single resource" do
|
|
before do
|
|
sign_in(admin_plus_config)
|
|
end
|
|
|
|
describe "content" do
|
|
it "updates the community_description" do
|
|
description = "Hey hey #{rand(100)}"
|
|
post "/internal/config", params: { site_config: { community_description: description }, confirmation: confirmation_message }
|
|
expect(SiteConfig.community_description).to eq(description)
|
|
end
|
|
|
|
it "updates the community_member_description" do
|
|
description = "Hey hey #{rand(100)}"
|
|
post "/internal/config", params: { site_config: { community_member_description: description }, confirmation: confirmation_message }
|
|
expect(SiteConfig.community_member_description).to eq(description)
|
|
end
|
|
|
|
it "updates the tagline" do
|
|
description = "Hey hey #{rand(100)}"
|
|
post "/internal/config", params: { site_config: { tagline: description }, confirmation: confirmation_message }
|
|
expect(SiteConfig.tagline).to eq(description)
|
|
end
|
|
end
|
|
|
|
describe "staff" do
|
|
it "does not allow the staff_user_id to be updated" do
|
|
expect(SiteConfig.staff_user_id).to eq(1)
|
|
post "/internal/config", params: { site_config: { staff_user_id: 2 }, confirmation: confirmation_message }
|
|
expect(SiteConfig.staff_user_id).to eq(1)
|
|
end
|
|
|
|
it "updates default_site_email" do
|
|
expected_email = "foo@bar.com"
|
|
post "/internal/config", params: { site_config: { default_site_email: expected_email },
|
|
confirmation: confirmation_message }
|
|
expect(SiteConfig.default_site_email).to eq(expected_email)
|
|
end
|
|
|
|
it "updates social_media_handles" do
|
|
expected_handle = {"facebook"=>"tpd", "github"=>"", "instagram"=>"", "twitch"=>"", "twitter"=>""}
|
|
post "/internal/config", params: { site_config: { social_media_handles: expected_handle },
|
|
confirmation: confirmation_message }
|
|
expect(SiteConfig.social_media_handles[:facebook]).to eq("tpd")
|
|
expect(SiteConfig.social_media_handles[:github]).to eq("")
|
|
end
|
|
end
|
|
|
|
describe "mascot" do
|
|
it "updates the mascot_user_id" do
|
|
expected_mascot_user_id = 2
|
|
post "/internal/config", params: { site_config: { mascot_user_id: expected_mascot_user_id }, confirmation: confirmation_message }
|
|
expect(SiteConfig.mascot_user_id).to eq(expected_mascot_user_id)
|
|
end
|
|
end
|
|
|
|
describe "images" do
|
|
it "updates main_social_image" do
|
|
expected_image_url = "https://dummyimage.com/300x300"
|
|
post "/internal/config", params: { site_config: { main_social_image: expected_image_url }, confirmation: confirmation_message }
|
|
expect(SiteConfig.main_social_image).to eq(expected_image_url)
|
|
end
|
|
|
|
it "updates favicon_url" do
|
|
expected_image_url = "https://dummyimage.com/300x300"
|
|
post "/internal/config", params: { site_config: { favicon_url: expected_image_url }, confirmation: confirmation_message }
|
|
expect(SiteConfig.favicon_url).to eq(expected_image_url)
|
|
end
|
|
|
|
it "updates logo_png" do
|
|
expected_image_url = "https://dummyimage.com/300x300"
|
|
post "/internal/config", params: { site_config: { logo_png: expected_image_url }, confirmation: confirmation_message }
|
|
expect(SiteConfig.logo_png).to eq(expected_image_url)
|
|
end
|
|
|
|
it "updates logo_svg" do
|
|
expected_image_url = "https://dummyimage.com/300x300"
|
|
post "/internal/config", params: { site_config: { logo_svg: expected_image_url }, confirmation: confirmation_message }
|
|
expect(SiteConfig.logo_svg).to eq(expected_image_url)
|
|
end
|
|
|
|
it "updates primary_sticker_image_url" do
|
|
expected_image_url = "https://dummyimage.com/300x300"
|
|
post "/internal/config", params: { site_config: { primary_sticker_image_url: expected_image_url }, confirmation: confirmation_message }
|
|
expect(SiteConfig.primary_sticker_image_url).to eq(expected_image_url)
|
|
end
|
|
|
|
it "updates mascot_image_url" do
|
|
expected_image_url = "https://dummyimage.com/300x300"
|
|
post "/internal/config", params: { site_config: { mascot_image_url: expected_image_url }, confirmation: confirmation_message }
|
|
expect(SiteConfig.mascot_image_url).to eq(expected_image_url)
|
|
end
|
|
|
|
it "updates mascot_image_description" do
|
|
description = "Hey hey #{rand(100)}"
|
|
post "/internal/config", params: { site_config: { mascot_image_description: description }, confirmation: confirmation_message }
|
|
expect(SiteConfig.mascot_image_description).to eq(description)
|
|
end
|
|
|
|
it "rejects update without proper confirmation" do
|
|
expected_image_url = "https://dummyimage.com/300x300"
|
|
expect { post "/internal/config", params: { site_config: { logo_svg: expected_image_url }, confirmation: "Incorrect yo!" } }.to raise_error Pundit::NotAuthorizedError
|
|
end
|
|
end
|
|
|
|
describe "rate limits" do
|
|
it "updates rate_limit_follow_count_daily" do
|
|
expect do
|
|
post "/internal/config", params: { site_config: { rate_limit_follow_count_daily: 3 }, confirmation: confirmation_message }
|
|
end.to change(SiteConfig, :rate_limit_follow_count_daily).from(500).to(3)
|
|
end
|
|
|
|
it "updates rate_limit_comment_creation" do
|
|
expect do
|
|
post "/internal/config", params: { site_config: { rate_limit_comment_creation: 3 }, confirmation: confirmation_message }
|
|
end.to change(SiteConfig, :rate_limit_comment_creation).from(9).to(3)
|
|
end
|
|
|
|
it "updates rate_limit_published_article_creation" do
|
|
expect do
|
|
post "/internal/config", params: { site_config: { rate_limit_published_article_creation: 3 }, confirmation: confirmation_message }
|
|
end.to change(SiteConfig, :rate_limit_published_article_creation).from(9).to(3)
|
|
end
|
|
|
|
it "updates rate_limit_image_upload" do
|
|
expect do
|
|
post "/internal/config", params: { site_config: { rate_limit_image_upload: 3 }, confirmation: confirmation_message }
|
|
end.to change(SiteConfig, :rate_limit_image_upload).from(9).to(3)
|
|
end
|
|
|
|
it "updates rate_limit_email_recipient" do
|
|
expect do
|
|
post "/internal/config", params: { site_config: { rate_limit_email_recipient: 3 }, confirmation: confirmation_message }
|
|
end.to change(SiteConfig, :rate_limit_email_recipient).from(5).to(3)
|
|
end
|
|
end
|
|
|
|
describe "Google Analytics Reporting API v4" do
|
|
it "updates ga_view_id" do
|
|
post "/internal/config", params: { site_config: { ga_view_id: "abc" }, confirmation: confirmation_message }
|
|
expect(SiteConfig.ga_view_id).to eq("abc")
|
|
end
|
|
|
|
it "updates ga_fetch_rate" do
|
|
post "/internal/config", params: { site_config: { ga_fetch_rate: 3 }, confirmation: confirmation_message }
|
|
expect(SiteConfig.ga_fetch_rate).to eq(3)
|
|
end
|
|
end
|
|
|
|
describe "Mailchimp lists IDs" do
|
|
it "updates mailchimp_newsletter_id" do
|
|
post "/internal/config", params: { site_config: { mailchimp_newsletter_id: "abc" }, confirmation: confirmation_message }
|
|
expect(SiteConfig.mailchimp_newsletter_id).to eq("abc")
|
|
end
|
|
|
|
it "updates mailchimp_sustaining_members_id" do
|
|
post "/internal/config", params: { site_config: { mailchimp_sustaining_members_id: "abc" }, confirmation: confirmation_message }
|
|
expect(SiteConfig.mailchimp_sustaining_members_id).to eq("abc")
|
|
end
|
|
|
|
it "updates mailchimp_tag_moderators_id" do
|
|
post "/internal/config", params: { site_config: { mailchimp_tag_moderators_id: "abc" }, confirmation: confirmation_message }
|
|
expect(SiteConfig.mailchimp_tag_moderators_id).to eq("abc")
|
|
end
|
|
|
|
it "updates mailchimp_community_moderators_id" do
|
|
post "/internal/config", params: { site_config: { mailchimp_community_moderators_id: "abc" }, confirmation: confirmation_message }
|
|
expect(SiteConfig.mailchimp_community_moderators_id).to eq("abc")
|
|
end
|
|
end
|
|
|
|
describe "Email digest frequency" do
|
|
it "updates periodic_email_digest_max" do
|
|
post "/internal/config", params: { site_config: { periodic_email_digest_max: 1 }, confirmation: confirmation_message }
|
|
expect(SiteConfig.periodic_email_digest_max).to eq(1)
|
|
end
|
|
|
|
it "updates periodic_email_digest_min" do
|
|
post "/internal/config", params: { site_config: { periodic_email_digest_min: 3 }, confirmation: confirmation_message }
|
|
expect(SiteConfig.periodic_email_digest_min).to eq(3)
|
|
end
|
|
|
|
it "rejects update without proper confirmation" do
|
|
expect { post "/internal/config", params: { site_config: { periodic_email_digest_min: 6 }, confirmation: "Incorrect yo!" } }.to raise_error Pundit::NotAuthorizedError
|
|
expect(SiteConfig.periodic_email_digest_min).not_to eq(6)
|
|
end
|
|
end
|
|
|
|
describe "Tags" do
|
|
it "removes space suggested_tags" do
|
|
post "/internal/config", params: { site_config: { suggested_tags: "hey, haha,hoho, bobo fofo" }, confirmation: confirmation_message }
|
|
expect(SiteConfig.suggested_tags).to eq(%w[hey haha hoho bobofofo])
|
|
end
|
|
|
|
it "downcases suggested_tags" do
|
|
post "/internal/config", params: { site_config: { suggested_tags: "hey, haha,hoHo, Bobo Fofo" }, confirmation: confirmation_message }
|
|
expect(SiteConfig.suggested_tags).to eq(%w[hey haha hoho bobofofo])
|
|
end
|
|
|
|
it "removes space sidebar_tags" do
|
|
post "/internal/config", params: { site_config: { sidebar_tags: "hey, haha,hoho, bobo fofo" }, confirmation: confirmation_message }
|
|
expect(SiteConfig.sidebar_tags).to eq(%w[hey haha hoho bobofofo])
|
|
end
|
|
|
|
it "downcases sidebar_tags" do
|
|
post "/internal/config", params: { site_config: { sidebar_tags: "hey, haha,hoHo, Bobo Fofo" }, confirmation: confirmation_message }
|
|
expect(SiteConfig.sidebar_tags).to eq(%w[hey haha hoho bobofofo])
|
|
end
|
|
end
|
|
|
|
describe "Authentication" do
|
|
it "removes space authentication_providers" do
|
|
post "/internal/config", params: { site_config: { authentication_providers: "github, twitter" }, confirmation: confirmation_message }
|
|
expect(SiteConfig.authentication_providers).to eq(%w[github twitter])
|
|
end
|
|
|
|
it "downcases authentication_providers" do
|
|
post "/internal/config", params: { site_config: { authentication_providers: "GitHub, Twitter" }, confirmation: confirmation_message }
|
|
expect(SiteConfig.authentication_providers).to eq(%w[github twitter])
|
|
end
|
|
end
|
|
end
|
|
end
|
|
# rubocop:enable RSpec/NestedGroups
|
|
end
|