docbrown/app/views/comments
Julien Maury a2677cc0a9
Remove defer attributes from inline scripts - gist embeds (#13407)
* replace inline attribute defer with external js - show.html.erb

* fix typo in filename

* disable no-undef and bail if not defined

* put js on subfolder utilities

* refactor jsx instead of loading chunk with defer

* fix typo in desc

* better name for global gist helper

* use InstantClick

* working script on preview AND single view, not dynamic import, though

* embed only if gists

* combine all approaches to make dynamic import work

* make gist embeds work on submit comment form

* make gist embeds work on preview comment

* refactor - preview comments and submit

* add pack editComment + helper embedGistsInComments

* comment gist helper

* delete useless file utility

* use new syntax for events

* put code in method embedGistsInComments

* delete older pack gist

* handle edge case 'view full discussion'

* resolve conflict with package ibm-openapi-validator

* resolve conflict with package husky

* empty commit to test random error travis

* better name for class dismiss

* handle future events submit

* delete test code on click toggle form

* delete unused file

* rename pack as js file, not jsx

* Added POC using MutationObserver.

* missing case: notification page

* use custom pack notification page

* add e2e test for comment with embed gist

* add e2e test for preview post with embed gist

* add an extra step in tests to check gist is present

Co-authored-by: Nick Taylor <nick@dev.to>
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
2021-06-11 08:22:50 +01:00
..
_comment.html.erb Comments UI update (#11283) 2020-11-18 18:21:19 -05:00
_comment.json.jbuilder [deploy] Reintroduce sticky_nav changes (ab81f36 & 7f92855) (#10263) 2020-09-09 15:33:13 -04:00
_comment_avatar.html.erb Add loading=lazy to image tags (#10888) 2021-05-27 19:01:21 +02:00
_comment_date.erb Publicly indicate if someone edits their comments (#10524) 2021-03-02 09:47:25 +07:00
_comment_footer.html.erb Create DiscussionLocks (#13905) 2021-06-10 11:04:33 -04:00
_comment_header.html.erb Optimise dropdowns for accessibility - Post comments and share (#13868) 2021-06-03 09:13:17 +01:00
_comment_proper.html.erb Update the UI for Low-Quality-Comments Notice (#12952) 2021-03-16 09:40:29 -04:00
_comment_quality_marker.html.erb Update the UI for Low-Quality-Comments Notice (#12952) 2021-03-16 09:40:29 -04:00
_discussion_lock_reason.html.erb Create DiscussionLocks (#13905) 2021-06-10 11:04:33 -04:00
_form.html.erb Remove defer attributes from inline scripts - gist embeds (#13407) 2021-06-11 08:22:50 +01:00
_liquid.html.erb Remove social icons from comment liquid tag (#11186) 2020-11-02 09:57:08 -05:00
delete_confirm.html.erb Comments UI update (#11283) 2020-11-18 18:21:19 -05:00
deleted_commentable_comment.html.erb Rename SiteConfig to Settings::General (#13573) 2021-05-21 14:45:37 +02:00
edit.html.erb Remove defer attributes from inline scripts - gist embeds (#13407) 2021-06-11 08:22:50 +01:00
index.html.erb Remove defer attributes from inline scripts - gist embeds (#13407) 2021-06-11 08:22:50 +01:00
index.json.jbuilder Initial commit 2018-02-28 16:11:08 -05:00
new.html.erb Fix linting issues in app/views/comments (#1853) [ci skip] 2019-02-25 13:03:31 -05:00
settings.html.erb Comments UI update (#11283) 2020-11-18 18:21:19 -05:00