docbrown/app/models/profile_field.rb
Daniel Uber afa214ac52
Require profile fields to belong to a group (#16390)
* Require profile fields to belong to a group

Remove the empty group dropdown from the group select tag

Remove the optional: true from the belongs_to validation (raise a
validation error on save if the group is not provided)

Update test to remove belongs_to's optional setting

* Update ProfileFields::Add spec to include profile field group

* update factory to ensure a non-empty profile field group

* Add required profile field group to seeded profile fields

Since profile field is required, create was failing (silently).

Add required field so these are available in e2e tests.

* Use factory `association` to create a profile field group

https://github.com/thoughtbot/factory_bot/blob/master/GETTING_STARTED.md#explicit-definition

* provide required profile field group when posting data

* Fix one spec, drop another

Both of these scripts will be removed in the other branch (changing
the attribute name) - dropping the test here seems lower trouble than
modifying an out of data data update script to pass.

* skip test slated for removal

Similar to the last commit - this test exercises a script about to be
archived in the other branch.
2022-02-15 09:27:18 -06:00

43 lines
1.3 KiB
Ruby

class ProfileField < ApplicationRecord
WORD_REGEX = /\b\w+\b/
HEADER_FIELD_LIMIT = 3
HEADER_LIMIT_MESSAGE = "maximum number of header fields (#{HEADER_FIELD_LIMIT}) exceeded".freeze
# Key names follow the Rails form helpers
enum input_type: { text_field: 0, text_area: 1 }
enum display_area: { header: 0, left_sidebar: 1 }
belongs_to :profile_field_group
validates :attribute_name, presence: true, on: :update
validates :display_area, presence: true
validates :input_type, presence: true
validates :label, presence: true, uniqueness: { case_sensitive: false }
validates :show_in_onboarding, inclusion: { in: [true, false] }
validate :maximum_header_field_count
before_create :generate_attribute_name
private
def generate_attribute_name
self.attribute_name = label.titleize.scan(WORD_REGEX).join.underscore
end
def maximum_header_field_count
return unless header?
header_field_count = self.class.header.count
# We need to have less than the maximum number so we can still create one.
if new_record? || display_area_was == "left_sidebar"
return if header_field_count < HEADER_FIELD_LIMIT
# We can change existing fields or update them as long as we're within the limit.
elsif header_field_count <= HEADER_FIELD_LIMIT
return
end
errors.add(:display_area, HEADER_LIMIT_MESSAGE)
end
end