maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
docbrown/app/controllers
History
Jacob Herrington 45e45491b1
Migrate "static" profile fields into new columns (#13641) 
* Move static profile fields to profiles columns

In order to remove some ambiguity around the availability of certain
profile fields, we can designate certain fields as "static." These
fields are intended to exist on every Forem regardless of configuration;
they contain basic personal info that most Forem's will likely use.

Because these fields already exist on some Forems it is necessary to
migrate the data from existing profile's data column to their respective
columns.

This change should behave as expected irrespective of the existence of
the static fields having associated ProfileFields, however, the UI that
is rendered in a user's settings still depends on the presence of the
ProfileFields. We can address that in a future change when we are
prepared to delete those ProfileFields entirely. We should make sure the
migration occurs without issue before moving to that step, in my
opinion.

* Apply suggestions from code review

Co-authored-by: Michael Kohl <me@citizen428.net>

* Add clarifying comments

Co-authored-by: Michael Kohl <me@citizen428.net>

Co-authored-by: Michael Kohl <me@citizen428.net>
2021-05-26 14:40:18 -05:00
..
admin Rename SiteConfig to Settings::General (#13573) 2021-05-21 14:45:37 +02:00
api/v0 Rename SiteConfig to Settings::General (#13573) 2021-05-21 14:45:37 +02:00
concerns Rename SiteConfig to Settings::General (#13573) 2021-05-21 14:45:37 +02:00
incoming_webhooks Rename SiteConfig to Settings::General (#13573) 2021-05-21 14:45:37 +02:00
notifications
oauth
stories Extract tag stories to tag articles controller (#13457) 2021-05-24 13:44:43 -04:00
api_secrets_controller.rb Rename SiteConfig to Settings::General (#13573) 2021-05-21 14:45:37 +02:00
application_controller.rb Rename SiteConfig to Settings::General (#13573) 2021-05-21 14:45:37 +02:00
application_metal_controller.rb
article_approvals_controller.rb
articles_controller.rb Split Settings::UserExperience (#13495) 2021-04-28 13:29:25 +07:00
async_info_controller.rb Rename SiteConfig to Settings::General (#13573) 2021-05-21 14:45:37 +02:00
badges_controller.rb
chat_channel_memberships_controller.rb Fix "possible unprotected redirect" warning (#10511) 2020-12-29 14:54:34 -05:00
chat_channels_controller.rb Rename SiteConfig to Settings::General (#13573) 2021-05-21 14:45:37 +02:00
collections_controller.rb Fix Bug: Series index page showing series with 0 articles -#9658 (#11227) 2020-11-03 09:10:46 +01:00
comments_controller.rb Rename SiteConfig to Settings::General (#13573) 2021-05-21 14:45:37 +02:00
confirmations_controller.rb Rename SiteConfig to Settings::General (#13573) 2021-05-21 14:45:37 +02:00
credits_controller.rb Rename SiteConfig to Settings::General (#13573) 2021-05-21 14:45:37 +02:00
dashboards_controller.rb Remove pro role + expose analytics to all users via dashboard (#13156) 2021-03-30 15:02:18 -07:00
deep_links_controller.rb Rename SiteConfig to Settings::General (#13573) 2021-05-21 14:45:37 +02:00
devices_controller.rb Have specs run without Redis and refactor ConsumerApp and Device (#13647) 2021-05-07 08:03:16 +02:00
display_ad_events_controller.rb [15-minute fix] Add ThrottledCall to DisplayAdEventsController (#12924) 2021-03-09 09:06:11 +07:00
email_authorizations_controller.rb
email_subscriptions_controller.rb Split Settings::Community from SiteConfig (#13403) 2021-04-26 10:46:35 +02:00
events_controller.rb
feedback_messages_controller.rb [15-min-fix] Better feedback messaging (#13254) 2021-04-12 09:05:45 -04:00
followings_controller.rb
follows_controller.rb Fix UI showing "Following" after unfollowing a user (#13757) 2021-05-19 17:40:38 +01:00
ga_events_controller.rb Rename SiteConfig to Settings::General (#13573) 2021-05-21 14:45:37 +02:00
github_repos_controller.rb Fix Ruby 2.7 kwargs' warnings & misc spec warnings (#13256) 2021-04-06 16:57:59 -04:00
html_variant_successes_controller.rb
html_variant_trials_controller.rb
image_uploads_controller.rb [deploy] Store Article's main_image path unprocessed (#10867) 2020-10-16 14:46:37 -04:00
invitations_controller.rb Part One: Fix Users Stuck in a "Created" but "Unregistered" State (#10882) 2020-10-19 16:51:31 -04:00
liquid_embeds_controller.rb
liquid_tags_controller.rb [deploy] Add LiquidTagsController (#10241) 2020-09-08 12:07:33 -04:00
listings_controller.rb Fixing missing category in listing modal (#11301) 2020-11-06 12:29:20 -05:00
messages_controller.rb [deploy] Include APP_NAME in Pusher channels (#10001) 2020-08-31 08:28:46 -04:00
moderations_controller.rb Bug Fix:Remove Score Filter From Tag Mod Index (#11599) 2020-11-24 14:18:14 -06:00
notification_subscriptions_controller.rb Rename unidiomatic methods (#13328) 2021-04-09 10:59:56 -05:00
notifications_controller.rb
omniauth_callbacks_controller.rb Rename banned and comment_banned roles (#12270) 2021-04-06 10:12:14 -05:00
onboardings_controller.rb
open_search_controller.rb [deploy] Remove need for ENV vars during asset precompile (#10349) 2020-09-16 13:57:05 -04:00
organizations_controller.rb Asynchronous organization delete (#13388) 2021-04-19 18:30:35 +03:00
page_views_controller.rb Extract page view updates into workers (#12686) 2021-02-17 09:24:05 +07:00
pages_controller.rb [15-Minute Fix] Refactor code smells (#13347) 2021-04-21 14:52:32 -05:00
passwords_controller.rb Verify current password on password change (#12174) 2021-01-21 12:40:54 +07:00
podcast_episodes_controller.rb Remove unused podcast episode related code (#12642) 2021-02-10 17:47:39 +01:00
podcasts_controller.rb
poll_skips_controller.rb
poll_votes_controller.rb
pro_accounts_controller.rb
profile_field_groups_controller.rb Add ProfileFieldGroupsController to API (#10124) 2020-09-03 10:12:53 +07:00
profile_pins_controller.rb Refactor cache purging (#12811) 2021-03-02 10:09:05 -05:00
profiles_controller.rb Migrate "static" profile fields into new columns (#13641) 2021-05-26 14:40:18 -05:00
pusher_controller.rb [deploy] Include APP_NAME in Pusher channels (#10001) 2020-08-31 08:28:46 -04:00
rating_votes_controller.rb
reactions_controller.rb
reading_list_items_controller.rb [deploy] Fix Reading List Counter Without last_reacted_at Default (#10933) 2020-10-19 13:26:19 -05:00
registrations_controller.rb Rename SiteConfig to Settings::General (#13573) 2021-05-21 14:45:37 +02:00
response_templates_controller.rb
search_controller.rb Rename SiteConfig to Settings::General (#13573) 2021-05-21 14:45:37 +02:00
service_worker_controller.rb Revert "Revert "Removed service worker (#12974)" (#13014)" (#13015) 2021-03-17 10:57:56 -04:00
shell_controller.rb Reduce service worker functionality to minimal offline page (#12834) 2021-03-01 19:29:26 -05:00
sidebars_controller.rb Split Settings::Campaign from SiteConfig (#13238) 2021-04-19 10:01:03 +07:00
sitemaps_controller.rb
social_previews_controller.rb
stories_controller.rb Migrate "static" profile fields into new columns (#13641) 2021-05-26 14:40:18 -05:00
stripe_active_cards_controller.rb Abstract DatadogStatsClient to ForemStatsClient (#12304) 2021-01-27 11:25:44 -05:00
tag_adjustments_controller.rb Fix new Rubocop violations (#10808) 2020-10-20 09:28:53 -04:00
tags_controller.rb Rename SiteConfig to Settings::General (#13573) 2021-05-21 14:45:37 +02:00
user_blocks_controller.rb
user_subscriptions_controller.rb
users_controller.rb Rename SiteConfig to Settings::General (#13573) 2021-05-21 14:45:37 +02:00
video_states_controller.rb Rename SiteConfig to Settings::General (#13573) 2021-05-21 14:45:37 +02:00
videos_controller.rb Rubocop: Enable and fix Style/StringConcatenation (#9844) 2020-08-18 14:50:15 +02:00