docbrown/app/views/notifications
Julien Maury a2677cc0a9
Remove defer attributes from inline scripts - gist embeds (#13407)
* replace inline attribute defer with external js - show.html.erb

* fix typo in filename

* disable no-undef and bail if not defined

* put js on subfolder utilities

* refactor jsx instead of loading chunk with defer

* fix typo in desc

* better name for global gist helper

* use InstantClick

* working script on preview AND single view, not dynamic import, though

* embed only if gists

* combine all approaches to make dynamic import work

* make gist embeds work on submit comment form

* make gist embeds work on preview comment

* refactor - preview comments and submit

* add pack editComment + helper embedGistsInComments

* comment gist helper

* delete useless file utility

* use new syntax for events

* put code in method embedGistsInComments

* delete older pack gist

* handle edge case 'view full discussion'

* resolve conflict with package ibm-openapi-validator

* resolve conflict with package husky

* empty commit to test random error travis

* better name for class dismiss

* handle future events submit

* delete test code on click toggle form

* delete unused file

* rename pack as js file, not jsx

* Added POC using MutationObserver.

* missing case: notification page

* use custom pack notification page

* add e2e test for comment with embed gist

* add e2e test for preview post with embed gist

* add an extra step in tests to check gist is present

Co-authored-by: Nick Taylor <nick@dev.to>
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
2021-06-11 08:22:50 +01:00
..
shared Expand @-mention functionality to posts (#13367) 2021-05-12 07:33:33 -07:00
_aggregated_reactions.html.erb Bugfix: Remove focus from avatars in notifications for better keyboard navigation (#11650) 2020-12-03 08:11:20 -05:00
_article.html.erb Expand @-mention functionality to posts (#13367) 2021-05-12 07:33:33 -07:00
_badgeachievement.html.erb [15 Min Fix]: Fix template error in badge achievement notification view (#13186) 2021-03-30 10:45:37 -07:00
_broadcast.html.erb Notifications fixes (#11180) 2020-10-30 14:52:58 +01:00
_comment.html.erb Notifications redesign (#11084) 2020-10-29 20:38:17 +01:00
_follow.html.erb Add loading=lazy to image tags (#10888) 2021-05-27 19:01:21 +02:00
_mention.html.erb Expand @-mention functionality to posts (#13367) 2021-05-12 07:33:33 -07:00
_milestone.html.erb Notifications redesign (#11084) 2020-10-29 20:38:17 +01:00
_nav_menu.html.erb Fix layout shift on active crayons-tabs change. (#13300) 2021-05-12 11:45:36 -04:00
_notifications_list.html.erb Notifications redesign (#11084) 2020-10-29 20:38:17 +01:00
_reaction.html.erb Notifications redesign (#11084) 2020-10-29 20:38:17 +01:00
_single_reaction.html.erb Move app/labor/reaction_image.rb to helper (#11678) 2020-12-01 14:15:30 +07:00
_tagadjustment.html.erb Notifications fixes (#11180) 2020-10-30 14:52:58 +01:00
index.html.erb Remove defer attributes from inline scripts - gist embeds (#13407) 2021-06-11 08:22:50 +01:00