docbrown/spec/requests/user/user_show_spec.rb
Michael Kohl ce523ad58b
[15 minute fix] Remove disambiguatingDescription from user profile (#12861)
* Remove disambiguatingDescription from user profile

* Fix spec
2021-03-03 08:42:46 +07:00

102 lines
2.8 KiB
Ruby

require "rails_helper"
RSpec.describe "UserShow", type: :request do
let!(:profile) do
create(
:profile,
:with_DEV_info,
user: create(:user, :without_profile),
display_email_on_profile: true,
)
end
let(:user) { profile.user }
describe "GET /:slug (user)" do
it "returns a 200 status when navigating to the user's page" do
get user.path
expect(response).to have_http_status(:ok)
end
# rubocop:disable RSpec/ExampleLength
it "renders the proper JSON-LD for a user" do
get user.path
text = Nokogiri::HTML(response.body).at('script[type="application/ld+json"]').text
response_json = JSON.parse(text)
expect(response_json).to include(
"@context" => "http://schema.org",
"@type" => "Person",
"mainEntityOfPage" => {
"@type" => "WebPage",
"@id" => URL.user(user)
},
"url" => URL.user(user),
"sameAs" => [
"https://twitter.com/#{user.twitter_username}",
"https://github.com/#{user.github_username}",
"http://example.com",
],
"image" => Images::Profile.call(user.profile_image_url, length: 320),
"name" => user.name,
"email" => user.email,
"jobTitle" => user.employment_title,
"description" => user.summary,
"worksFor" => [
{
"@type" => "Organization",
"name" => user.employer_name,
"url" => user.employer_url
},
],
"alumniOf" => user.education,
)
end
# rubocop:enable RSpec/ExampleLength
it "does not render a key if no value is given" do
incomplete_user = create(:user)
get incomplete_user.path
text = Nokogiri::HTML(response.body).at('script[type="application/ld+json"]').text
response_json = JSON.parse(text)
expect(response_json).not_to include("worksFor")
expect(response_json.value?(nil)).to be(false)
expect(response_json.value?("")).to be(false)
end
end
context "when user signed in" do
before do
sign_in user
get user.path
end
describe "GET /:slug (user)" do
it "does not render json ld" do
expect(response.body).not_to include "application/ld+json"
end
end
end
context "when user not signed in" do
before do
get user.path
end
describe "GET /:slug (user)" do
it "does not render json ld" do
expect(response.body).to include "application/ld+json"
end
end
end
context "when user not signed in but internal nav triggered" do
before do
get "#{user.path}?i=i"
end
describe "GET /:slug (user)" do
it "does not render json ld" do
expect(response.body).not_to include "application/ld+json"
end
end
end
end