ca6ba1af7d
* Removes collective_noun and collective_noun_disabled from app * Config Generalization: replaces community_qualified_name with community_name - Generalizes SiteConfig after the removal of collective_noun field - Updates copy where necessary to be readable with community_name - Makes the community_name SiteConfig description more explicit - Adds flexibility for Admins by removing appended "community" * Adds a data_update script to remove collective_noun and collective_noun_disabled * Removes appended community from stories_controller.rb * Removes unnecessary quotation marks around SiteConfig.community_name.to_s * Makes SiteConfig community_name description more explicit * Removes topic from #email_from and replaces arg with _ * Removes argument from #email_from (facepalm) * Reverts changes to application_mailer and notify_mailer_spec * Removes default "Community" topic from application_mailer and makes topic optional * Refactors #prepopulate_new_form to resolve Code Climate failures * Refactors #email_from even further by use of a ternary operator per review suggestion * Simplifies the data_update script used to remove collective_noun per review request * Adds a data_update script to append community to community_name * Updates data_update script to correctly append Community to community_name * Removes RemoveCollectiveNounFromConfig and updates other script * Removes superfluous false from data_update script * Updates data_update script to be more idiomatic
248 lines
9.4 KiB
Ruby
248 lines
9.4 KiB
Ruby
require "rails_helper"
|
|
|
|
RSpec.describe "StoriesShow", type: :request do
|
|
let(:user) { create(:user) }
|
|
let(:org) { create(:organization) }
|
|
let(:article) { create(:article, user: user) }
|
|
|
|
describe "GET /:username/:slug (articles)" do
|
|
it "renders proper title" do
|
|
get article.path
|
|
expect(response.body).to include CGI.escapeHTML(article.title)
|
|
end
|
|
|
|
it "redirects to appropriate if article belongs to org and user visits user version" do
|
|
old_path = article.path
|
|
article.update(organization: org)
|
|
get old_path
|
|
expect(response.body).to redirect_to article.path
|
|
expect(response).to have_http_status(:moved_permanently)
|
|
end
|
|
|
|
it "preserves internal nav param (i=i) upon redirect" do
|
|
old_path = article.path
|
|
article.update(organization: org)
|
|
get "#{old_path}?i=i"
|
|
expect(response.body).to redirect_to "#{article.path}?i=i"
|
|
expect(response).to have_http_status(:moved_permanently)
|
|
end
|
|
|
|
it "does not have ?i=i on redirects which did not originally include it" do
|
|
old_path = article.path
|
|
article.update(organization: org)
|
|
get old_path
|
|
expect(response.body).not_to redirect_to "#{article.path}?i=i"
|
|
expect(response).to have_http_status(:moved_permanently)
|
|
end
|
|
|
|
it "does not have ?i=i on redirects without that precise param" do
|
|
old_path = article.path
|
|
article.update(organization: org)
|
|
get "#{old_path}?i=j"
|
|
expect(response.body).to redirect_to article.path
|
|
expect(response.body).not_to redirect_to "#{article.path}?i=j"
|
|
expect(response.body).not_to redirect_to "#{article.path}?i=j"
|
|
end
|
|
|
|
## Title tag
|
|
it "renders signed-in title tag for signed-in user" do
|
|
allow(SiteConfig).to receive(:community_emoji).and_return("🌱")
|
|
|
|
sign_in user
|
|
get article.path
|
|
|
|
title = "<title>#{CGI.escapeHTML(article.title)} - #{community_name} #{community_emoji}</title>"
|
|
expect(response.body).to include(title)
|
|
end
|
|
|
|
it "renders signed-out title tag for signed-out user" do
|
|
get article.path
|
|
expect(response.body).to include "<title>#{CGI.escapeHTML(article.title)} - #{community_name}</title>"
|
|
end
|
|
|
|
# search_optimized_title_preamble
|
|
|
|
it "renders title tag with search_optimized_title_preamble if set and not signed in" do
|
|
article.update_column(:search_optimized_title_preamble, "Hey this is a test")
|
|
get article.reload.path
|
|
|
|
expected_title = "<title>Hey this is a test: #{CGI.escapeHTML(article.title)} - #{community_name}</title>"
|
|
expect(response.body).to include(expected_title)
|
|
end
|
|
|
|
it "does not render title tag with search_optimized_title_preamble if set and not signed in" do
|
|
allow(SiteConfig).to receive(:community_emoji).and_return("🌱")
|
|
|
|
sign_in user
|
|
article.update_column(:search_optimized_title_preamble, "Hey this is a test")
|
|
get article.path
|
|
|
|
title = "<title>#{CGI.escapeHTML(article.title)} - #{community_name} #{community_emoji}</title>"
|
|
expect(response.body).to include(title)
|
|
end
|
|
|
|
it "does not render preamble with search_optimized_title_preamble not signed in but not set" do
|
|
get article.path
|
|
expect(response.body).to include("#{CGI.escapeHTML(article.title)} - #{community_name}</title>")
|
|
end
|
|
|
|
it "renders title preamble with search_optimized_title_preamble if set and not signed in" do
|
|
article.update_column(:search_optimized_title_preamble, "Hey this is a test")
|
|
get article.reload.path
|
|
expect(response.body).to include("<span class=\"fs-xl color-base-70 block\">Hey this is a test</span>")
|
|
end
|
|
|
|
it "does not render preamble with search_optimized_title_preamble if set and signed in" do
|
|
sign_in user
|
|
article.update_column(:search_optimized_title_preamble, "Hey this is a test")
|
|
get article.path
|
|
expect(response.body).not_to include("<span class=\"fs-xl color-base-70 block\">Hey this is a test</span>")
|
|
end
|
|
|
|
it "does not render title tag with search_optimized_title_preamble not signed in but not set" do
|
|
get article.path
|
|
expect(response.body).not_to include("<span class=\"fs-xl color-base-70 block\">Hey this is a test</span>")
|
|
end
|
|
|
|
###
|
|
|
|
it "renders date-no-year if article published this year" do
|
|
get article.path
|
|
expect(response.body).to include "date-no-year"
|
|
end
|
|
|
|
it "renders date with year if article published last year" do
|
|
article.update_column(:published_at, 1.year.ago)
|
|
get article.path
|
|
expect(response.body).not_to include "date-no-year"
|
|
end
|
|
|
|
it "renders user payment pointer if set" do
|
|
article.user.update_column(:payment_pointer, "this-is-a-pointer")
|
|
get article.path
|
|
expect(response.body).to include "author-payment-pointer"
|
|
expect(response.body).to include "this-is-a-pointer"
|
|
end
|
|
|
|
it "does not render payment pointer if not set" do
|
|
get article.path
|
|
expect(response.body).not_to include "author-payment-pointer"
|
|
end
|
|
|
|
it "renders second and third users if present" do
|
|
# 3rd user doesn't seem to get rendered for some reason
|
|
user2 = create(:user)
|
|
article.update(co_author_ids: [user2.id])
|
|
get article.path
|
|
expect(response.body).to include "<em>with <b><a href=\"#{user2.path}\">"
|
|
end
|
|
|
|
it "renders articles of long length without breaking" do
|
|
# This is a pretty weak test, just to exercise different lengths with no breakage
|
|
article.update(title: (0...75).map { rand(65..90).chr }.join)
|
|
get article.path
|
|
article.update(title: (0...100).map { rand(65..90).chr }.join)
|
|
get article.path
|
|
article.update(title: (0...118).map { rand(65..90).chr }.join)
|
|
get article.path
|
|
expect(response.body).to include "title"
|
|
end
|
|
|
|
it "redirects to appropriate page if user changes username" do
|
|
old_username = user.username
|
|
user.update(username: "new_hotness_#{rand(10_000)}")
|
|
get "/#{old_username}/#{article.slug}"
|
|
expect(response.body).to redirect_to("/#{user.username}/#{article.slug}")
|
|
expect(response).to have_http_status(:moved_permanently)
|
|
end
|
|
|
|
it "redirects to appropriate page if user changes username twice" do
|
|
old_username = user.username
|
|
user.update(username: "new_hotness_#{rand(10_000)}")
|
|
user.update(username: "new_new_username_#{rand(10_000)}")
|
|
get "/#{old_username}/#{article.slug}"
|
|
expect(response.body).to redirect_to("/#{user.username}/#{article.slug}")
|
|
expect(response).to have_http_status(:moved_permanently)
|
|
end
|
|
|
|
it "redirects to appropriate page if user changes username twice and go to middle username" do
|
|
user.update(username: "new_hotness_#{rand(10_000)}")
|
|
middle_username = user.username
|
|
user.update(username: "new_new_username_#{rand(10_000)}")
|
|
get "/#{middle_username}/#{article.slug}"
|
|
expect(response.body).to redirect_to("/#{user.username}/#{article.slug}")
|
|
expect(response).to have_http_status(:moved_permanently)
|
|
end
|
|
|
|
it "renders canonical url when exists" do
|
|
article = create(:article, with_canonical_url: true)
|
|
get article.path
|
|
expect(response.body).to include(%("canonical" href="#{article.canonical_url}"))
|
|
end
|
|
|
|
it "does not render canonical url when not on article model" do
|
|
article = create(:article, with_canonical_url: false)
|
|
get article.path
|
|
expect(response.body).not_to include(%("canonical" href="#{article.canonical_url}"))
|
|
end
|
|
|
|
it "handles invalid slug characters" do
|
|
allow(Article).to receive(:find_by).and_raise(ArgumentError)
|
|
get article.path
|
|
|
|
expect(response.status).to be(400)
|
|
end
|
|
|
|
it "has noindex if article has low score" do
|
|
article = create(:article, score: -5)
|
|
get article.path
|
|
expect(response.body).to include("noindex")
|
|
end
|
|
|
|
it "has noindex if article has low score even with <code>" do
|
|
article = create(:article, score: -5)
|
|
article.update_column(:processed_html, "<code>hello</code>")
|
|
get article.path
|
|
expect(response.body).to include("noindex")
|
|
end
|
|
|
|
it "does not have noindex if article has high score" do
|
|
article = create(:article, score: 6)
|
|
get article.path
|
|
expect(response.body).not_to include("noindex")
|
|
end
|
|
|
|
it "does not have noindex if article intermediate score and <code>" do
|
|
article = create(:article, score: 3)
|
|
article.update_column(:processed_html, "<code>hello</code>")
|
|
get article.path
|
|
expect(response.body).not_to include("noindex")
|
|
end
|
|
|
|
it "does not have noindex if article w/ intermediate score w/ 1 comment " do
|
|
article = create(:article, score: 3)
|
|
article.user.update_column(:comments_count, 1)
|
|
get article.path
|
|
expect(response.body).not_to include("noindex")
|
|
end
|
|
end
|
|
|
|
describe "GET /:username (org)" do
|
|
it "redirects to the appropriate page if given an organization's old slug" do
|
|
original_slug = org.slug
|
|
org.update(slug: "somethingnew")
|
|
get "/#{original_slug}"
|
|
expect(response.body).to redirect_to org.path
|
|
expect(response).to have_http_status(:moved_permanently)
|
|
end
|
|
|
|
it "redirects to the appropriate page if given an organization's old old slug" do
|
|
original_slug = org.slug
|
|
org.update(slug: "somethingnew")
|
|
org.update(slug: "anothernewslug")
|
|
get "/#{original_slug}"
|
|
expect(response.body).to redirect_to org.path
|
|
expect(response).to have_http_status(:moved_permanently)
|
|
end
|
|
end
|
|
end
|