docbrown/spec
Jeremy Friesen d462abb5b5
Ensuring article's cache updates on org image update (#17052)
There are three major things occurring in this pull request:

1. Renaming `Article#update_cached_user` to `Article#set_cached_entities`.
2. Reducing an organization's direct knowledge of which of the org's
   attributes an article caches.
3. Removing duplicate calls to update the article associated with the
   organization.

For renaming to `Article#set_cached_entities`, the prior method implied
we were updating the persistence layer.  However, we were not making any
save nor update calls.  This rename should clarify intention.

For reducing knowledge, the comments for
`Article::ATTRIBUTES_CACHED_FOR_RELATED_ENTITY` should explain the details.

And last, removing the duplicate calls; we had three methods that were
attempting to build and update the `Article#cached_organization`'s
value.

Closes forem/forem#17041
2022-04-01 10:54:55 -04:00
..
controllers/concerns 15 minute fix: Add default argument to JsonApiSortParam (#13369) 2021-04-14 10:32:07 +07:00
decorators Routine Rubocop fixes (#16838) 2022-03-09 09:32:50 -05:00
factories Award badges for github commits with various milestones (#14381) 2022-03-31 12:46:50 -04:00
fixtures Remove duplicated work display from header / profile work (#14210) 2021-07-30 12:28:40 +02:00
forms Routine Rubocop fixes (#16838) 2022-03-09 09:32:50 -05:00
generator Add service generator (#11265) 2020-11-10 09:09:35 +07:00
helpers Replace listings tag component (#16855) 2022-03-30 16:51:40 +01:00
initializers A suspended user returns 403 instead of 500 (#16408) 2022-02-04 09:42:23 -05:00
lib Remove the connect feature flag (#17061) 2022-03-30 14:51:45 -05:00
liquid_tags youtube tag timestamp format fix (#16873) 2022-03-22 08:55:45 -06:00
mailers "Reply to" and "From" Email addresses for SMTP Configurations (#16499) 2022-02-16 16:14:54 +02:00
models Ensuring article's cache updates on org image update (#17052) 2022-04-01 10:54:55 -04:00
policies Ensuring the same policies for analytics (#16997) 2022-03-25 14:57:01 -04:00
queries Fixes a name conflict in Rpush models (#15978) 2022-01-07 09:38:16 -06:00
refinements Update data exporter to handle admin send (#10274) 2020-10-26 18:00:56 -04:00
requests Ensuring that established tags don't respond 404 (#17058) 2022-04-01 10:25:28 -04:00
routing Scoping the :listing routes to feature (#16406) 2022-02-04 10:13:56 -05:00
sanitizers Don't sanitize anchor elements with no href (#16667) 2022-02-22 11:27:38 -06:00
serializers Refactoring to add helper method (#16064) 2022-01-12 11:21:44 -05:00
services Award badges for github commits with various milestones (#14381) 2022-03-31 12:46:50 -04:00
support Award badges for github commits with various milestones (#14381) 2022-03-31 12:46:50 -04:00
system Fixed hiding 'Click to edit' link for drafts (#17051) 2022-03-30 22:29:36 +03:00
tasks Make home link an admin-customisable navigation link (#16268) 2022-02-01 09:27:09 +00:00
uploaders Remove Remaining logo_svg Code (#16291) 2022-02-22 12:05:16 -07:00
validators Don't raise error when empty community emoji setting submitted (#15723) 2021-12-17 09:29:55 -06:00
view_objects Avoid using robohash for factory generated article cover images (#17024) 2022-03-28 14:01:29 -05:00
views Added a way to sort comments on an article (#16686) 2022-04-01 09:26:18 -05:00
workers Limit per-user feed import fanout to users with feed urls set (#16831) 2022-03-09 08:51:00 -06:00
i18n_spec.rb Show missing translation keys when test fails (#16637) 2022-02-17 16:21:29 -06:00
rails_helper.rb Removing a JS message about connect (#16982) 2022-03-23 12:30:59 -04:00
spec_helper.rb Bump to Rails 7.0.2.2 MVP (#15908) 2022-03-30 15:00:33 -04:00