195b202d85
* Use normal db transactions around tests An unrelated spec failure was observed when this was run before another test expecting the seed data to be present. It looks like the specific pain point in https://github.com/forem/forem/pull/8865 was around an rss reader spec (which is no longer in use) and I'd like to try reverting this truncation behavior here. The minimal failing test case I had on master was this ``` rspec ./spec/system/dashboards/user_sorts_dashboard_articles_spec.rb:44 ./spec/lib/data_update_scripts/fix_profile_field_edge_cases_spec.rb ``` The find_by(attribute:...) in the edge case spec returned nil (since there was no such profile field, the table had been truncated). Tests pass locally so this might be fine to just leave on the defaults (if that's the case the truncation support added in #8865 can also be removed, this is the last caller). * Reenable transactional feeds imports rhymes pointed out that a second test uses this db_strategy and that's the successor to the rss_feed_spec.rb that was the initial issue. Attempt removal of the truncation strategy, and reenable the transactional tests, for the feeds import. * Remove database cleaner Having removed the last use of it (in the feeds import spec) we no longer need this gem. * remove spec support for database cleaner |
||
|---|---|---|
| .. | ||
| user_followers_display_spec.rb | ||
| user_scrolls_down_dashboard_follows_spec.rb | ||
| user_sorts_dashboard_articles_spec.rb | ||
| user_visits_dashboard_spec.rb | ||