d6fde3ab89
* Changes PushNotifications::Send to use user_ids * Changes devices#destroy to use unauthenticated_params * Fix failing spec - new logic reverses order * Apply suggestions from code review Co-authored-by: Jamie Gaskins <jgaskins@gmail.com> * Only send new_comment PN with Rpush behind FeatureFlag + spec tweak * Add query order explicitly to avoid flakyness * Review feedback - remove order clause in query & other tweaks Co-authored-by: Jamie Gaskins <jgaskins@gmail.com>
88 lines
2.3 KiB
Ruby
88 lines
2.3 KiB
Ruby
require "rails_helper"
|
|
|
|
RSpec.describe "Devices", type: :request do
|
|
let(:user) { create(:user) }
|
|
|
|
before do
|
|
allow(FeatureFlag).to receive(:enabled?).with(:mobile_notifications).and_return(true)
|
|
sign_in user
|
|
end
|
|
|
|
describe "POST /users/devices" do
|
|
context "when device persisted" do
|
|
it "increases device count" do
|
|
post "/users/devices", params: {
|
|
token: "123",
|
|
platform: "Android",
|
|
app_bundle: "hello"
|
|
}
|
|
expect(user.devices.count).to eq(1)
|
|
end
|
|
end
|
|
|
|
context "when device not persisted" do
|
|
let(:params) do
|
|
{
|
|
token: "123",
|
|
platform: "unknown",
|
|
app_bundle: "hello"
|
|
}
|
|
end
|
|
|
|
it "does not increase device count" do
|
|
post "/users/devices", params: params
|
|
expect(user.devices.count).to eq(0)
|
|
end
|
|
|
|
it "returns an error" do
|
|
post "/users/devices", params: params
|
|
expect(response.status).to eq(400)
|
|
expect(response.body).to include("error")
|
|
end
|
|
end
|
|
end
|
|
|
|
describe "DELETE /users/devices/:id" do
|
|
let(:device) { create(:device, user: user) }
|
|
|
|
context "when device not found" do
|
|
let(:incomplete_params) do
|
|
{
|
|
platform: device.platform,
|
|
app_bundle: device.app_bundle
|
|
}
|
|
end
|
|
|
|
it "returns an error" do
|
|
delete "/users/devices/123"
|
|
expect(response.status).to eq(404)
|
|
expect(response.parsed_body["error"]).to eq("Not Found")
|
|
expect(response.parsed_body["status"]).to eq(404)
|
|
end
|
|
|
|
it "return an error if device id doesn't match params" do
|
|
delete "/users/devices/123", params: incomplete_params
|
|
expect(response.status).to eq(404)
|
|
expect(response.parsed_body["error"]).to eq("Not Found")
|
|
expect(response.parsed_body["status"]).to eq(404)
|
|
end
|
|
end
|
|
|
|
context "when device deleted" do
|
|
let(:params) do
|
|
{
|
|
token: device.token,
|
|
platform: device.platform,
|
|
app_bundle: device.app_bundle
|
|
}
|
|
end
|
|
|
|
it "deletes the device" do
|
|
delete "/users/devices/#{device.user.id}", params: params
|
|
expect(user.devices.count).to eq(0)
|
|
expect(response.status).to eq(204)
|
|
expect(Device.find_by(id: device.id)).to be_nil
|
|
end
|
|
end
|
|
end
|
|
end
|